Rusty Russell
2015-Feb-13 05:07 UTC
[PATCH] virtio: don't set VIRTIO_CONFIG_S_DRIVER_OK twice.
I noticed this with the console device. It's not *wrong*, just a bit weird. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index b9f70dfc4751..5ce2aa48fc6e 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -236,7 +236,10 @@ static int virtio_dev_probe(struct device *_d) if (err) goto err; - add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK); + /* If probe didn't do it, mark device DRIVER_OK ourselves. */ + if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK)) + virtio_device_ready(dev); + if (drv->scan) drv->scan(dev);
Apparently Analagous Threads
- [PATCH] virtio: don't set VIRTIO_CONFIG_S_DRIVER_OK twice.
- [PATCH 05/16] virtio: defer config changed notifications
- [PATCH v2 04/15] virtio: defer config changed notifications
- [PATCH v4 04/25] virtio: defer config changed notifications
- [PATCH v4 04/25] virtio: defer config changed notifications