Michael S. Tsirkin
2014-Nov-30 15:11 UTC
[PATCH v7 21/46] virtio_blk: make serial attribute static
It's never declared so no need to make it extern. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/block/virtio_blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index f601f16..055f3df 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -332,7 +332,8 @@ static ssize_t virtblk_serial_show(struct device *dev, return err; } -DEVICE_ATTR(serial, S_IRUGO, virtblk_serial_show, NULL); + +static DEVICE_ATTR(serial, S_IRUGO, virtblk_serial_show, NULL); static void virtblk_config_changed_work(struct work_struct *work) { -- MST
Cornelia Huck
2014-Dec-01 11:34 UTC
[PATCH v7 21/46] virtio_blk: make serial attribute static
On Sun, 30 Nov 2014 17:11:01 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote:> It's never declared so no need to make it extern. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/block/virtio_blk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com>
Apparently Analagous Threads
- [PATCH v7 21/46] virtio_blk: make serial attribute static
- [PATCH v4 18/42] virtio_blk: make serial attribute static
- [PATCH v4 18/42] virtio_blk: make serial attribute static
- [PATCH v6 21/46] virtio_blk: make serial attribute static
- [PATCH v6 21/46] virtio_blk: make serial attribute static