From: "Michael S. Tsirkin" <mst at redhat.com> Date: Sun, 5 Oct 2014 19:07:13 +0300> Now that virtio core ensures config changes don't arrive during probing, > drop config_enable flag in virtio net. > On removal, flush is now sufficient to guarantee that no change work is > queued. > > This help simplify the driver, and will allow setting DRIVER_OK earlier > without losing config change notifications. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>It's hard for people on the networking side to review these changes since you haven't CC:'d them on any of the postings necessary to understand the context of the net/ and drivers/net/ changes. Please at a minimum CC: everyone on your header [PATCH 0/N] posting so we know at least at a high level what is going on, and why. Thanks.
On Mon, Oct 06, 2014 at 03:02:38PM -0400, David Miller wrote:> From: "Michael S. Tsirkin" <mst at redhat.com> > Date: Sun, 5 Oct 2014 19:07:13 +0300 > > > Now that virtio core ensures config changes don't arrive during probing, > > drop config_enable flag in virtio net. > > On removal, flush is now sufficient to guarantee that no change work is > > queued. > > > > This help simplify the driver, and will allow setting DRIVER_OK earlier > > without losing config change notifications. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > It's hard for people on the networking side to review these changes > since you haven't CC:'d them on any of the postings necessary to > understand the context of the net/ and drivers/net/ changes. > > Please at a minimum CC: everyone on your header [PATCH 0/N] posting > so we know at least at a high level what is going on, and why. > > Thanks.It's a bit tricky for large patchsets - if I add everyone to 0/N then vger isn't happy with Cc list that is too large. What is your advice here? Cc just mailing lists on 0/N? FWIW this patchset is inteded for the virtio tree. -- MST
From: "Michael S. Tsirkin" <mst at redhat.com> Date: Tue, 7 Oct 2014 09:49:15 +0300> On Mon, Oct 06, 2014 at 03:02:38PM -0400, David Miller wrote: >> From: "Michael S. Tsirkin" <mst at redhat.com> >> Date: Sun, 5 Oct 2014 19:07:13 +0300 >> >> > Now that virtio core ensures config changes don't arrive during probing, >> > drop config_enable flag in virtio net. >> > On removal, flush is now sufficient to guarantee that no change work is >> > queued. >> > >> > This help simplify the driver, and will allow setting DRIVER_OK earlier >> > without losing config change notifications. >> > >> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> >> >> It's hard for people on the networking side to review these changes >> since you haven't CC:'d them on any of the postings necessary to >> understand the context of the net/ and drivers/net/ changes. >> >> Please at a minimum CC: everyone on your header [PATCH 0/N] posting >> so we know at least at a high level what is going on, and why. >> >> Thanks. > > It's a bit tricky for large patchsets - if I add everyone to 0/N > then vger isn't happy with Cc list that is too large. > > What is your advice here? Cc just mailing lists on 0/N? > > FWIW this patchset is inteded for the virtio tree.CC: mailing lists and "focus" developers, a small carefully selected group of people who would be strongly interested in this change. I really don't understand why this is so complicated, I've never run into a situation where I had to CC: 200 people in my two decades of kernel development :-/