Alok Kataria
2013-Sep-04 08:53 UTC
[PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
Hey, This change adds an entry to the maintainers file to explicitly state that any changes to vmware.c should be sent to the authors of the file as well. If you are thinking why do this now, off late we have seen quite a few changes that touched the "arch/x86/kernel/cpu/vmware.c" file but were not directed to me, someone else made me aware of those changes. It could be that my use of different SOB lines "Alok N Kataria" vs "Alok Kataria" confuses get_maintainer.pl, but adding this entry in MAINTAINERS should solve the problem at hand. For one of the changes [1], I did verify that get_maintainer.pl, now expectedly includes me in the cc list. Thanks, Alok [1] http://marc.info/?l=linux-kernel&m=137571112610984&w=2>From : Alok Kataria <akataria at vmware.com>Add an entry in MAINTAINERS file to reflect the authors of a file. Signed-off-by: Alok Kataria <akataria at vmware.com> Index: linux-2.6/MAINTAINERS ==================================================================--- linux-2.6.orig/MAINTAINERS 2013-09-04 14:07:34.404027068 +0530 +++ linux-2.6/MAINTAINERS 2013-09-04 14:20:39.714026943 +0530 @@ -9038,6 +9038,12 @@ F: drivers/vme/ F: include/linux/vme* +VMWARE HYPERVISOR INTERFACE +M: Alok Kataria <akataria at vmware.com> +L: virtualization at lists.linux-foundation.org +S: Supported +F: arch/x86/kernel/cpu/vmware.c + VMWARE VMXNET3 ETHERNET DRIVER M: Shreyas Bhatewara <sbhatewara at vmware.com> M: "VMware, Inc." <pv-drivers at vmware.com>
H. Peter Anvin
2013-Sep-04 11:45 UTC
[PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
On 09/04/2013 01:53 AM, Alok Kataria wrote:> Hey, > > This change adds an entry to the maintainers file to explicitly state > that any changes to vmware.c should be sent to the authors of the file > as well. > > If you are thinking why do this now, off late we have seen quite a few > changes that touched the "arch/x86/kernel/cpu/vmware.c" file but were > not directed to me, someone else made me aware of those changes. It > could be that my use of different SOB lines "Alok N Kataria" vs "Alok > Kataria" confuses get_maintainer.pl, but adding this entry in > MAINTAINERS should solve the problem at hand. For one of the changes > [1], I did verify that get_maintainer.pl, now expectedly includes me in > the cc list. > > Thanks, > Alok >That is indeed what the maintainers file is for.> Add an entry in MAINTAINERS file to reflect the authors of a file.No, it reflects the *maintainer(s)* of a file. -hpa
Joe Perches
2013-Sep-04 17:16 UTC
[PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
On Wed, 2013-09-04 at 14:23 +0530, Alok Kataria wrote:> Hey, > > This change adds an entry to the maintainers file to explicitly state > that any changes to vmware.c should be sent to the authors of the file > as well.It never hurts to add MAINTAINER entries.> If you are thinking why do this now, off late we have seen quite a few > changes that touched the "arch/x86/kernel/cpu/vmware.c" file but were > not directed to me, someone else made me aware of those changes.Many people don't use get_maintainer> It > could be that my use of different SOB lines "Alok N Kataria" vs "Alok > Kataria" confuses get_maintainer.pl,That shouldn't be a problem unless the email addresses are also different.> +++ linux-2.6/MAINTAINERS 2013-09-04 14:20:39.714026943 +0530[]> +VMWARE HYPERVISOR INTERFACE > +M: Alok Kataria <akataria at vmware.com> > +L: virtualization at lists.linux-foundation.org > +S: Supported > +F: arch/x86/kernel/cpu/vmware.c > +It'd be nicer to use tabs after the colon
Alok Kataria
2013-Sep-05 04:46 UTC
[PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
On Wed, 2013-09-04 at 10:16 -0700, Joe Perches wrote:> On Wed, 2013-09-04 at 14:23 +0530, Alok Kataria wrote: > > Hey, > > > > This change adds an entry to the maintainers file to explicitly state > > that any changes to vmware.c should be sent to the authors of the file > > as well. > > It never hurts to add MAINTAINER entries. > > > If you are thinking why do this now, off late we have seen quite a few > > changes that touched the "arch/x86/kernel/cpu/vmware.c" file but were > > not directed to me, someone else made me aware of those changes. > > Many people don't use get_maintainer > > > It > > could be that my use of different SOB lines "Alok N Kataria" vs "Alok > > Kataria" confuses get_maintainer.pl, > > That shouldn't be a problem unless the email addresses are > also different. > > > +++ linux-2.6/MAINTAINERS 2013-09-04 14:20:39.714026943 +0530 > [] > > +VMWARE HYPERVISOR INTERFACE > > +M: Alok Kataria <akataria at vmware.com> > > +L: virtualization at lists.linux-foundation.org > > +S: Supported > > +F: arch/x86/kernel/cpu/vmware.c > > + > > It'd be nicer to use tabs after the colonOops, my current workspace had a different tab setting, thanks for noticing. Regenerated the diffs on latest tip, tree. Peter can you please apply this one as well. --- Fix whitespace issues. Signed-off-by: Alok Kataria <akataria at vmware.com> Index: linux.trees.git/MAINTAINERS ==================================================================--- linux.trees.git.orig/MAINTAINERS 2013-09-05 10:11:31.784339571 +0530 +++ linux.trees.git/MAINTAINERS 2013-09-05 10:11:47.364339672 +0530 @@ -9041,10 +9041,10 @@ F: include/linux/vme* VMWARE HYPERVISOR INTERFACE -M: Alok Kataria <akataria at vmware.com> -L: virtualization at lists.linux-foundation.org -S: Supported -F: arch/x86/kernel/cpu/vmware.c +M: Alok Kataria <akataria at vmware.com> +L: virtualization at lists.linux-foundation.org +S: Supported +F: arch/x86/kernel/cpu/vmware.c VMWARE VMXNET3 ETHERNET DRIVER M: Shreyas Bhatewara <sbhatewara at vmware.com>
Apparently Analagous Threads
- [PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
- [PATCH] Add an entry in MAINTAINERS for VMware's hypervisor interface
- [PATCH] MAINTAINERS: Update PARAVIRT_OPS_INTERFACE and VMWARE_HYPERVISOR_INTERFACE
- [PATCH] maintainers: drop Chris Wright from pvops
- [PATCH] maintainers: drop Chris Wright from pvops