From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
Those symbols only used within this file, and should be static.
Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
drivers/char/virtio_console.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 13ad9b1..f73ad64 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -78,8 +78,8 @@ struct ports_driver_data {
};
static struct ports_driver_data pdrvdata;
-DEFINE_SPINLOCK(pdrvdata_lock);
-DECLARE_COMPLETION(early_console_added);
+static DEFINE_SPINLOCK(pdrvdata_lock);
+static DECLARE_COMPLETION(early_console_added);
/* This struct holds information that's relevant only for console ports */
struct console {
@@ -1202,7 +1202,7 @@ int __init virtio_cons_early_init(int (*put_chars)(u32,
const char *, int))
return hvc_instantiate(0, 0, &hv_ops);
}
-int init_port_console(struct port *port)
+static int init_port_console(struct port *port)
{
int ret;
On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote:> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn> > > Those symbols only used within this file, and should be static. > > Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>Acked-by: Amit Shah <amit.shah at redhat.com> Amit
Rusty Russell
2013-Apr-08 13:28 UTC
[PATCH -next] virtio_console: make local symbols static
Amit Shah <amit.shah at redhat.com> writes:> On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote: >> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn> >> >> Those symbols only used within this file, and should be static. >> >> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn> > > Acked-by: Amit Shah <amit.shah at redhat.com> > > AmitThanks, applied. Cheers, Rusty.
Maybe Matching Threads
- [PATCH -next] virtio_console: make local symbols static
- [PATCH] xen-pciback: fix error return code in pcistub_irq_handler_switch()
- [PATCH] xen-pciback: fix error return code in pcistub_irq_handler_switch()
- [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()
- [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()