Michael S. Tsirkin
2012-Sep-09 11:08 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set". An obvious thinko, should be port 1 onwards. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- virtio-spec.lyx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index a713807..d801aa6 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0). status open \begin_layout Plain Layout -Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set +Ports +\change_inserted 1986246365 1347188327 +1 +\change_deleted 1986246365 1347188327 +2 +\change_unchanged + onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set \end_layout \end_inset -- MST
Amit Shah
2012-Sep-09 20:58 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
On (Sun) 09 Sep 2012 [14:08:37], Michael S. Tsirkin wrote:> spec numbers ports port0, port 1 etc, then goes on to say > "ports 2 onwards only if MULTIPORT is set". > An obvious thinko, should be port 1 onwards. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Acked-by: Amit Shah <amit.shah at redhat.com> Amit
Michael S. Tsirkin
2012-Nov-12 16:59 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:> spec numbers ports port0, port 1 etc, then goes on to say > "ports 2 onwards only if MULTIPORT is set". > An obvious thinko, should be port 1 onwards. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Ping.> --- > virtio-spec.lyx | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/virtio-spec.lyx b/virtio-spec.lyx > index a713807..d801aa6 100644 > --- a/virtio-spec.lyx > +++ b/virtio-spec.lyx > @@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0). > status open > > \begin_layout Plain Layout > -Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set > +Ports > +\change_inserted 1986246365 1347188327 > +1 > +\change_deleted 1986246365 1347188327 > +2 > +\change_unchanged > + onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set > \end_layout > > \end_inset > -- > MST
Michael S. Tsirkin
2012-Dec-12 08:22 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:> spec numbers ports port0, port 1 etc, then goes on to say > "ports 2 onwards only if MULTIPORT is set". > An obvious thinko, should be port 1 onwards. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Rusty, Amit, any feedback?> --- > virtio-spec.lyx | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/virtio-spec.lyx b/virtio-spec.lyx > index a713807..d801aa6 100644 > --- a/virtio-spec.lyx > +++ b/virtio-spec.lyx > @@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0). > status open > > \begin_layout Plain Layout > -Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set > +Ports > +\change_inserted 1986246365 1347188327 > +1 > +\change_deleted 1986246365 1347188327 > +2 > +\change_unchanged > + onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set > \end_layout > > \end_inset > -- > MST
Amit Shah
2012-Dec-12 09:14 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote:> On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote: > > spec numbers ports port0, port 1 etc, then goes on to say > > "ports 2 onwards only if MULTIPORT is set". > > An obvious thinko, should be port 1 onwards. > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Rusty, Amit, any feedback?http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980 Amit
Michael S. Tsirkin
2012-Dec-12 09:23 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
On Wed, Dec 12, 2012 at 02:44:20PM +0530, Amit Shah wrote:> On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote: > > On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote: > > > spec numbers ports port0, port 1 etc, then goes on to say > > > "ports 2 onwards only if MULTIPORT is set". > > > An obvious thinko, should be port 1 onwards. > > > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > > Rusty, Amit, any feedback? > > http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980 > > AmitAh you acked. Rusty can you pick this up please?
Rusty Russell
2012-Dec-14 01:01 UTC
[PATCH] virtio-spec: fix thinko in multiport documentation
"Michael S. Tsirkin" <mst at redhat.com> writes:> On Wed, Dec 12, 2012 at 02:44:20PM +0530, Amit Shah wrote: >> On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote: >> > On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote: >> > > spec numbers ports port0, port 1 etc, then goes on to say >> > > "ports 2 onwards only if MULTIPORT is set". >> > > An obvious thinko, should be port 1 onwards. >> > > >> > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> >> > >> > Rusty, Amit, any feedback? >> >> http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980 >> >> Amit > > Ah you acked. > Rusty can you pick this up please?Thanks, done. Cheers, Rusty.