Vasiliy Kulikov
2010-Oct-28 11:39 UTC
[PATCH] xen: xenfs: privcmd: check put_user() return code
put_user() may fail. In this case propagate error code from privcmd_ioctl_mmap_batch(). Signed-off-by: Vasiliy Kulikov <segooon at gmail.com> --- Compile tested. drivers/xen/xenfs/privcmd.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c index f80be7f..2eb04c8 100644 --- a/drivers/xen/xenfs/privcmd.c +++ b/drivers/xen/xenfs/privcmd.c @@ -266,9 +266,7 @@ static int mmap_return_errors(void *data, void *state) xen_pfn_t *mfnp = data; struct mmap_batch_state *st = state; - put_user(*mfnp, st->user++); - - return 0; + return put_user(*mfnp, st->user++); } static struct vm_operations_struct privcmd_vm_ops; @@ -323,10 +321,8 @@ static long privcmd_ioctl_mmap_batch(void __user *udata) up_write(&mm->mmap_sem); if (state.err > 0) { - ret = 0; - state.user = m.arr; - traverse_pages(m.num, sizeof(xen_pfn_t), + ret = traverse_pages(m.num, sizeof(xen_pfn_t), &pagelist, mmap_return_errors, &state); } -- 1.7.0.4
Jeremy Fitzhardinge
2010-Oct-29 17:18 UTC
[PATCH] xen: xenfs: privcmd: check put_user() return code
On 10/28/2010 04:39 AM, Vasiliy Kulikov wrote:> put_user() may fail. In this case propagate error code from > privcmd_ioctl_mmap_batch().Thanks for looking at this. I'm in two minds about this; the existing logic is such that these put_users can only fail if something else has already failed and its returning an error. I guess it would be useful to get an EFAULT if you've got a problem writing back the results. IanC, any opinion? Thanks, J> Signed-off-by: Vasiliy Kulikov <segooon at gmail.com> > --- > Compile tested. > > drivers/xen/xenfs/privcmd.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c > index f80be7f..2eb04c8 100644 > --- a/drivers/xen/xenfs/privcmd.c > +++ b/drivers/xen/xenfs/privcmd.c > @@ -266,9 +266,7 @@ static int mmap_return_errors(void *data, void *state) > xen_pfn_t *mfnp = data; > struct mmap_batch_state *st = state; > > - put_user(*mfnp, st->user++); > - > - return 0; > + return put_user(*mfnp, st->user++); > } > > static struct vm_operations_struct privcmd_vm_ops; > @@ -323,10 +321,8 @@ static long privcmd_ioctl_mmap_batch(void __user *udata) > up_write(&mm->mmap_sem); > > if (state.err > 0) { > - ret = 0; > - > state.user = m.arr; > - traverse_pages(m.num, sizeof(xen_pfn_t), > + ret = traverse_pages(m.num, sizeof(xen_pfn_t), > &pagelist, > mmap_return_errors, &state); > }
Possibly Parallel Threads
- [PATCH] xen: xenfs: privcmd: check put_user() return code
- [patch 3/3] xen/privcmd: remove const modifier from declaration
- [patch 3/3] xen/privcmd: remove const modifier from declaration
- [RFC 00/14] arm: implement ballooning and privcmd foreign mappings based on x86 PVH
- [patch 1/3] xen/privcmd: check for integer overflow in ioctl