Tobias Klauser
2010-May-17 13:12 UTC
[PATCH] vhost: Storage class should be before const qualifier
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser at distanz.ch>
---
drivers/vhost/net.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index aa88911..cd36f5f 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -626,7 +626,7 @@ static long vhost_net_compat_ioctl(struct file *f, unsigned
int ioctl,
}
#endif
-const static struct file_operations vhost_net_fops = {
+static const struct file_operations vhost_net_fops = {
.owner = THIS_MODULE,
.release = vhost_net_release,
.unlocked_ioctl = vhost_net_ioctl,
--
1.6.3.3
Michael S. Tsirkin
2010-May-17 13:13 UTC
[PATCH] vhost: Storage class should be before const qualifier
On Mon, May 17, 2010 at 03:12:49PM +0200, Tobias Klauser wrote:> The C99 specification states in section 6.11.5: > > The placement of a storage-class specifier other than at the beginning > of the declaration specifiers in a declaration is an obsolescent > feature. > > Signed-off-by: Tobias Klauser <tklauser at distanz.ch>Will apply, thanks! Just to clarify: does some compiler/checker actually barf on this?> --- > drivers/vhost/net.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index aa88911..cd36f5f 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -626,7 +626,7 @@ static long vhost_net_compat_ioctl(struct file *f, unsigned int ioctl, > } > #endif > > -const static struct file_operations vhost_net_fops = { > +static const struct file_operations vhost_net_fops = { > .owner = THIS_MODULE, > .release = vhost_net_release, > .unlocked_ioctl = vhost_net_ioctl, > -- > 1.6.3.3