tgingold at free.fr
2008-Mar-30 14:34 UTC
[kvm-ia64-devel] [09/17] [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64.
Hi, Selon "Zhang, Xiantao" <xiantao.zhang at intel.com>:> >From 5f82ea88c095cf89cbae920944c05e578f35365f Mon Sep 17 00:00:00 2001 > From: Xiantao Zhang <xiantao.zhang at intel.com> > Date: Wed, 12 Mar 2008 14:48:09 +0800 > Subject: [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64.[...]> + post_update = (inst.M5.i << 7) + inst.M5.imm7; > + if (inst.M5.s) > + temp -= post_update; > + else > + temp += post_update;The sign extension is not done correctly here. (This has been fixed in Xen code).> + post_update = (inst.M3.i << 7) + inst.M3.imm7; > + if (inst.M3.s) > + temp -= post_update; > + else > + temp += post_update;Ditto.> + post_update = (inst.M10.i << 7) + inst.M10.imm7; > + if (inst.M10.s) > + temp -= post_update; > + else > + temp += post_update;Ditto.> + post_update = (inst.M10.i << 7) + inst.M10.imm7; > + if (inst.M10.s) > + temp -= post_update; > + else > + temp += post_update;Ditto.> + post_update = (inst.M15.i << 7) + inst.M15.imm7; > + if (inst.M15.s) > + temp -= post_update; > + else > + temp += post_update;Ditto. Tristan.