tinc devel - Nov 2010 - Dashes in node names

Hi,
I'am using a script which manages the setup of nodes. This depends on
zeroconf and so the tinc node name and the hostname must match.

But tinc doesn't allow dashes in node names. Is this really is
necessary? Dashes in hostnames are not really uncommon.

Is there something which prevents appling such a diff?:

----- start diff -----
diff -ruNp tinc-1.0.13/src/protocol.c tinc-1.0.13.new1/src/protocol.c
--- tinc-1.0.13/src/protocol.c 2010-03-13 18:53:33.000000000 +0100
+++ tinc-1.0.13.new1/src/protocol.c 2010-11-15 15:11:05.056142676 +0100
@@ -56,7 +56,7 @@ static avl_tree_t *past_request_tree;
 
 bool check_id(const char *id) {
        for(; *id; id++)
-               if(!isalnum(*id) && *id != '_')
+               if(!isalnum(*id) && *id != '_' && *id !=
'-')
                        return false;
 
        return true;
----- end diff -----

mfg,
dnjl

On Mon, Nov 15, 2010 at 03:25:40PM +0100, Daniel Baumann wrote:
> I'am using a script which manages the setup of nodes. This depends on
> zeroconf and so the tinc node name and the hostname must match.
> 
> But tinc doesn't allow dashes in node names. Is this really is
> necessary? Dashes in hostnames are not really uncommon.
> 
> Is there something which prevents appling such a diff?:
The dash is used as a separator between the node name and "up" and
"down". If
one allows the dash in the node name, there will be an ambiguity between a node
called "foo-up" and the script that is run when the node
"foo" has become
reachable.

In a script you can use the "tr - _" command to replace dashes with
underscores.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL:
<http://www.tinc-vpn.org/pipermail/tinc-devel/attachments/20101115/40f4b7c7/attachment.pgp>