David Kuehling
2007-Sep-08 06:28 UTC
[theora-dev] patch: more options for encoder_example.c
Hi, every time I check out a new theora version, I hack encoder_example.c to tune some of the codec options (theora_info::keyframe_frequency, noise_sensitivity and sharpness). This time I finally tried to do it right and added some command line options. Patch attached. Any chance this can get committed? regards, David -- GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg Fingerprint: B17A DC95 D293 657B 4205 D016 7DEF 5323 C174 7D40 -------------- next part -------------- A non-text attachment was scrubbed... Name: encoder_example.diff Type: text/x-diff Size: 3404 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora-dev/attachments/20070908/67c43d6e/encoder_example.bin
Hi, On Sep 8, 2007, at 15:26:15, David Kuehling wrote:> every time I check out a new theora version, I hack > encoder_example.c to > tune some of the codec options (theora_info::keyframe_frequency, > noise_sensitivity and sharpness). This time I finally tried to do it > right and added some command line options. > > Patch attached. Any chance this can get committed?looks almost fine, applied to svn using the same names used in the api though, no need to introduce another set of names... j
David Kuehling
2007-Sep-15 04:03 UTC
[theora-dev] patch: more options for encoder_example.c
>>>>> "j" == j <j@v2v.cc> writes:> looks almost fine, applied to svn using the same names used in the api > though, no need to introduce another set of names...You overlooked one line during renaming (long option was still named "--noise-suppress"). Patch attached. cheers, David -- GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg Fingerprint: B17A DC95 D293 657B 4205 D016 7DEF 5323 C174 7D40 -------------- next part -------------- A non-text attachment was scrubbed... Name: encoder_example.diff Type: text/x-diff Size: 569 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora-dev/attachments/20070915/3cb9c5ad/encoder_example.bin