hpa wrote:> On July 7, 2019 8:37:10 AM PDT, Sebastian Herbszt <herbszt at gmx.de> > wrote: > >Gene, > > > >it looks like the syslinux master branch is broken since February > >[1]. Peter created the wip.makefixes branch but I wasn't able to get > >it working (yet) and it lacks activity since March. > > > >I think it might be time to revert commit 458a54133ecd ("Fix all > >warnings, and better separate code that should not be mixed") which > >broke master. Then apply at least the outstanding patch "Force the > >linker to put all sections into a single PT_LOAD segment" [2] from > >Debian which is required for EFI. And maybe tag the result as > >syslinux-6.04-pre4. > > > >[1] https://www.syslinux.org/archives/2019-February/026335.html > >[2] https://www.syslinux.org/archives/2018-August/026167.html > > > >Sebastian > > Could you make a tree that I can pull?A new temporary branch named 20190723 is now available at git://repo.or.cz/syslinux/sherbszt.git It contains the following commits: d9374841 Add exp function 303c54a0 Some fixes from commit 458a5413 e8df886e Force the linker to put all sections into a single PT_LOAD segment 1a18b2ee Revert "Fix all warnings, and better separate code that should not be mixed" Sebastian
On Tue, Jul 23, 2019 at 1:30 PM Sebastian Herbszt <herbszt at gmx.de> wrote:> > hpa wrote: > > On July 7, 2019 8:37:10 AM PDT, Sebastian Herbszt <herbszt at gmx.de> > > wrote: > > >Gene, > > > > > >it looks like the syslinux master branch is broken since February > > >[1]. Peter created the wip.makefixes branch but I wasn't able to get > > >it working (yet) and it lacks activity since March. > > > > > >I think it might be time to revert commit 458a54133ecd ("Fix all > > >warnings, and better separate code that should not be mixed") which > > >broke master. Then apply at least the outstanding patch "Force the > > >linker to put all sections into a single PT_LOAD segment" [2] from > > >Debian which is required for EFI. And maybe tag the result as > > >syslinux-6.04-pre4. > > > > > >[1] https://www.syslinux.org/archives/2019-February/026335.html > > >[2] https://www.syslinux.org/archives/2018-August/026167.html > > > > > >Sebastian > > > > Could you make a tree that I can pull? > > A new temporary branch named 20190723 is now available at > git://repo.or.cz/syslinux/sherbszt.git > > It contains the following commits: > > d9374841 Add exp function > 303c54a0 Some fixes from commit 458a5413 > e8df886e Force the linker to put all sections into a single PT_LOAD segment > 1a18b2ee Revert "Fix all warnings, and better separate code that should not be mixed" > > SebastianTo be honest, I'd rather go as far back as moving to a less confusing gnu-efi version (3.07 iirc) then apply stuff and branch off for gnu-efi 3.08+ considering its massive changes. -- -Gene
> To be honest, I'd rather go as far back as moving to a less confusing > gnu-efi version (3.07 iirc) then apply stuff and branch off for gnu-efi > 3.08+ considering its massive changes.OTOH, the gnu-efi submodule is not pointing to the latest gnu-efi commit, nor to the 'latest commit + the still-"open"-after-3-months merge request'. Considering that the recent few commits in gnu-efi are particularly relevant for Syslinux (but that are not being used by the gnu-efi submodule in Syslinux, IIUC), this is clearly another thing to test/track/account for.
Gene Cumm wrote:> On Tue, Jul 23, 2019 at 1:30 PM Sebastian Herbszt <herbszt at gmx.de> > wrote: > > > > hpa wrote: > > > On July 7, 2019 8:37:10 AM PDT, Sebastian Herbszt <herbszt at gmx.de> > > > wrote: > > > >Gene, > > > > > > > >it looks like the syslinux master branch is broken since February > > > >[1]. Peter created the wip.makefixes branch but I wasn't able to > > > >get it working (yet) and it lacks activity since March. > > > > > > > >I think it might be time to revert commit 458a54133ecd ("Fix all > > > >warnings, and better separate code that should not be mixed") > > > >which broke master. Then apply at least the outstanding patch > > > >"Force the linker to put all sections into a single PT_LOAD > > > >segment" [2] from Debian which is required for EFI. And maybe > > > >tag the result as syslinux-6.04-pre4. > > > > > > > >[1] https://www.syslinux.org/archives/2019-February/026335.html > > > >[2] https://www.syslinux.org/archives/2018-August/026167.html > > > > > > > >Sebastian > > > > > > Could you make a tree that I can pull? > > > > A new temporary branch named 20190723 is now available at > > git://repo.or.cz/syslinux/sherbszt.git > > > > It contains the following commits: > > > > d9374841 Add exp function > > 303c54a0 Some fixes from commit 458a5413 > > e8df886e Force the linker to put all sections into a single PT_LOAD > > segment 1a18b2ee Revert "Fix all warnings, and better separate code > > that should not be mixed" > > > > Sebastian > > To be honest, I'd rather go as far back as moving to a less confusing > gnu-efi version (3.07 iirc) then apply stuff and branch off for > gnu-efi 3.08+ considering its massive changes.How far do you want to go back? Until syslinux-6.04-pre1-41-g5e426532 ("core/Makefile: sort to be reproducible") and merge it with syslinux-6.04-pre1-43-ga3a10a4e ("Use CC for CC_FOR_BUILD when unspecified.")? That would be few commits before syslinux-6.04-pre2 and give you gnu-efi 3.0.6. Neither 3.0.7 nor 3.0.8 were used in syslinux. The jump was from 3.0.6 to 3.0.9-3-gd34132e. There are 7 commits between 3.0.6 and 3.0.7. gnu-efi 3.0.8 contains 19 and 3.0.9 yet another 4 commits. Sebastian