On 2/7/19 4:03 AM, Joakim Tjernlund wrote:>>> >>> Hi, >>> >>> I merged your tree and added the install patch on top of it. Thank you! >>> >>> -hpa >> >> Is it worth doing another -pre immediately since upgrading gnu-efi >> took such a large leap? My thought is if someone has an issue with >> the new proposed -pre, they can try -pre2 with minimal differences to >> separate a gnu-efi related issue from others. > > NP, but I would fix the link problem with gnu-efi >= 3.0.8 first, just adding a -z muldefs > will work for all versions I think. >-z muldefs would bloat the libraries unnecessarily, but worse it might mask real errors. There is a good reason we snapshot gnu-efi as opposed to using whatever version the user has... -hpa
On Thu, 2019-02-07 at 13:14 -0800, H. Peter Anvin wrote:> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > On 2/7/19 4:03 AM, Joakim Tjernlund wrote: > > > > Hi, > > > > > > > > I merged your tree and added the install patch on top of it. Thank you! > > > > > > > > -hpa > > > > > > Is it worth doing another -pre immediately since upgrading gnu-efi > > > took such a large leap? My thought is if someone has an issue with > > > the new proposed -pre, they can try -pre2 with minimal differences to > > > separate a gnu-efi related issue from others. > > > > NP, but I would fix the link problem with gnu-efi >= 3.0.8 first, just adding a -z muldefs > > will work for all versions I think. > > > > -z muldefs would bloat the libraries unnecessarily, but worse it might > mask real errors.Looking into the debian patches posted here I see that not using -z muldefs causes bugs. I think you should just use muldefs and report the duplicated memset/memcpy syms in gnu-efi as an bug as gnu-efi has no business defining these, its a lib.> > There is a good reason we snapshot gnu-efi as opposed to using whatever > version the user has... > > -hpa > >
On Thu, 2019-02-07 at 21:49 +0000, Joakim Tjernlund via Syslinux wrote:> On Thu, 2019-02-07 at 13:14 -0800, H. Peter Anvin wrote: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > > On 2/7/19 4:03 AM, Joakim Tjernlund wrote: > > > > > Hi, > > > > > > > > > > I merged your tree and added the install patch on top of it. Thank you! > > > > > > > > > > -hpa > > > > > > > > Is it worth doing another -pre immediately since upgrading gnu-efi > > > > took such a large leap? My thought is if someone has an issue with > > > > the new proposed -pre, they can try -pre2 with minimal differences to > > > > separate a gnu-efi related issue from others. > > > > > > NP, but I would fix the link problem with gnu-efi >= 3.0.8 first, just adding a -z muldefs > > > will work for all versions I think. > > > > > > > -z muldefs would bloat the libraries unnecessarily, but worse it might > > mask real errors. > > Looking into the debian patches posted here I see that not using -z muldefs causes > bugs. I think you should just use muldefs and report the duplicated memset/memcpy syms > in gnu-efi as an bug as gnu-efi has no business defining these, its a lib.ehh, there a bug already. Created by me some time ago. Completely forgot about that :) Please chime in ...