Syslinux - Mar 2016 - [PATCH 0/1] EFI image booting capabilities

>>>
<syslinux at zytor.com> wrote:
> This patch adds to the core EFI image booting capabilities.
> It was tested on VMware EFI clients and HP Elitebook EFI notebooks,
> only on PXE environments but it should work on non-PXE scenarios as well.
>
> Feedback appreciated.
If you've made any changes to this, I'd definitely like to see it.  If
you have any interest in working with git and want some help, feel

free to email me privately.
<<<

I posted this code time ago, there were some changes, I have tried removing

the ones not really related to the EFI boot capability.
(at that moment they were needed; if not SL was not working.) 

see here:
https://github.com/ppatpat/syslinux/tree/boot_efi
Please consider: 

1)I've copied the source from my work repository but I have no tested
the just uploaded github sources.
2) This code was only tested on PXE boot scenarios.
3) The easiest way to test this code would be something like 

kernel    = /Shell.efi
append    = -nomap -nostartup

>>>
For starters, this deserves to be split, unrelated changes to their
own commits, the body and then finally a glue commit to put it

together.
<<<
I removed The tiny bits of non-related code present in the original patch

>>>
Changing existing functionality like this may have negative
consequences and splitting helps if a bisection is needed.
<<<
I think you cannot split anything else; the present code is 
all needed for EFI boot.

>>>
I have avery strong preference towards micro-commits of changing functionality
for this reason.  It helps point to fewer lines of changes.  On the
other hand, adding new functionality is sometimes better done in fewer
commits, often 1-2 and if two, the first adds the code while the

second adds the glue to tie it into the existing code.
-
--Gene

<<<
Well I think you just cannot add EFI boot with micro commits.


Give it a try and let me know.
(I still do not receive the list)

Best,
Patrick

On Sun, Mar 20, 2016 at 1:47 PM, Patrick Masotta <masottaus at yahoo.com>
wrote:
>>>>
>
> <syslinux at zytor.com> wrote:
>> This patch adds to the core EFI image booting capabilities.
>> It was tested on VMware EFI clients and HP Elitebook EFI notebooks,
>> only on PXE environments but it should work on non-PXE scenarios as
well.
>>
>> Feedback appreciated.
>
> If you've made any changes to this, I'd definitely like to see it. 
If
> you have any interest in working with git and want some help, feel
>
> free to email me privately.
> <<<
>
> I posted this code time ago, there were some changes, I have tried removing
>
> the ones not really related to the EFI boot capability.
> (at that moment they were needed; if not SL was not working.)
>
> see here:
> https://github.com/ppatpat/syslinux/tree/boot_efi
> Please consider:
>
> 1)I've copied the source from my work repository but I have no tested
> the just uploaded github sources.
> 2) This code was only tested on PXE boot scenarios.
> 3) The easiest way to test this code would be something like
>
> kernel    = /Shell.efi
> append    = -nomap -nostartup
Somehow I overlooked that and actually have your repo as a remote for
tracking but forgot the difference in naming between your Yahoo!
account and GitHub account.
>>>>
> For starters, this deserves to be split, unrelated changes to their
> own commits, the body and then finally a glue commit to put it
>
> together.
> <<<
> I removed The tiny bits of non-related code present in the original patch
>
>
>>>>
>
> Changing existing functionality like this may have negative
> consequences and splitting helps if a bisection is needed.
> <<<
> I think you cannot split anything else; the present code is
> all needed for EFI boot.
>
>
>>>>
I have split it, added commits, reverted and done a rebase with fixup.
> I have avery strong preference towards micro-commits of changing
functionality
> for this reason.  It helps point to fewer lines of changes.  On the
> other hand, adding new functionality is sometimes better done in fewer
> commits, often 1-2 and if two, the first adds the code while the
>
> second adds the glue to tie it into the existing code.
> -
> --Gene
>
> <<<
> Well I think you just cannot add EFI boot with micro commits.
>
>
> Give it a try and let me know.
git/https: https://github.com/geneC/syslinux.git
branches: ppatpat-efi-1 ppatpat-efi-3

https://github.com/geneC/syslinux/tree/ppatpat-efi-1
https://github.com/geneC/syslinux/tree/ppatpat-efi-3

The first demonstrates my micro-commit preference.  The second shows
how I can use git-rebase to collapse it together, preserving the one
function-changing commit out of the feature-adding commits.
> (I still do not receive the list)
Patrick, I'm not sure why but I am now seeing traffic in my Yahoo!
account from this mailing list including your last message though
seems to have had significant delays.

-- 
-Gene

On Sat, Mar 26, 2016 at 5:03 PM, Patrick Masotta <masottaus at yahoo.com>
wrote:
>>>>
>
>
> git/https: https://github.com/geneC/syslinux.git
> branches: ppatpat-efi-1 ppatpat-efi-3
>
> https://github.com/geneC/syslinux/tree/ppatpat-efi-1
> https://github.com/geneC/syslinux/tree/ppatpat-efi-3
>
> The first demonstrates my micro-commit preference.  The second shows
> how I can use git-rebase to collapse it together, preserving the one
> function-changing commit out of the feature-adding commits.
> <<<
> Hi Gene,
> I'll take a look at them.
> BTW did you get a binary compiled & tested including the new code?
Compile is OK.  Existing tests seem unaffected.  Loading syslinux.efi
itself causes a soft hang.  Found a shellx64.efi from a ISO that works
well.

-- 
-Gene

On Fri, Mar 25, 2016 at 03:03:07PM -0400, Gene Cumm via Syslinux
wrote:
> 
> git/https: https://github.com/geneC/syslinux.git
> branches: ppatpat-efi-1 ppatpat-efi-3
> 
> https://github.com/geneC/syslinux/tree/ppatpat-efi-1
> https://github.com/geneC/syslinux/tree/ppatpat-efi-3
> 
> The first demonstrates my micro-commit preference.  The second shows
> how I can use git-rebase to collapse it together, preserving the one
> function-changing commit out of the feature-adding commits.
Hi Gene,

I'll take a look at them.
BTW did you get a binary compiled & tested including the new code?

> > (I still do not receive the list)
> 
> Patrick, I'm not sure why but I am now seeing traffic in my Yahoo!
> account from this mailing list including your last message though
> seems to have had significant delays.
A few days ago the pipe got unstuck and I've received even the missing
e-mails.Currently I'm receiving the list correctly

Best,Patrick