Syslinux - Aug 2015 - EFI: HP + syslinux = crash [ brown paper bag update ]

On 11-08-15 10:07, Patrick Masotta wrote:
> Please implement these new changes over your last non-debug
> working build (multi-nic fix) and let's see how it goes.
>
> https://github.com/ppatpat/syslinux/compare/master...ppatpat:zlib?expand=1
>
> Please report your results.
Results are in. They are very good. No crashing even with the original 
config!

>>>
 >
 Please implement these new changes over your last non-debug
 > working build (multi-nic fix) and let's see how it goes.
 >
 > https://github.com/ppatpat/syslinux/compare/master...ppatpat:zlib?expand=1
 >
 > Please report your results.
 
 Results are in. They are very good. 
 No crashing even with the original config!
 <<<

It is also working here; I think this particular PNG issue is fixed.

It's worth to mention that the replaced code looks valid to me; that's
why I think
this is probably some sort of compiler bug. It was really hard to find.
We should keep an eye on this issue; it might appear somewhere else.

Best,
Patrick

On Tue, Aug 11, 2015 at 9:11 AM, Patrick Masotta via Syslinux
<syslinux at zytor.com> wrote:
>  >>>
>  >
>  Please implement these new changes over your last non-debug
>  > working build (multi-nic fix) and let's see how it goes.
>  >
>  >
https://github.com/ppatpat/syslinux/compare/master...ppatpat:zlib?expand=1
>  >
>  > Please report your results.
>
>  Results are in. They are very good.
>  No crashing even with the original config!
>  <<<
>
> It is also working here; I think this particular PNG issue is fixed.
>
> It's worth to mention that the replaced code looks valid to me;
that's why I think
> this is probably some sort of compiler bug. It was really hard to find.
> We should keep an eye on this issue; it might appear somewhere else.
Eww.  The original code was merely an empty define.  That's pretty nasty.

Alternatively, we could void them

-#  define Assert(cond,msg)
+#  define Assert(cond,msg) ((void)0)

--
-Gene