(snip)> horked in terms of existing URLs, but if someone finds a URL that > doesn't work, I'll hammer on it.Thank you. Perhaps the following (examples of) redirection links could be improved? In the following pairs of links, the first line is the old (gitweb-caching style) link, and the second line would be the destination of the redirection as it would be expected (at least, IMHO). http://git.zytor.com/?o=descr http://git.zytor.com/?s=desc http://git.zytor.com/?o=owner http://git.zytor.com/?s=owner http://git.zytor.com/?o=age http://git.zytor.com/?s=idle Heads: http://git.zytor.com/?p=syslinux/syslinux.git;a=heads http://git.zytor.com/syslinux/syslinux.git/refs/heads The redirection of "shortlog" works as expected: http://git.zytor.com/?p=syslinux/syslinux.git;a=shortlog http://git.zytor.com/syslinux/syslinux.git/log/ but the redirection of a "log" (as in gitweb-caching terminology) should rather redirect to the "expanded log" in cgit (note the "?showmsg=1" flag): http://git.zytor.com/?p=syslinux/syslinux.git;a=log http://git.zytor.com/syslinux/syslinux.git/log/?showmsg=1 And similarly: http://git.zytor.com/?p=syslinux/syslinux.git;a=log;h=refs/tags/syslinux -4.07 http://git.zytor.com/syslinux/syslinux.git/log/?id=refs/tags/syslinux-4. 07&showmsg=1 Tag examples (note the "a=tag" -> "/tag/" parts of the links, instead of "a=commit" -> "/commit/"): http://git.zytor.com/?p=syslinux/syslinux.git;a=tags http://git.zytor.com/syslinux/syslinux.git/refs/tags http://git.zytor.com/?p=syslinux/syslinux.git;a=tag;h=refs/tags/syslinux -4.07 http://git.zytor.com/syslinux/syslinux.git/tag/?id=syslinux-4.07 http://git.zytor.com/syslinux/syslinux.git/tag/?id=a4fcb6d867aadcaf5af8f 87eb1ba96abe2748159 http://git.zytor.com/syslinux/syslinux.git/tag/?id=syslinux-4.07 Snapshot example: http://git.zytor.com/?p=syslinux/syslinux.git;a=snapshot;h=61f106ba8a5b2 a7c2d9855291fd9e7f4a4d3143d;sf=tgz Note that in this example, the "sf=" parameter is "sf=tgz". So perhaps it should go to: http://git.zytor.com/syslinux/syslinux.git/snapshot/syslinux-61f106ba8a5 b2a7c2d9855291fd9e7f4a4d3143d.tar.gz I think that an old "gitweb-chaching" snapshot link should either take the new link format (according to the file format; in the example: "sf=tgz" -> ".tar.gz"), and if it fails (e.g. the file does not exist) it should fallback to the respective commit id. In this example, the fallback (i.e. commit id) would be: http://git.zytor.com/syslinux/syslinux.git/commit/?id=61f106ba8a5b2a7c2d 9855291fd9e7f4a4d3143d where several file formats would be available as snapshots for download. TIA, Ady.
On 06/11/2015 07:24 AM, Ady via Syslinux wrote:> > (snip) > >> horked in terms of existing URLs, but if someone finds a URL that >> doesn't work, I'll hammer on it. > > Thank you. > > Perhaps the following (examples of) redirection links could be > improved? >OK, I think I have fixed these, at least to the extend that doing so is possible/practical. -hpa
> On 06/11/2015 07:24 AM, Ady via Syslinux wrote: > > > > (snip) > > > >> horked in terms of existing URLs, but if someone finds a URL that > >> doesn't work, I'll hammer on it. > > > > Thank you. > > > > Perhaps the following (examples of) redirection links could be > > improved? > > > > OK, I think I have fixed these, at least to the extend that doing so is > possible/practical. > > -hpaThank you Peter. I have to apologize. I might have made some mistake or some complex-mixing in my prior post, thus making it more complicated than needed regarding "tags". The ";a=heads -> /refs/heads" is now OK: http://git.zytor.com/?p=syslinux/syslinux.git;a=heads http://git.zytor.com/syslinux/syslinux.git/refs/heads But the ";a=tags -> /refs/tags" is not OK yet (should be easy to correct, right?): http://git.zytor.com/?p=syslinux/syslinux.git;a=tags http://git.zytor.com/syslinux/syslinux.git/refs/tags Additionally, there is also ";h=refs/tags/ -> /tag/?id=": http://git.zytor.com/?p=syslinux/syslinux.git;a=shortlog;h=refs/tags/sys linux-4.07 http://git.zytor.com/syslinux/syslinux.git/tag/?id=syslinux-4.07 but in this case the ";h=" part of the old gitweb-caching link _might_ conflict with its ";a=" part for the conversion / redirection (see below). These old links (using ";h=ref/tags/") were all valid (and different), and were all available from the ";a=tags" screen (among others): http://git.zytor.com/?p=syslinux/syslinux.git;a=log;h=refs/tags/syslinux -4.07 http://git.zytor.com/?p=syslinux/syslinux.git;a=shortlog;h=refs/tags/sys linux-4.07 http://git.zytor.com/?p=syslinux/syslinux.git;a=commit;h=61f106ba8a5b2a7 c2d9855291fd9e7f4a4d3143d http://git.zytor.com/?p=syslinux/syslinux.git;a=tag;h=a4fcb6d867aadcaf5a f8f87eb1ba96abe2748159 so I am not sure how this ";h=refs/tags/" should be managed. Perhaps "Warthog9" might have some suggestion about these ";h=refs/tags/" cases? Regarding snapshots, an old gitweb-caching link such as: http://git.zytor.com/?p=syslinux/syslinux.git;a=snapshot;h=61f106ba8a5b2 a7c2d9855291fd9e7f4a4d3143d;sf=tgz seems to be converted now to something like: http://git.zytor.com/syslinux/syslinux.git/snapshot/syslinux-61f106ba8a5 b2a7c2d9855291fd9e7f4a4d3143d.tar.gz?id=61f106ba8a5b2a7c2d9855291fd9e7f4 a4d3143d Note the extra "id=..." part at the end, after the "tar.gz". It still downloads the tar.gz archive, and I wouldn't want to interfere with some other redirection. It still works, but I thought I should mention it, just in case it happens to matter for some other link. On the other hand, perhaps the ending "id=..." here is required by some other conversion / redirection, for example from an old link that uses some tag or some head reference, instead of using the same commit id? TIA, Ady.
> On 06/11/2015 07:24 AM, Ady via Syslinux wrote: > > > > (snip) > > > >> horked in terms of existing URLs, but if someone finds a URL that > >> doesn't work, I'll hammer on it. > > > > Thank you. > > > > Perhaps the following (examples of) redirection links could be > > improved? > > > > OK, I think I have fixed these, at least to the extend that doing so is > possible/practical. > > -hpaAbout a link such as: http://git.zytor.com/syslinux/syslinux.git /tag/?id=syslinux-4.07 Q: shouldn't it be as follows?: http://git.zytor.com/syslinux/syslinux.git /tag/?id=refs/tags/syslinux-4.07 Isn't the current syntax (without explicitly using "refs/tags/") in conflict with the corresponding tag object (which seems to be currently inactive / unsupported / failing in git.zytor.com, but it is valid in other Syslinux repos): http://git.zytor.com/syslinux/syslinux.git /tag/?id=a4fcb6d867aadcaf5af8f87eb1ba96abe2748159 In other words, isn't the "refs/tags/" section of the link required, so to avoid any potential conflict between the tag *name* and the tag *value*? Perhaps I am misunderstanding the differences between "?id=", "?id2=" and others ("h=", "hb="...) and when exactly each of them should be used in the links. If I am, please forgive my ignorance. I wonder whether this potential conflict (if there is one) could generate some problem, if not in git.zytor.com/syslinux/syslinux.git itself, then perhaps in other repo(s) following it? TIA, Ady.