Syslinux - Jan 2015 - [PATCH 0/9] linux/syslinux: support ext2/3/4 device

On 01/06/2015 08:04 AM, H. Peter Anvin wrote:
> On 01/01/2015 09:05 PM, Robert Yang wrote:
>> Hello,
>>
>> Happy New Year!
>>
>> These patches make syslinux/linux support ext2/3/4, and it doesn't
>> require the root privilege, I'd like to add a separate
e2fs/syslinux, if
>> that is more appropriate, it should be easy to do that.
>>
>> I put these patches on github so that you can easily get them in case
>> you'd like to test them. (The repo's name is sys_tmp, which
avoids
>> confusing others, I will remove the repo when these patches are
>> reviewed).
>>
>
> In my opinion, linux/syslinux really should just be part of extlinux,
> since it is exactly equivalent to mounting the filesystem, running
> extlinux, and unmounting the filesystem.  That automatically adds
> support for all filesystems.
>
> mtools/syslinux is the one that doesn't require root privileges, and
> where libext2fs belongs.  Ideally the FAT support ought to be
> internalized into a library, too.
>
> The one thing with mtools/syslinux is that some people like to compile
> it for non-Linux platforms (how successfully, I don't know) and so
> ext*fs support should probably be conditionalized.
Thanks for the reply, how about:

1) Add the libext2fs' syslinux to mtools/syslinux
2) The "make" will compile libext2fs by default, and make EXT2FS=0
will disable
    the compile ?

// Robert
>
> 	-hpa
>
>
>

On 01/05/2015 04:14 PM, Robert Yang wrote:
> 
> On 01/06/2015 08:04 AM, H. Peter Anvin wrote:
>> On 01/01/2015 09:05 PM, Robert Yang wrote:
>>> Hello,
>>>
>>> Happy New Year!
>>>
>>> These patches make syslinux/linux support ext2/3/4, and it
doesn't
>>> require the root privilege, I'd like to add a separate
e2fs/syslinux, if
>>> that is more appropriate, it should be easy to do that.
>>>
>>> I put these patches on github so that you can easily get them in
case
>>> you'd like to test them. (The repo's name is sys_tmp, which
avoids
>>> confusing others, I will remove the repo when these patches are
>>> reviewed).
>>>
>>
>> In my opinion, linux/syslinux really should just be part of extlinux,
>> since it is exactly equivalent to mounting the filesystem, running
>> extlinux, and unmounting the filesystem.  That automatically adds
>> support for all filesystems.
>>
>> mtools/syslinux is the one that doesn't require root privileges,
and
>> where libext2fs belongs.  Ideally the FAT support ought to be
>> internalized into a library, too.
>>
>> The one thing with mtools/syslinux is that some people like to compile
>> it for non-Linux platforms (how successfully, I don't know) and so
>> ext*fs support should probably be conditionalized.
> 
> Thanks for the reply, how about:
> 
> 1) Add the libext2fs' syslinux to mtools/syslinux
> 2) The "make" will compile libext2fs by default, and make
EXT2FS=0 will
> disable
>    the compile ?
> 
Works for me.

	-hpa

On 01/06/2015 08:16 AM, H. Peter Anvin wrote:
> On 01/05/2015 04:14 PM, Robert Yang wrote:
>>
>> On 01/06/2015 08:04 AM, H. Peter Anvin wrote:
>>> On 01/01/2015 09:05 PM, Robert Yang wrote:
>>>> Hello,
>>>>
>>>> Happy New Year!
>>>>
>>>> These patches make syslinux/linux support ext2/3/4, and it
doesn't
>>>> require the root privilege, I'd like to add a separate
e2fs/syslinux, if
>>>> that is more appropriate, it should be easy to do that.
>>>>
>>>> I put these patches on github so that you can easily get them
in case
>>>> you'd like to test them. (The repo's name is sys_tmp,
which avoids
>>>> confusing others, I will remove the repo when these patches are
>>>> reviewed).
>>>>
>>>
>>> In my opinion, linux/syslinux really should just be part of
extlinux,
>>> since it is exactly equivalent to mounting the filesystem, running
>>> extlinux, and unmounting the filesystem.  That automatically adds
>>> support for all filesystems.
>>>
>>> mtools/syslinux is the one that doesn't require root
privileges, and
>>> where libext2fs belongs.  Ideally the FAT support ought to be
>>> internalized into a library, too.
>>>
>>> The one thing with mtools/syslinux is that some people like to
compile
>>> it for non-Linux platforms (how successfully, I don't know) and
so
>>> ext*fs support should probably be conditionalized.
>>
>> Thanks for the reply, how about:
>>
>> 1) Add the libext2fs' syslinux to mtools/syslinux
>> 2) The "make" will compile libext2fs by default, and make
EXT2FS=0 will
>> disable
>>     the compile ?
>>
>
> Works for me.
Hello,

After more investigations, I'm a little worried about add the extX support
to mtools/syslinux:
1) Its name is mtools/syslinux, can't express the libext2fs.
2) The mtools/syslinux isn't fully functioned, for example, as the code
shows:
     if (opt.sectors || opt.heads || opt.reset_adv || opt.set_once
         || (opt.update_only > 0) || opt.menu_save) {
         fprintf(stderr,
                 "At least one specified option not yet implemented"
                 " for this installer.\n");
         exit(1);


How about add an e2fs/syslinux, please ?

// Robert
>
> 	-hpa
>
>
>
>