Raphael S Carvalho
2013-Sep-16 14:46 UTC
[syslinux] [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
On Mon, Sep 16, 2013 at 11:08 AM, Matt Fleming <matt at console-pimps.org> wrote:> Peter, does this look OK to you? > > Raphael, I can't work out why ADV_SIZE is a constant in this file?Matt, ADV_SIZE is currently a constant value, but it may change in the future. So it would need some care. Regards, Raphael S. Carvalho
H. Peter Anvin
2013-Sep-16 14:49 UTC
[syslinux] [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
We probably will need to increase out to 4K because of newer drives. Raphael S Carvalho <raphael.scarv at gmail.com> wrote:>On Mon, Sep 16, 2013 at 11:08 AM, Matt Fleming <matt at console-pimps.org> >wrote: >> Peter, does this look OK to you? >> >> Raphael, I can't work out why ADV_SIZE is a constant in this file? > >Matt, ADV_SIZE is currently a constant value, but it may change in the >future. >So it would need some care. > >Regards, >Raphael S. Carvalho-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
Matt Fleming
2013-Sep-16 16:23 UTC
[syslinux] [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
On Mon, 16 Sep, at 09:49:01AM, H. Peter Anvin wrote:> We probably will need to increase out to 4K because of newer drives.Raphael, is there any way we could extract the ADV_SIZE value from libinstaller/setadv.h and pass it to ldlinux_limit.pl? That would allow things to keep working in future when we do upgrade to 4K. -- Matt Fleming, Intel Open Source Technology Center
Apparently Analagous Threads
- [PATCH v2] core: Check size of ldlinux.sys at building time.
- [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
- [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
- [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.
- [PATCH 1/1] core: Check if ldlinux.sys exceeds the limit at its building time.