On Thu, 27 Jun, at 11:45:28AM, Matt Fleming wrote:> I'll bisect to see why this broke after 5.01.Which is... commit 5447ef821c24b526079ef785d2454ed0efff3e2b Author: Matt Fleming <matt.fleming at intel.com> Date: Thu Feb 28 17:44:54 2013 +0000 ldlinux: Always update ConfigName when opening a config file With the introduction of commit aa7dd29db684 ("ldlinux: Pass config filename as argv[1] to ldlinux.c32") we stopped using ConfigName to store the filename of the config file we intend to open in execute() since it interfered with the filesystem-specific open_config() implementations. But a side-effect of this change is that syslinux_config_file() no longer works if we explicitly pass a filename to parse_config_file(). The logical place to keep ConfigName in sync is in parse_config_file() since it's expected that all the filesystem-specific open_config() functions will fill out ConfigName for us. In the case where the filename is supplied by the caller, we need to fill it out ourselves. Signed-off-by: Matt Fleming <matt.fleming at intel.com> Thanks for the report folks. This is fixed in 5.11-pre3 and will be in 6.01-pre5 when that gets released. -- Matt Fleming, Intel Open Source Technology Center
Hi, Tested with 5.11-pre3. Thanks, Romain ----- Mail original ----- | De: "Matt Fleming" <matt at console-pimps.org> | ?: "Romain Naour" <romain.naour at openwide.fr> | Cc: helmut at hullen.de, "For discussion of Syslinux and tftp-hpa" <syslinux at zytor.com> | Envoy?: Jeudi 27 Juin 2013 14:18:03 | Objet: Re: [syslinux] Syslinux 6.00 released | | On Thu, 27 Jun, at 11:45:28AM, Matt Fleming wrote: | > I'll bisect to see why this broke after 5.01. | | Which is... | | commit 5447ef821c24b526079ef785d2454ed0efff3e2b | Author: Matt Fleming <matt.fleming at intel.com> | Date: Thu Feb 28 17:44:54 2013 +0000 | | ldlinux: Always update ConfigName when opening a config file | | With the introduction of commit aa7dd29db684 ("ldlinux: Pass | config | filename as argv[1] to ldlinux.c32") we stopped using ConfigName | to | store the filename of the config file we intend to open in | execute() | since it interfered with the filesystem-specific open_config() | implementations. But a side-effect of this change is that | syslinux_config_file() no longer works if we explicitly pass a | filename to parse_config_file(). | | The logical place to keep ConfigName in sync is in | parse_config_file() | since it's expected that all the filesystem-specific | open_config() | functions will fill out ConfigName for us. In the case where the | filename is supplied by the caller, we need to fill it out | ourselves. | | Signed-off-by: Matt Fleming <matt.fleming at intel.com> | | Thanks for the report folks. This is fixed in 5.11-pre3 and will be | in | 6.01-pre5 when that gets released. | | -- | Matt Fleming, Intel Open Source Technology Center |
On Thu, 27 Jun, at 02:34:43PM, Romain Naour wrote:> Hi, > > Tested with 5.11-pre3.And does it work? ;-) -- Matt Fleming, Intel Open Source Technology Center
Hallo, Matt, Du meintest am 27.06.13:>> I'll bisect to see why this broke after 5.01.[...]> Thanks for the report folks. This is fixed in 5.11-pre3 and will be > in 6.01-pre5 when that gets released.I've just compiled 5.11-pre3 and tested the pxelinux part: all problems have gone! Thank you! Viele Gruesse! Helmut