Don Hiatt
2010-Mar-16 18:51 UTC
[syslinux] com32/modules/disk patch to fix crash (syslinux 4)
This patch fixes a crash in disk.c32 owing to the change in get_error()'s signature. Instead of calling get_error() I just dump the error code. don diff --git a/com32/modules/disk.c b/com32/modules/disk.c index e94a36b..2966173 100644 --- a/com32/modules/disk.c +++ b/com32/modules/disk.c @@ -37,11 +37,8 @@ int main(int argc __attribute__ (( unused )), continue; if (err) { - get_error(err, &error_buffer); - printf("Error 0x%Xh while reading disk 0x%X:\n %s\n", - err, d->disk, error_buffer); - free(error_buffer); - continue; + printf("Error 0x%Xh while reading disk 0x%X\n", err, d->disk); + continue; } printf("DISK 0x%X:\n", d->disk);
Miller, Shao
2010-Jul-02 09:57 UTC
[syslinux] com32/modules/disk patch to fix crash (syslinux 4)
Don's get_error() signature-change concern addressed by Erwan's patch later on: commit 9d193b67979bae7feaf62186f8dc6d989c085ba6 Author: Erwan Velu <erwanaliasr1 at gmail.com> Date: Wed May 12 21:10:47 2010 +0200 disk: Fixing get_error() call get_error prototype changed since this module was written --- - Shao Miller -----Original Message----- From: syslinux-bounces at zytor.com [mailto:syslinux-bounces at zytor.com] On Behalf Of Don Hiatt Sent: Tuesday, March 16, 2010 14:51 To: syslinux at zytor.com Subject: [syslinux] com32/modules/disk patch to fix crash (syslinux 4) This patch fixes a crash in disk.c32 owing to the change in get_error()'s signature. Instead of calling get_error() I just dump the error code. ... ... ...