Syslinux - Apr 2009 - The maximum number of rows in a com32 menu

Hey Murali,
While playing with HDT which uses your menu, I found I can't reach more 
than 24 rows whereas my screen is 25.

set_windows_size() relies on getnumrows() to define the maximum number 
of possible rows.
But regarding to getnumrows() code, it sounds to report "// Actually 
numrows - 1".
On my screen which is 80x25, getnumcols x getrowcols reports 80x24.

The set_windows_size() is so refusing to set the screen up to 80x25.

Is it a desired behavior or can we fix the menuing system by replacing 
getnumrows() calls by getnumrows()+1 ?

Erwan,

IIRC the adjustment by 1 was because in one case BIOS returns the # of
row/col and in the other the index of the largest one (0 based). If
that is wrong feel free to remove the "-1" in getnumrows().

- Murali

2009/4/15 Erwan <erwan at seanodes.com>:
> Hey Murali,
> While playing with HDT which uses your menu, I found I can't reach more
than
> 24 rows whereas my screen is 25.
>
> set_windows_size() relies on getnumrows() to define the maximum number of
> possible rows.
> But regarding to getnumrows() code, it sounds to report "// Actually
numrows
> - 1".
> On my screen which is 80x25, getnumcols x getrowcols reports 80x24.
>
> The set_windows_size() is so refusing to set the screen up to 80x25.
>
> Is it a desired behavior or can we fix the menuing system by replacing
> getnumrows() calls by getnumrows()+1 ?
>
> Erwan,
>


-- 
Murali

?????? ?? ??? ????, ???????? ??????
(What we know is only a handful, what we dont is the rest of the world)

Murali (????? ?????) wrote:
> IIRC the adjustment by 1 was because in one case BIOS returns the # of
> row/col and in the other the index of the largest one (0 based). If
> that is wrong feel free to remove the "-1" in getnumrows().
The BIOS variables are somewhat confusing indeed: one is the number of 
columns and the other is the last row, so for an 80x25 screen they are 
80 and 24, respectively.

However, realistically the right thing is to remove this stuff from 
cmenu and instead use the features provided by ansicon.

	-hpa