Sebastian Herbszt
2008-Jul-07 20:28 UTC
[syslinux] [RESEND][PATCH] pcitest: display "1 bus found" instead of "1 buses found"
Fix the text for pci_bus_list->count == 1 ("1 bus found").
- Sebastian
Index: syslinux-20080615/com32/modules/pcitest.c
==================================================================---
syslinux-20080615.orig/com32/modules/pcitest.c 2008-06-16 21:45:00.000000000
+0200
+++ syslinux-20080615/com32/modules/pcitest.c 2008-06-16 21:47:10.000000000
+0200
@@ -93,7 +93,7 @@
}
printf("PCI: %d bus%s found\n",
pci_bus_list->count,
- pci_bus_list->count == 1 ? "es" : "");
+ pci_bus_list->count == 1 ? "" : "es");
}
int main(int argc, char *argv[])
H. Peter Anvin
2008-Jul-07 21:28 UTC
[syslinux] [RESEND][PATCH] pcitest: display "1 bus found" instead of "1 buses found"
Sebastian Herbszt wrote:> Fix the text for pci_bus_list->count == 1 ("1 bus found").Applied, thanks. -hpa
Ryan McLean
2008-Jul-08 09:19 UTC
[syslinux] [RESEND][PATCH] pcitest: display "1 bus found" instead of "1 buses found"
H. Peter Anvin wrote:> Sebastian Herbszt wrote: > >> Fix the text for pci_bus_list->count == 1 ("1 bus found"). >> > > Applied, thanks. > > -hpa > > _______________________________________________ > SYSLINUX mailing list > Submissions to SYSLINUX at zytor.com > Unsubscribe or set options at: > http://www.zytor.com/mailman/listinfo/syslinux > Please do not send private replies to mailing list traffic. > >TBH it seems like an unnecessary bit of code surely: printf("PCI: %d bus(es) found\n", pci_bus_list->count); would be better. -- Regards, Ryan McLean Systems Administrator Accelrys Limited (http://www.accelrys.com) Registered office: 334 Cambridge Science Park, Cambridge, CB4 0WN, UK Registered in England: 2326316
H. Peter Anvin
2008-Jul-08 19:58 UTC
[syslinux] [RESEND][PATCH] pcitest: display "1 bus found" instead of "1 buses found"
Ryan McLean wrote:> TBH it seems like an unnecessary bit of code surely: > > printf("PCI: %d bus(es) found\n", pci_bus_list->count); > > would be better.Acceptable, perhaps, but *better*? -hpa
Ryan McLean
2008-Jul-09 08:47 UTC
[syslinux] [RESEND][PATCH] pcitest: display "1 bus found" instead of "1 buses found"
H. Peter Anvin wrote:> Ryan McLean wrote: > >> TBH it seems like an unnecessary bit of code surely: >> >> printf("PCI: %d bus(es) found\n", pci_bus_list->count); >> >> would be better. >> > > Acceptable, perhaps, but *better*? > > -hpa > > _______________________________________________ > SYSLINUX mailing list > Submissions to SYSLINUX at zytor.com > Unsubscribe or set options at: > http://www.zytor.com/mailman/listinfo/syslinux > Please do not send private replies to mailing list traffic. > >Perhaps *better* was the wrong word, but it was meant in terms of both reducing lines of code and removing code that serves no real purpose. -- Regards, Ryan McLean Accelrys Limited (http://www.accelrys.com) Registered office: 334 Cambridge Science Park, Cambridge, CB4 0WN, UK Registered in England: 2326316