Syslinux - Feb 2004 - SYSLINUX 2.09-pre5 - Menu Depth "Feature"

HPA, 
	I believe I've found a possible bug with /menu.

This against the unmodified -pre5 snapshot.
 
SRC: http://www.survivaldisk.com/menutest.c
COMPILED: http://www.survivaldisk.com/menutest.com

It's easiest explained if you just compile the .c and experience it for
yourself, anyways.

If you have two submenus nested within each other and then call a third menu
it will bring up the second menu instead of the third.

  MAIN = add_menu(" Main Menu ");
  add_item("Begin Menu Depth Test","Only Allows Depth Of
Two",OPT_SUBMENU,NULL,ONE);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);

  ONE = add_menu(" LEVEL 1 ");
  add_item("GOTO LEVEL 2","Go one level
up",OPT_SUBMENU,NULL,TWO);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);

  TWO = add_menu(" LEVEL 2 ");
  add_item("GOTO LEVEL 3","Go one level
up",OPT_SUBMENU,NULL,TWO);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);
  [snip]

End result of selecting goto LEVEL 2 is that it brings up a new submenu
containing LEVEL 1 instead of LEVEL2.

 
>I have just released SYSLINUX 2.09-pre4 with a few changes:
>
>a) SYSLINUX should now correctly handle mode changes from within a 
>COMBOOT program.
>
>b) Tweaks to the menu system to avoid the "grey text on black"
problem.
>
>c) A new color scheme for the menu system (Murali, check it out and see 
>if you think it works for you.)
>
>ftp://ftp.kernel.org/pub/linux/utils/boot/syslinux/Testing/
>
>Please test it out, everyone...
>
>	-hpa

Here's another possible bug with /menu.

As before, it's against the unmoidief -pre5 snapshot.


SRC: http://www.survivaldisk.com/menutest2.c
COMPILED: http://www.survivaldisk.com/menutest2.com 

A submenu with a large name when gone into will not 100% clean up and remove
the menuname if you goto the previous menu.

In my example I've got a submenu called:

1234567890123456789012

If I am to go into that submenu and then go back to the main menu

It will clean up the screen all except for the last char

i.e. 123456789012345678901 is removed from the screen and the end "2"
is not
and remains perm on the screen until the next comboot session.

I'm at home right now so I'm unable to test under isolinux or pxelinux.

These are the results I am getting within a cmd shell,

-----Original Message-----
From: syslinux-bounces at zytor.com [mailto:syslinux-bounces at zytor.com] On
Behalf Of Geoffrey Huntley
Sent: Tuesday, February 03, 2004 8:29 PM
To: syslinux at zytor.com
Subject: [syslinux] SYSLINUX 2.09-pre5 - Menu Depth "Feature"

HPA, 
	I believe I've found a possible bug with /menu.

This against the unmodified -pre5 snapshot.
 
SRC: http://www.survivaldisk.com/menutest.c
COMPILED: http://www.survivaldisk.com/menutest.com

It's easiest explained if you just compile the .c and experience it for
yourself, anyways.

If you have two submenus nested within each other and then call a third menu
it will bring up the second menu instead of the third.

  MAIN = add_menu(" Main Menu ");
  add_item("Begin Menu Depth Test","Only Allows Depth Of
Two",OPT_SUBMENU,NULL,ONE);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);

  ONE = add_menu(" LEVEL 1 ");
  add_item("GOTO LEVEL 2","Go one level
up",OPT_SUBMENU,NULL,TWO);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);

  TWO = add_menu(" LEVEL 2 ");
  add_item("GOTO LEVEL 3","Go one level
up",OPT_SUBMENU,NULL,TWO);
  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
0);
  [snip]

End result of selecting goto LEVEL 2 is that it brings up a new submenu
containing LEVEL 1 instead of LEVEL2.

 
>I have just released SYSLINUX 2.09-pre4 with a few changes:
>
>a) SYSLINUX should now correctly handle mode changes from within a 
>COMBOOT program.
>
>b) Tweaks to the menu system to avoid the "grey text on black"
problem.
>
>c) A new color scheme for the menu system (Murali, check it out and see 
>if you think it works for you.)
>
>ftp://ftp.kernel.org/pub/linux/utils/boot/syslinux/Testing/
>
>Please test it out, everyone...
>
>	-hpa

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX at zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.

If you have two submenus nested within each other and then call a third menu
>it will bring up the second menu instead of the third.
>
>  MAIN = add_menu(" Main Menu ");
>  add_item("Begin Menu Depth Test","Only Allows Depth Of
>Two",OPT_SUBMENU,NULL,ONE);
>  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
>0);
>  
>
At this point ONE probably evaluates to 0. So you may pointing at a 
arbitrary submenu (depending on what value ONE has). Best way is to 
either define the menu's is reverse topological order, i.e. declare the 
menu's which does not have any submenu's first... and work your way up 
the (menu dependency tree). That way, you would already have declared 
the TWO menu before the MAIN menu. This will ensure that TWO gets a 
correct value. Otherwise, you can always hard code a number instead of 
the symbolic ONE, i.e. replace ONE with 1/2 or whatever. The advantage 
of the first is that you can never define recursice menu's.

- Murali
>  ONE = add_menu(" LEVEL 1 ");
>  add_item("GOTO LEVEL 2","Go one level
up",OPT_SUBMENU,NULL,TWO);
>  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
>0);
>
>  TWO = add_menu(" LEVEL 2 ");
>  add_item("GOTO LEVEL 3","Go one level
up",OPT_SUBMENU,NULL,TWO);
>  add_item("Exit to prompt", "Exit the menu system",
OPT_EXITMENU, "exit",
>0);
>  [snip]
>
>End result of selecting goto LEVEL 2 is that it brings up a new submenu
>containing LEVEL 1 instead of LEVEL2.
>
> 
>  
>
>>I have just released SYSLINUX 2.09-pre4 with a few changes:
>>
>>a) SYSLINUX should now correctly handle mode changes from within a 
>>COMBOOT program.
>>
>>b) Tweaks to the menu system to avoid the "grey text on black"
problem.
>>
>>c) A new color scheme for the menu system (Murali, check it out and see 
>>if you think it works for you.)
>>
>>ftp://ftp.kernel.org/pub/linux/utils/boot/syslinux/Testing/
>>
>>Please test it out, everyone...
>>
>>	-hpa
>>    
>>
>
>
>_______________________________________________
>SYSLINUX mailing list
>Submissions to SYSLINUX at zytor.com
>Unsubscribe or set options at:
>http://www.zytor.com/mailman/listinfo/syslinux
>Please do not send private replies to mailing list traffic.
>
>
>  
>