Swfdec - Feb 2012 - [Bug 45794] New: Type error in swfmoz_player_loaders_update

https://bugs.freedesktop.org/show_bug.cgi?id=45794

             Bug #: 45794
           Summary: Type error in swfmoz_player_loaders_update
    Classification: Unclassified
           Product: swfdec
           Version: unspecified
          Platform: SPARC
        OS/Version: NetBSD
            Status: NEW
          Severity: normal
          Priority: medium
         Component: plugin
        AssignedTo: swfdec at lists.freedesktop.org
        ReportedBy: martin at NetBSD.org
         QAContact: swfdec at lists.freedesktop.org


The variable "error" is declared as gboolean, but then assigned via a
call to
g_object_get() on the "error" property. However, that property is a
string (the
error message) or NULL if no error. Since g_object_get() is a variadic
function, the compiler will not catch this.

On alignement critical architectures the pointer assignement to &error may
cause a crash. On others, still some part of the stack may be overwritten.

Fix is simple: declare 

  gpointer error = NULL;

and change the test from

  if (error == TRUE)

to

  if (error != NULL)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=45794

--- Comment #1 from Martin Husemann <martin at NetBSD.org> 2012-02-13
02:55:54 PST ---
The same bug can be found in swfmoz_dialog.c:swfmoz_dialog_save_media

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=45794

--- Comment #2 from Martin Husemann <martin at NetBSD.org> 2012-02-13
03:40:13 PST ---
Created attachment 56957
  --> https://bugs.freedesktop.org/attachment.cgi?id=56957
patch we use in pkgsrc to fix the first instance

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=45794

--- Comment #3 from Martin Husemann <martin at NetBSD.org> 2012-02-13
03:40:54 PST ---
Created attachment 56958
  --> https://bugs.freedesktop.org/attachment.cgi?id=56958
pkgsrc patch for second instance

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.