bugzilla-daemon at freedesktop.org
2009-Jul-16 20:41 UTC
[Swfdec] [Bug 22803] New: 0.9.2 swfdec_as_object_add_variable prototype mismatch between .h & .c
http://bugs.freedesktop.org/show_bug.cgi?id=22803 Summary: 0.9.2 swfdec_as_object_add_variable prototype mismatch between .h & .c Product: swfdec Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: medium Component: library AssignedTo: swfdec at lists.freedesktop.org ReportedBy: enchanter at users.sourceforge.net QAContact: swfdec at lists.freedesktop.org In swfdec-0.9.2, the prototype for swfdec_as_object_add_variable in swfdec/swfdec_as_object.h is void swfdec_as_object_add_variable (SwfdecAsObject * object, const char * variable, SwfdecAsFunction * get, SwfdecAsFunction * set, SwfdecAsVariableFlag default_flags); However, in the definition in swfdec_as_object.c, it's void swfdec_as_object_add_variable (SwfdecAsObject *object, const char *variable, SwfdecAsFunction *get, SwfdecAsFunction *set, guint default_flags) The last parameter differs. The Solaris Workshop compiler complains about this and it certainly seems like it's a bug. I've modified the definition to match the declaration from the header file. Trivial patch is attached. (BTW, it might be nice if there were version options available in bugzilla for 0.9, I had to use unspecified). Thanks, Tim -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug.
bugzilla-daemon at freedesktop.org
2009-Jul-16 20:42 UTC
[Swfdec] [Bug 22803] 0.9.2 swfdec_as_object_add_variable prototype mismatch between .h & .c
http://bugs.freedesktop.org/show_bug.cgi?id=22803 --- Comment #1 from Tim Mooney <enchanter at users.sourceforge.net> 2009-07-16 13:42:43 PST --- Created an attachment (id=27776) --> (http://bugs.freedesktop.org/attachment.cgi?id=27776) modify the definition to match the prototype in the header file -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug.
bugzilla-daemon at freedesktop.org
2009-Jul-17 19:01 UTC
[Swfdec] [Bug 22803] 0.9.2 swfdec_as_object_add_variable prototype mismatch between .h & .c
http://bugs.freedesktop.org/show_bug.cgi?id=22803 Benjamin Otte <otte at gnome.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Benjamin Otte <otte at gnome.org> 2009-07-17 12:01:08 PST --- Thanks, applied to git master. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug.