I've been looking at packaging swfdec on my Fedora 6 system. Unfortunately since a git source checkout compiles with -Werror I've been having problems because of all of the unused parameter warnings. I've developed some patches that eliminate the problem by marking all of the unused parameters with __attribute__ ((unused)). The attribute markings are all macroized so if you aren't using GCC to compile the macro is just a no-op. There's also a warning of a deprecated function generated by the ffmpeg, I've included a patch for that too. Note that these patches compile, but haven't been tested. swfdec_marshal.c generates unused parameter warnings but since it's generated code I can't fix it with a patch to swfdec. I'll probably start out by substituting a manually patched copy during my local build until I can work with the upstream author of the tool that generates the code to fix the problem there. It might take me a while to get to the point where I can do some testing since I only have a limited time each day to work on this. Anyway, I've put up a git repository with my changes here: http://git.ocjtech.us/?p=swfdec;a=summary I'm a bit of a git newbie so I may have done something not quite right in setting up this repository. Jeff -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.freedesktop.org/archives/swfdec/attachments/20070322/df8c851c/attachment.pgp
On Thu, Mar 22, 2007 at 12:43:15PM -0500, Jeffrey C. Ollie wrote:> I've been looking at packaging swfdec on my Fedora 6 system. > Unfortunately since a git source checkout compiles with -Werror I've > been having problems because of all of the unused parameter warnings.Are you adding -W to your CFLAGS? Unused parameter warnings aren't part of -Wall because the warning kinda dumb. I personally would prefer to use -Wno-unused-parameter rather than add warning supression everywhere. dave...
After discussing my patches[1] a bit with Benjamin Otte on IRC, I've updated my patches to use the GLib G_GNUC_UNUSED macro rather than my custom one. I've also made similar changes to swfdec-mozilla[2]. One small difficulty that remains with the patches is with the swfdec_marshal.c code. Since this code is generated by glib-genmarshal you'll have to manually patch the generated code if you are building with -Wall & -Werror. The problem has been reported upstream[3] but no fixes have made it into the code. I've updated ffmpeg patch related to avcodec_audio_decode & avcodec_audio_decode2. The code should now detect the availability of avcodec_audio_decode2 and use in in preference to avcodec_audio_decode but will fall back to the older function if necessary. [1] http://git.ocjtech.us/?p=swfdec;a=summary [2] http://git.ocjtech.us/?p=swfdec-mozilla;a=summary [3] http://bugzilla.gnome.org/show_bug.cgi?id=357510 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.freedesktop.org/archives/swfdec/attachments/20070323/9a261cf0/attachment.pgp