Hello,
I''ve just started using sup and I''m really loving it.
Thanks for the great software.
I have a problem with extra-contact-addresses hook and lbdb.
Using the hook in the wiki:
contacts = []
`lbdbq |awk -F"\t" ''{print $2 ,
"<"$1">"}''`.each { |c| contacts.push(c) }
return contacts
I get error running hook and here''s the message that appears in the
log:
[Sun Sep 20 23:50:17 +0300 2009] hook: error running hook: unexpected return
[Sun Sep 20 23:50:17 +0300 2009] hook:
/home/alip/.sup/hooks/extra-contact-addresses.rb:7:in `__run''
/home/alip/src/sup/lib/sup/hook.rb:42:in `__run''
/home/alip/src/sup/lib/sup/hook.rb:82:in `run''
/home/alip/src/sup/lib/sup/util.rb:520:in `send''
/home/alip/src/sup/lib/sup/util.rb:520:in `method_missing''
/home/alip/src/sup/lib/sup/buffer.rb:540:in `ask_for_contacts''
/home/alip/src/sup/lib/sup/util.rb:520:in `send''
/home/alip/src/sup/lib/sup/util.rb:520:in `method_missing''
/home/alip/src/sup/lib/sup/modes/compose-mode.rb:24:in `spawn_nicely''
/home/alip/src/sup/bin/sup:282
This is with current master 68bf6a277c5fdefb3b9d6a4b5d4dfbce3f9f9ccf
--
Regards,
Ali Polatel
Ali Polatel yazm??:> Hello, > I''ve just started using sup and I''m really loving it. > Thanks for the great software. > > I have a problem with extra-contact-addresses hook and lbdb. > Using the hook in the wiki: > contacts = [] > `lbdbq |awk -F"\t" ''{print $2 , "<"$1">"}''`.each { |c| contacts.push(c) } > return contactsAnswering myself, removing return from the last line works as expected! I''ll see if I can edit the wiki. -- Regards, Ali Polatel
Reformatted excerpts from Ali Polatel''s message of 2009-09-20:> Answering myself, removing return from the last line works as > expected! I''ll see if I can edit the wiki.Yep, that was the problem. Hooks shouldn''t call return. Nice work. :) -- William <wmorgan-sup at masanjin.net>
Excerpts from Ali Polatel''s message of Sun Sep 20 17:11:04 -0600 2009:> Ali Polatel yazm??: > > Hello, > > I''ve just started using sup and I''m really loving it. > > Thanks for the great software. > > > > I have a problem with extra-contact-addresses hook and lbdb. > > Using the hook in the wiki: > > contacts = [] > > `lbdbq |awk -F"\t" ''{print $2 , "<"$1">"}''`.each { |c| contacts.push(c) } > > return contacts > > Answering myself, removing return from the last line works as expected! > I''ll see if I can edit the wiki. >By the way, I recently used this hook as well and found it really slow so I rewrote it to parse the lbdb by hand instead of calling out to lbdb. For me, it went from 1.5s to 0.03s. I edited the wiki as well. Here''s the hook: file = File.open( ENV[''HOME''] + "/.lbdb/m_inmail.list", "r" ) contacts = [] while file.gets email,name = split("\t") contacts << "#{name} <#{email}>" end file.close contacts John
Excerpts from John Bent''s message of 2010-03-11 22:09:04 +0100:> Excerpts from Ali Polatel''s message of Sun Sep 20 17:11:04 -0600 2009: > > Ali Polatel yazm??: > > > Hello, > > > I''ve just started using sup and I''m really loving it. > > > Thanks for the great software. > > > > > > I have a problem with extra-contact-addresses hook and lbdb. > > > Using the hook in the wiki: > > > contacts = [] > > > `lbdbq |awk -F"\t" ''{print $2 , "<"$1">"}''`.each { |c| contacts.push(c) } > > > return contacts > > > > Answering myself, removing return from the last line works as expected! > > I''ll see if I can edit the wiki. > > > By the way, I recently used this hook as well and found it really slow > so I rewrote it to parse the lbdb by hand instead of calling out to > lbdb. For me, it went from 1.5s to 0.03s. I edited the wiki as well. > Here''s the hook: > > file = File.open( ENV[''HOME''] + "/.lbdb/m_inmail.list", "r" ) > contacts = [] > while file.gets > email,name = split("\t") > contacts << "#{name} <#{email}>" > end > file.close > contactsThis doesn''t do the same thou as far as I can see, your hook only uses the addresses returned by the module using m_inmail.list; the former one uses all configured modules. - gaute -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20100312/076b32c9/attachment.bin>