sup talk - Sep 2009 - Fixing header for encrypted messages (might be an old issue)

Hi!

I''ve been having problems with encrypting messages. No idea where this
came from, but somehow the protocol part in encrypted messages had an
extra pair of quotes, e.g.:
protocol=""application/pgp-encrypted""
which caused it to not be recognized by some clients (e.g. mutt as far as I
know).

Here''s a simple fix. I have no idea, why this suddenly came up. Might
be that it had been like this all the time, just no one had a problem
with it? (I highly doubt that though!)  

If this is an old issue and I''m just using an old version, feel free
to ignore this. I''ve tried using the current master or next branch,
but that causes a crash when trying to open encrypted emails. Maybe
someone else is having a similar problem?

Greetings,
Christopher.
-- 
===============================Christopher Bertels
http://www.adztec-independent.de
GPG Key ID: 0x2345b203
-------------- next part --------------
A non-text attachment was scrubbed...
Name: protocol-fix.patch
Type: application/octet-stream
Size: 509 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/sup-talk/attachments/20090915/462fe7d5/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/sup-talk/attachments/20090915/462fe7d5/attachment.bin>

+ Christopher Bertels (Tue, 15 Sep 2009 22:21:59 +0200):
> Hi!
Hello!
> I''ve been having problems with encrypting messages. No idea where
this
> came from, but somehow the protocol part in encrypted messages had an
> extra pair of quotes, e.g.:
protocol=""application/pgp-encrypted""
> which caused it to not be recognized by some clients (e.g. mutt as far as I
know).
> Here''s a simple fix. I have no idea, why this suddenly came up.
Might
> be that it had been like this all the time, just no one had a problem
> with it? (I highly doubt that though!)  
It''s been like that all the time, but AFAIK only Mutt has problem
opening those messages. FWIW, it''s a bug in RMail (another one to add
to
the pile...):

   
http://rubyforge.org/tracker/index.php?func=detail&aid=2170&group_id=446&atid=1754
   
http://rubyforge.org/tracker/index.php?func=detail&aid=2661&group_id=446&atid=1756

I advice against using your patch, since it depends on broken behavior
of RMail to produce correct results, and people may be using fixed
versions of the library. For example, I uploaded fixed packages of RMail
to Debian, and they''ll become available in Ubuntu at some point.

Instead, you can find a patch to fix the issue in your system''s RMail
in
one bugs linked above.
> If this is an old issue and I''m just using an old version, feel
free
> to ignore this. I''ve tried using the current master or next
branch,
> but that causes a crash when trying to open encrypted emails. Maybe
> someone else is having a similar problem?
No, I''ve recently started experiencing this as well, asuming
you''re
talking about:

--- NoMethodError from thread: load messages for thread-view-mode
undefined method `expandable?'' for #<Array:0x7faa50e2d978>
/home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:615:in
`regen_text''
/home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`each''
/home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`regen_text''
/home/dato/devel/sup/work/lib/sup/thread.rb:68:in `each''
/home/dato/devel/sup/work/lib/sup/thread.rb:170:in `each_with_stuff''
[...]

Cheers,

-- 
- Are you sure we''re good?
- Always.
        -- Rory and Lorelai

Excerpts from Adeodato Sim?''s message of Mi Sep 16 00:21:19 +0200
2009:
> It''s been like that all the time, but AFAIK only Mutt has problem
> opening those messages. FWIW, it''s a bug in RMail (another one to
add to
> the pile...):
Alright, good to know.
> I advice against using your patch, since it depends on broken behavior
> of RMail to produce correct results, and people may be using fixed
> versions of the library. For example, I uploaded fixed packages of RMail
> to Debian, and they''ll become available in Ubuntu at some point.
> 
> Instead, you can find a patch to fix the issue in your system''s
RMail in
> one bugs linked above.
Alright, thanks. I''ll just leave it for me like this until
I''ve got a
new version of RMail then.
> > If this is an old issue and I''m just using an old version,
feel free
> > to ignore this. I''ve tried using the current master or next
branch,
> > but that causes a crash when trying to open encrypted emails. Maybe
> > someone else is having a similar problem?
> 
> No, I''ve recently started experiencing this as well, asuming
you''re
> talking about:
> 
> --- NoMethodError from thread: load messages for thread-view-mode
> undefined method `expandable?'' for #<Array:0x7faa50e2d978>
> /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:615:in
`regen_text''
> /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`each''
> /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`regen_text''
> /home/dato/devel/sup/work/lib/sup/thread.rb:68:in `each''
> /home/dato/devel/sup/work/lib/sup/thread.rb:170:in
`each_with_stuff''
> [...]
Yes, it''s the same error I get. Any insights as to what is causing
this?

Cheers,
Christopher.
-- 
===============================Christopher Bertels
http://www.adztec-independent.de
GPG Key ID: 0x2345b203
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/sup-talk/attachments/20090916/7f6fbfa9/attachment.bin>

Reformatted excerpts from Christopher Bertels''s message of
2009-09-15:
> Excerpts from Adeodato Sim?''s message of Mi Sep 16 00:21:19 +0200
2009:
> > --- NoMethodError from thread: load messages for thread-view-mode
> > undefined method `expandable?'' for
#<Array:0x7faa50e2d978>
> > /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:615:in
`regen_text''
> > /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`each''
> > /home/dato/devel/sup/work/lib/sup/modes/thread-view-mode.rb:610:in
`regen_text''
> > /home/dato/devel/sup/work/lib/sup/thread.rb:68:in `each''
> > /home/dato/devel/sup/work/lib/sup/thread.rb:170:in
`each_with_stuff''
> > [...]
> 
> Yes, it''s the same error I get. Any insights as to what is causing
this?
Just to confirm---both of you are seeing this error, with a recent git
master, when opening encrypted messages?
-- 
William <wmorgan-sup at masanjin.net>

Reformatted excerpts from William Morgan''s message of
2009-09-26:
> Just to confirm---both of you are seeing this error, with a recent git
> master, when opening encrypted messages?
Ah, looks like Michael Stapelberg''s patch will fix this.
-- 
William <wmorgan-sup at masanjin.net>

+ William Morgan (Sat, 26 Sep 2009 07:49:41 -0700):
> Reformatted excerpts from William Morgan''s message of 2009-09-26:
> > Just to confirm---both of you are seeing this error, with a recent git
> > master, when opening encrypted messages?
> Ah, looks like Michael Stapelberg''s patch will fix this.
I can confirm it works again on master (and next), thanks!

-- 
- Are you sure we''re good?
- Always.
        -- Rory and Lorelai