Hi - This patch cleans up my last IMAP patch, and adds the each_raw_message_line method to both Maildir and IMAP so that you dont get an exception when you try to save a message to a file with an IMAP or maildir source. I cant test the Maildir version works easily, so if someone else could that would be good. If I get time I''ll get around to testing the Maildir stuff, just not now as I dont use it :) This fixes the unread status problem to use the lack of /Seen properly and adds the marked_read? methods to all sources. Marcus -------------- next part -------------- A non-text attachment was scrubbed... Name: source-diffs Type: application/octet-stream Size: 4527 bytes Desc: not available Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071102/a3d8a87c/attachment-0001.obj
Hi Marcus, Excerpts from Marcus Williams''s message of Fri Nov 02 05:18:19 -0700 2007:> This patch cleans up my last IMAP patch, and adds the > each_raw_message_line method to both Maildir and IMAP so that you dont > get an exception when you try to save a message to a file with an IMAP > or maildir source.This all looks great, except for the source_marked_read stuff, which is only there as a nasty hack to avoid scanning mbox files twice (because you can''t tell if an mbox message is read or not until you go through all the headers). For non-mbox read/unread, it should be sufficient to simply set the flags as you do in IMAP#raw_header. If you get a chance, can you resubmit without that? I may have a chance to clean it up in the next few days if not. -- William <wmorgan-sup at masanjin.net>
On 5.11.2007, William Morgan wrote:> For non-mbox read/unread, it should be sufficient to simply set the flags > as you do in IMAP#raw_header. > > If you get a chance, can you resubmit without that? I may have a chance > to clean it up in the next few days if not.So do you want it removed completely or implemented differently?
Excerpts from Marcus Williams''s message of Mon Nov 05 01:54:17 -0800 2007:> On 5.11.2007, William Morgan wrote: > > For non-mbox read/unread, it should be sufficient to simply set the flags > > as you do in IMAP#raw_header. > > > > If you get a chance, can you resubmit without that? I may have a chance > > to clean it up in the next few days if not. > > So do you want it removed completely or implemented differently?Removed completely from the patch, as the resulting functionality should be exactly the same. If an IMAP message doesn''t have :unread, then it''s treated as read. There''s no reason to extend the horrible hackishness of source_marked_read anywhere beyond mbox. -- William <wmorgan-sup at masanjin.net>