Speex dev - Sep 2008 - Bug (and fix) for speex_jitter_buffer.c

Hi,

I'd like to report a bug in speexclient/speex_jitter_buffer.c.  In the
function speex_jitter_get(), after the line:

    packet.data = data;

add the line

    packet.len = 2048;


If this variable is uninitialized, then in jitter_buffer_get() (in
jitter.c), the predicate "jitter->packets[i].len >
packet->len" is
undetermined.  When this happens, the wrong amount of data is copied
from the jitter-buffer (eg: if (packet->len == 0), then no data is
copied).  For some reason, this didn't bite me on OS X, but when porting
to Windows, it consistently caused errors.

Now that I have it working, the jitter-buffer sounds great!  Thanks
again for Speex.

Cheers,
Josh

Joshua Gargus a ?crit :
> Hi,
> 
> I'd like to report a bug in speexclient/speex_jitter_buffer.c.  In the
> function speex_jitter_get(), after the line:
> 
>     packet.data = data;
> 
> add the line
> 
>     packet.len = 2048;
Thanks a lot for the bug report -- and the fix. I finally had a few
minutes to apply it.

Cheers,

	Jean-Marc

> 
> If this variable is uninitialized, then in jitter_buffer_get() (in
> jitter.c), the predicate "jitter->packets[i].len >
packet->len" is
> undetermined.  When this happens, the wrong amount of data is copied
> from the jitter-buffer (eg: if (packet->len == 0), then no data is
> copied).  For some reason, this didn't bite me on OS X, but when
porting
> to Windows, it consistently caused errors.
> 
> Now that I have it working, the jitter-buffer sounds great!  Thanks
> again for Speex.
> 
> Cheers,
> Josh
> _______________________________________________
> Speex-dev mailing list
> Speex-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/speex-dev
> 
>