Hi, A while ago I mentioned I was considering splitting libspeex into two parts. I'm attaching a patch that does exactly that, but I haven't applied it to svn because I first want to have some feedback. That patch leaves the codec in libspeex and moves the other stuff (jitter buffer, AEC, preprocessor, ...) to libspeexvoip (I'm open to suggestions on better names). Some of the things I had to do to be able to split are: - Remove the vorbis-psy tuning because I no longer have an fft in the codec - Remove the Speex-specific jitter buffer (but kept the generic one) because it was the only part of libspeexvoip requiring the codec. - The content of misc.c and math_approx.c was moved to the header files as inline functions (misc.c and math_approx.c no longer exist). Any comments, suggestions? Does that break anything I hadn't thought about? Any reason it shouldn't be done? ... Cheers, Jean-Marc -------------- next part -------------- A non-text attachment was scrubbed... Name: libsplit3.patch Type: text/x-patch Size: 24805 bytes Desc: not available Url : http://lists.xiph.org/pipermail/speex-dev/attachments/20070918/f3faf635/libsplit3.bin
Hi, Can you please confirm/give any sample on the "tick" value to be passed to jitter_buffer_init ( int tick ) ? Is this: Tick = GetTickCount() ? Thanks -----Original Message----- From: speex-dev-bounces@xiph.org [mailto:speex-dev-bounces@xiph.org] On Behalf Of Jean-Marc Valin Sent: Monday, September 17, 2007 4:29 PM To: speex-dev Subject: [Speex-dev] Libspeex splitting attempt Hi, A while ago I mentioned I was considering splitting libspeex into two parts. I'm attaching a patch that does exactly that, but I haven't applied it to svn because I first want to have some feedback. That patch leaves the codec in libspeex and moves the other stuff (jitter buffer, AEC, preprocessor, ...) to libspeexvoip (I'm open to suggestions on better names). Some of the things I had to do to be able to split are: - Remove the vorbis-psy tuning because I no longer have an fft in the codec - Remove the Speex-specific jitter buffer (but kept the generic one) because it was the only part of libspeexvoip requiring the codec. - The content of misc.c and math_approx.c was moved to the header files as inline functions (misc.c and math_approx.c no longer exist). Any comments, suggestions? Does that break anything I hadn't thought about? Any reason it shouldn't be done? ... Cheers, Jean-Marc
this is actually interesting if nothing else it does make speex more modular.
and would be a boon to voip developers who may not necessarily want to use the
codec but require the other features: denoiser, echo canceller and jitter
buffer.
-----Original Message-----From: speex-dev-bounces@xiph.org
[mailto:speex-dev-bounces@xiph.org] On
Behalf Of Jean-Marc Valin
Sent: Monday, September 17, 2007 4:29 PM
To: speex-dev
Subject: [Speex-dev] Libspeex splitting attempt
Hi,
A while ago I mentioned I was considering splitting libspeex into two
parts. I'm attaching a patch that does exactly that, but I haven't
applied it to svn because I first want to have some feedback. That patch
leaves the codec in libspeex and moves the other stuff (jitter buffer,
AEC, preprocessor, ...) to libspeexvoip (I'm open to suggestions on
better names).
Some of the things I had to do to be able to split are:
- Remove the vorbis-psy tuning because I no longer have an fft in the
codec
- Remove the Speex-specific jitter buffer (but kept the generic one)
because it was the only part of libspeexvoip requiring the codec.
- The content of misc.c and math_approx.c was moved to the header files
as inline functions (misc.c and math_approx.c no longer exist).
Any comments, suggestions? Does that break anything I hadn't thought
about? Any reason it shouldn't be done? ...
Cheers,
Jean-Marc
_______________________________________________
Speex-dev mailing list
Speex-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/speex-dev
----------------no sig
---------------------------------
Building a website is a piece of cake.
Yahoo! Small Business gives you all the tools to get online.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/speex-dev/attachments/20070920/71eac451/attachment.htm
I strongly suggest you look at how the speex_jitter_* calls are implemented. Sorry for now having more doc at the moment. Jean-Marc Bach Le wrote:> Hi, > Can you please confirm/give any sample on the "tick" value to be passed > to jitter_buffer_init ( int tick ) ? > Is this: Tick = GetTickCount() ? > > Thanks > > -----Original Message----- > From: speex-dev-bounces@xiph.org [mailto:speex-dev-bounces@xiph.org] On > Behalf Of Jean-Marc Valin > Sent: Monday, September 17, 2007 4:29 PM > To: speex-dev > Subject: [Speex-dev] Libspeex splitting attempt > > Hi, > > A while ago I mentioned I was considering splitting libspeex into two > parts. I'm attaching a patch that does exactly that, but I haven't > applied it to svn because I first want to have some feedback. That patch > leaves the codec in libspeex and moves the other stuff (jitter buffer, > AEC, preprocessor, ...) to libspeexvoip (I'm open to suggestions on > better names). > > Some of the things I had to do to be able to split are: > - Remove the vorbis-psy tuning because I no longer have an fft in the > codec > - Remove the Speex-specific jitter buffer (but kept the generic one) > because it was the only part of libspeexvoip requiring the codec. > - The content of misc.c and math_approx.c was moved to the header files > as inline functions (misc.c and math_approx.c no longer exist). > > Any comments, suggestions? Does that break anything I hadn't thought > about? Any reason it shouldn't be done? ... > > Cheers, > > Jean-Marc > >