Current SVN compilation fails on Win32 (Intel C++ compiler 9.0): ..\..\libspeex\mdf.c(317): error: declaration may not appear after executable statement in block float adapt_rate; Just moved it up to the variable declaration block to solve it locally, but as it's not valid C, I thought I'd mention it ;) PS: With the same compiler, AGC fails horribly (Zlast goes to several million). Not quite sure where to begin with debugging, and the problem is "solved" by switching to the MSVC compiler, but that compiler doesn't produce as fast code.
Thorvald Natvig wrote:> > Current SVN compilation fails on Win32 (Intel C++ compiler 9.0): > > ..\..\libspeex\mdf.c(317): error: declaration may not appear after > executable statement in block > float adapt_rate; > > Just moved it up to the variable declaration block to solve it > locally, but as it's not valid C, I thought I'd mention it ;)Where have you been the past 6 years? It is valid C99 (even if it's confusing for non-C++-minded people). here's an old article from 2001 about it: http://www.kuro5hin.org/story/2001/2/23/194544/139 -SteveK> > PS: With the same compiler, AGC fails horribly (Zlast goes to several > million). Not quite sure where to begin with debugging, and the > problem is "solved" by switching to the MSVC compiler, but that > compiler doesn't produce as fast code. > _______________________________________________ > Speex-dev mailing list > Speex-dev@xiph.org > http://lists.xiph.org/mailman/listinfo/speex-dev >
>> Current SVN compilation fails on Win32 (Intel C++ compiler 9.0): >> >> ..\..\libspeex\mdf.c(317): error: declaration may not appear after >> executable statement in block >> float adapt_rate; >> >> Just moved it up to the variable declaration block to solve it locally, but >> as it's not valid C, I thought I'd mention it ;) > > Where have you been the past 6 years? It is valid C99 (even if it's confusing > for non-C++-minded people)."restict" is also valid C99, but as that was removed for compatibility with non-compliant compilers, I thought one might wish to fix this as well, especially as it's the only place in the code it is used.
Not that this is a huge deal to fix, but the patch I just submitted also fixes this the same way. Forgot to mention that... Tom At 03:05 PM 11/4/2005, Thorvald Natvig wrote:>..\..\libspeex\mdf.c(317): error: declaration may not appear after >executable statement in block > float adapt_rate; > >Just moved it up to the variable declaration block to solve it locally,______________________________________________ Tom Harper Lead Software Engineer SightSpeed - <http://www.sightspeed.com/>http://www.sightspeed.com/ 918 Parker St, Suite A14 Berkeley, CA 94710 Email: tharper@sightspeed.com Phone: 510-665-2920 Fax: 510-649-9569 My SightSpeed Video Link: http://tom.sightspeed.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/speex-dev/attachments/20051104/3cb83544/attachment.html