similar to: [RFC][PATCH] Allow privcmd to support the _compat hypercalls

put_user() may fail. In this case propagate error code from privcmd_ioctl_mmap_batch(). Signed-off-by: Vasiliy Kulikov <segooon at gmail.com> --- Compile tested. drivers/xen/xenfs/privcmd.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c index f80be7f..2eb04c8 100644 ---

put_user() may fail. In this case propagate error code from privcmd_ioctl_mmap_batch(). Signed-off-by: Vasiliy Kulikov <segooon at gmail.com> --- Compile tested. drivers/xen/xenfs/privcmd.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xenfs/privcmd.c b/drivers/xen/xenfs/privcmd.c index f80be7f..2eb04c8 100644 ---

When we use this pointer, we cast away the const modifier and modify the data. I think it was an accident to declare it as const. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/include/xen/privcmd.h b/include/xen/privcmd.h index a853168..58ed953 100644 --- a/include/xen/privcmd.h +++ b/include/xen/privcmd.h @@ -69,7 +69,7 @@ struct privcmd_mmapbatch_v2 {

When we use this pointer, we cast away the const modifier and modify the data. I think it was an accident to declare it as const. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/include/xen/privcmd.h b/include/xen/privcmd.h index a853168..58ed953 100644 --- a/include/xen/privcmd.h +++ b/include/xen/privcmd.h @@ -69,7 +69,7 @@ struct privcmd_mmapbatch_v2 {

If m.num is too large then the "m.num * sizeof(*m.arr)" multiplication could overflow and the access_ok() check wouldn't test the right size. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- Only needed in linux-next. diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 215a3c0..fdff8f9 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c

If m.num is too large then the "m.num * sizeof(*m.arr)" multiplication could overflow and the access_ok() check wouldn't test the right size. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- Only needed in linux-next. diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 215a3c0..fdff8f9 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c

Hi all, In xen-4.1.2 source tree, under directory tools are there many library such lib*, what''s their individual feature? Besides, where is the log info for xl ? I try to trace using gdb after running xl, huge amounts of files\variable structure , complicated relationship between the components make me proceed slowly. Best regards

Any thoughts on setting breakpoints around hypercalls? ---------- Forwarded message ---------- From: Kip Macy <kip.macy@gmail.com> Date: Dec 26, 2005 12:14 AM Subject: setting breakpoints around hypercalls in a domU causes dom0 to lockup To: xen-devel <xen-devel@lists.xensource.com>, Keir Fraser < Keir.Fraser@cl.cam.ac.uk> Stepping through hypercalls (at the source level, not

This is a fourth cut of the hypervisor patch of the proposed XENMEM_claim_pages hypercall/subop, taking into account feedback from Jan and Keir and IanC, plus some fixes found via runtime debugging (using privcmd only) and some added comments/cleanup. [Logistical note: I will be out tomorrow (Friday) plus US holidays next week so my responsiveness to comments may be slower for awhile. --djm]

This is with last night''s Xen snapshot (apr 24th), on kernel 2.6.12-rc3 - but the mess is so horrid that I''m not quite sure how to fix it... This oops prevents xen from starting xenU domains. Basically xend does the following: 1) mmap /proc/xen/privcmd 2) call an ioctl to populate the mmap 3) munmap the mapping created in (1) During the munmap, the dom0 kernel oopses, as

On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > >> Rusty Russell <rusty at rustcorp.com.au> writes: > >> > >> > Anthony Liguori <aliguori at us.ibm.com> writes: > >> >> Forcing a

On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > >> Rusty Russell <rusty at rustcorp.com.au> writes: > >> > >> > Anthony Liguori <aliguori at us.ibm.com> writes: > >> >> Forcing a

On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > Rusty Russell <rusty at rustcorp.com.au> writes: > > > Anthony Liguori <aliguori at us.ibm.com> writes: > >> Forcing a guest driver change is a really big > >> deal and I see no reason to do that unless there's a compelling reason > >> to. > >> > >> So

On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > Rusty Russell <rusty at rustcorp.com.au> writes: > > > Anthony Liguori <aliguori at us.ibm.com> writes: > >> Forcing a guest driver change is a really big > >> deal and I see no reason to do that unless there's a compelling reason > >> to. > >> > >> So

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: >> Rusty Russell <rusty at rustcorp.com.au> writes: >> >> > Anthony Liguori <aliguori at us.ibm.com> writes: >> >> Forcing a guest driver change is a really big >> >> deal and I see no reason to do that

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: >> "Michael S. Tsirkin" <mst at redhat.com> writes: >> > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: >> >> Rusty Russell <rusty at rustcorp.com.au> writes: >> >> >> >> >

import include/asm-ia64/xen/interface.h to introduce introduce definitions necessary for ia64/xen hypercalls. They are basic structures to communicate with xen hypervisor and will be used later. Cc: Robin Holt <holt at sgi.com> Cc: Jeremy Fitzhardinge <jeremy at goop.org> Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp> Cc: "Luck, Tony" <tony.luck at

import include/asm-ia64/xen/interface.h to introduce introduce definitions necessary for ia64/xen hypercalls. They are basic structures to communicate with xen hypervisor and will be used later. Cc: Robin Holt <holt at sgi.com> Cc: Jeremy Fitzhardinge <jeremy at goop.org> Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp> Cc: "Luck, Tony" <tony.luck at

Rusty Russell <rusty at rustcorp.com.au> writes: > Anthony Liguori <aliguori at us.ibm.com> writes: >> "Michael S. Tsirkin" <mst at redhat.com> writes: >>> + case offsetof(struct virtio_pci_common_cfg, device_feature_select): >>> + return proxy->device_feature_select; >> >> Oh dear no... Please use defines like the

On Tue, Jun 04, 2013 at 03:01:50PM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Mon, Jun 03, 2013 at 09:56:15AM +0930, Rusty Russell wrote: > >> "Michael S. Tsirkin" <mst at redhat.com> writes: > >> > On Thu, May 30, 2013 at 08:53:45AM -0500, Anthony Liguori wrote: > >> >> Rusty