similar to: [Bridge] STP on hardware switch

Hi, I'm trying to modify the stp kernel files in order to implements the RSTP. I've already modify the bpdu format like this : ------------------------------------------------------------------------------------------------------------------------------------ typedef struct { int topo_change = 0; int proposal = 0; int port_role[2] = {0,0} ; //role du port ?metteur du BPDU

I saw some big mistakes, here's the correct version : -------------------------------------------------------------------- void br_send_config_bpdu(struct net_bridge_port *p, struct bpdu *bpdu) { unsigned char buf[42]; buf[0] = bpdu->bpdu_header.protocol[0]; //0x00 buf[1] = bpdu->bpdu_header.protocol[1]; //0x00 buf[2] = bpdu->bpdu_header.version; //0x02 buf[3] =

This is a revised version of Kishore's patch to set message age appropriately in STP configuration packets. Signed-off-by: Kishore A K <KishoreAK@myw.ltindia.com> Signed-off-by: Stephen Hemminger <shemminger@osdl.org> diff -Nru a/net/bridge/br_stp.c b/net/bridge/br_stp.c --- a/net/bridge/br_stp.c 2004-06-29 14:45:50 -07:00 +++ b/net/bridge/br_stp.c 2004-06-29 14:45:50 -07:00 @@

This is the 2.4 version which incorporates the observations from Kishore about 2.6. The existing 2.4 code set the age properly, but did not increment correctly for HZ=1000 and could send a stale (expired) configuration. Signed-off-by: Stephen Hemminger <shemminger@osdl.org> diff -Nru a/net/bridge/br_stp.c b/net/bridge/br_stp.c --- a/net/bridge/br_stp.c 2004-06-29 15:30:32 -07:00 +++

I have noticed a change in the linux bridge implementation between 2.1.15 and 2.1.17. Specifically, I do not think BPDU's (generated from another bridge) are passed across the bridge when STP is disabled. I think this relates to the LLC handling of BPDU's directly invoking br_bpdu_rcv. In 2.6.15, the br_handle_frame function would pass a BPDU to the br_handle_frame_finish function

When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled. # unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge stp_state 1 # ip link set br0 up # sleep 30 # ip -s link show br0 2: br0:

Hi, I want to connect two pc`s on a redundant way with each other. On those pc`s a 64 bit ubuntu 11.10 is running with kernel version 3.0.0-16-generic. Setup1: ---------- PC1: PC2: br0 br1 | | -- eth0.1000 ---------------------------------------------------eth0.1000 | | __eth1.1001

On 12/07/2023 02:54, Kuniyuki Iwashima wrote: > When we create an L2 loop on a bridge in netns, we will see packets storm > even if STP is enabled. > > # unshare -n > # ip link add br0 type bridge > # ip link add veth0 type veth peer name veth1 > # ip link set veth0 master br0 up > # ip link set veth1 master br0 up > # ip link set br0 type bridge stp_state 1

On 12/07/2023 17:48, Ido Schimmel wrote: > On Tue, Jul 11, 2023 at 04:54:15PM -0700, Kuniyuki Iwashima wrote: >> When we create an L2 loop on a bridge in netns, we will see packets storm >> even if STP is enabled. >> >> # unshare -n >> # ip link add br0 type bridge >> # ip link add veth0 type veth peer name veth1 >> # ip link set veth0 master

Fixes message_age field update in config BPDUs. Also checks whether the BPDU message age has exceeded bridge max age before transmitting config BPDUs. Signed-off-by: Kishore A K <KishoreAK@myw.ltindia.com> Index: linux-2.6.7/net/bridge/br_stp.c ============================================================= --- linux-2.6.7/net/bridge/br_stp.c.orig 2004-06-17 20:17:27.000000000 +0530 +++

On Wed, 13 Sep 2006 15:58:49 -0700 Brian Braunstein <brian@bristyle.com> wrote: > hi stephen and tony, > > i have been in contact with both of you and i figured it would make > sense to get you to in contact on this issue, so here's the story: > > stephen is the maintainer of the linux spanning tree bridging code, an > implementation of 802.1D-1998 that has very

This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification. With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age. Tested

Hi, I tried to send the BDPU at less than 1 second in a STP implementation. When I look at STP info with brctl in tells me that the bpdu are send under the second but in fact it's "only" every second. Is it because we can't send BPDU less than 1 second or something else ? Thanks for your response HENRY Simon ------------------------------------------ Faites un voeu et

Hi. I'm not subscribed, so please Cc: me. This trivial patch fixes a typo that irritates me every time I boot.. --- linux-2.5.orig/net/bridge/br_stp.c 2004-07-19 14:43:44.000000000 +0300 +++ linux-2.5/net/bridge/br_stp.c 2004-07-19 14:53:15.000000000 +0300 @@ -299,7 +299,7 @@ int isroot = br_is_root_bridge(br); pr_info("%s: topology change detected, %s\n",

I have two multi-port bridges connected together with a lot of cables. Current setup is as follows: --------eth0------- | | [Bridge A] <-eth1-> [Bridge B] | | --------eth5------- Bridge A is root-bridge, and eth0 is set to lowest path-cost. Consequently on Bridge B interfaces eth1 and eth5 are in blocking state. However, when looking

I think that it may be appropriate to submit this patch for linux-next instead of 3.15-rc4... On Thu, May 8, 2014 at 1:53 PM, Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de> wrote: > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Compile tested only, but I'd seriously wonder if this broke anything. > > Suggested-by: Dave

SET_ETHTOOL_OPS is equivalent to : #define SET_ETHTOOL_OPS(netdev,ops) \ ( (netdev)->ethtool_ops = (ops) ) how it makes difference removing this code and replacing with the code mentioned ? On Sun, May 11, 2014 at 5:42 AM, Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de> wrote: > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see

SET_ETHTOOL_OPS is equivalent to : #define SET_ETHTOOL_OPS(netdev,ops) \ ( (netdev)->ethtool_ops = (ops) ) how it makes difference removing this code and replacing with the code mentioned ? On Sun, May 11, 2014 at 5:42 AM, Wilfried Klaebe <w-lkml at lebenslange-mailadresse.de> wrote: > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see

The second part of my patch series to fix the handling of addr_assign_type for random MAC addresses. This contains the trival changes from random_ether_addr() to new eth_hw_addr_random() and code to reset the state to NET_ADDR_PERM as soon as the MAC get changed via .ndo_set_mac_address where eth_mac_addr wasn't used. Danny Kukawka (2): net: replace random_ether_addr() with

The second part of my patch series to fix the handling of addr_assign_type for random MAC addresses. This contains the trival changes from random_ether_addr() to new eth_hw_addr_random() and code to reset the state to NET_ADDR_PERM as soon as the MAC get changed via .ndo_set_mac_address where eth_mac_addr wasn't used. Danny Kukawka (2): net: replace random_ether_addr() with