similar to: [PATCH AUTOSEL 6.1 11/18] vsock: read from socket's error queue

From: Arseniy Krasnov <avkrasnov at salutedevices.com> [ Upstream commit 49dbe25adac42d3e06f65d1420946bec65896222 ] This adds handling of MSG_ERRQUEUE input flag in receive call. This flag is used to read socket's error queue instead of data queue. Possible scenario of error queue usage is receiving completions for transmission with MSG_ZEROCOPY flag. This patch also adds new defines:

From: Arseniy Krasnov <avkrasnov at salutedevices.com> [ Upstream commit 49dbe25adac42d3e06f65d1420946bec65896222 ] This adds handling of MSG_ERRQUEUE input flag in receive call. This flag is used to read socket's error queue instead of data queue. Possible scenario of error queue usage is receiving completions for transmission with MSG_ZEROCOPY flag. This patch also adds new defines:

On Mon, Feb 06, 2023 at 07:06:32AM +0000, Arseniy Krasnov wrote: >To use this option pass '--zc' parameter: --zerocopy or --zero-copy maybe better follow what we did with the other parameters :-) > >./vsock_perf --zc --sender <cid> --port <port> --bytes <bytes to send> > >With this option MSG_ZEROCOPY flag will be passed to the 'send()' call.

On Mon, Feb 06, 2023 at 06:54:51AM +0000, Arseniy Krasnov wrote: >This adds handling of MSG_ERRQUEUE input flag for receive call, thus >skb from socket's error queue is read. A general tip, add a little more description in the commit messages, especially to explain why these changes are necessary. Otherwise, even review becomes difficult because one has to look at all the patches to

On Sun, Sep 03, 2023 at 11:13:23AM +0300, Arseniy Krasnov wrote: > > >On 01.09.2023 15:30, Stefano Garzarella wrote: >> On Sun, Aug 27, 2023 at 11:54:36AM +0300, Arseniy Krasnov wrote: >>> This adds handling of MSG_ZEROCOPY flag on transmission path: if this >>> flag is set and zerocopy transmission is possible (enabled in socket >>> options and transport

On Mon, Feb 06, 2023 at 07:00:35AM +0000, Arseniy Krasnov wrote: >This adds main logic of MSG_ZEROCOPY flag processing for packet >creation. When this flag is set and user's iov iterator fits for >zerocopy transmission, call 'get_user_pages()' and add returned >pages to the newly created skb. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru>

On Sun, 2023-07-30 at 11:59 +0300, Arseniy Krasnov wrote: > This is preparation patch for MSG_ZEROCOPY support. It adds handling of > non-linear skbs by replacing direct calls of 'memcpy_to_msg()' with > 'skb_copy_datagram_iter()'. Main advantage of the second one is that it > can handle paged part of the skb by using 'kmap()' on each page, but if > there are

On Sat, Aug 26, 2023 at 08:58:59PM +0300, Arseniy Krasnov wrote: >POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. > >Signed-off-by: Arseniy Krasnov <avkrasnov at salutedevices.com> >--- > net/vmw_vsock/af_vsock.c

On Sat, Aug 26, 2023 at 08:59:00PM +0300, Arseniy Krasnov wrote: >This adds two tests for 'shutdown()' call. It checks that SIGPIPE is >sent when MSG_NOSIGNAL is not set and vice versa. Both flags SHUT_WR >and SHUT_RD are tested. > >Signed-off-by: Arseniy Krasnov <avkrasnov at salutedevices.com> >--- > tools/testing/vsock/vsock_test.c | 138

This header file now only includes the "uapi/linux/vm_sockets.h". We can include directly it when needed. Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 13 ------------- include/net/af_vsock.h | 2 +- include/net/vsock_addr.h | 2 +- net/vmw_vsock/vmci_transport_notify.h | 1 - 4 files

This header file now only includes the "uapi/linux/vm_sockets.h". We can include directly it when needed. Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 13 ------------- include/net/af_vsock.h | 2 +- include/net/vsock_addr.h | 2 +-

Split the vSockets header into kernel and UAPI parts. The former gets the bits that used to be in __KERNEL__ guards, while the latter gets everything that is user-visible. Tested by compiling vsock (+transport) and a simple user-mode vSockets application. Reported-by: David Howells <dhowells at redhat.com> Acked-by: Dmitry Torokhov <dtor at vmware.com> Signed-off-by: Andy King

Split the vSockets header into kernel and UAPI parts. The former gets the bits that used to be in __KERNEL__ guards, while the latter gets everything that is user-visible. Tested by compiling vsock (+transport) and a simple user-mode vSockets application. Reported-by: David Howells <dhowells at redhat.com> Acked-by: Dmitry Torokhov <dtor at vmware.com> Signed-off-by: Andy King

On Mon, Feb 06, 2023 at 06:57:16AM +0000, Arseniy Krasnov wrote: >This adds copying to guest's virtio buffers from non-linear skbs. Such >skbs are created by protocol layer when MSG_ZEROCOPY flags is used. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > drivers/vhost/vsock.c | 56 ++++++++++++++++++++++++++++++++---- >

vm_sockets_get_local_cid() is only used in virtio_transport_common.c. We can replace it calling the virtio_transport_get_ops() and using the get_local_cid() callback registered by the transport. Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 2 -- net/vmw_vsock/af_vsock.c | 10 ----------

vm_sockets_get_local_cid() is only used in virtio_transport_common.c. We can replace it calling the virtio_transport_get_ops() and using the get_local_cid() callback registered by the transport. Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- include/linux/vm_sockets.h | 2 -- net/vmw_vsock/af_vsock.c

> From: Stefano Garzarella [mailto:sgarzare at redhat.com] > Sent: Tuesday, November 19, 2019 12:01 PM > > The VMADDR_CID_RESERVED (1) was used by VMCI, but now it is not > used anymore, so we can reuse it for local communication > (loopback) adding the new well-know CID: VMADDR_CID_LOCAL. > > Cc: Jorgen Hansen <jhansen at vmware.com> > Signed-off-by: Stefano

Minor vSockets fixes, two of which were reported on LKML. Andy King (2): VSOCK: Remove hypervisor-only socket option VSOCK: Don't reject PF_VSOCK protocol Dmitry Torokhov (2): VSOCK: get rid of EXPORT_SYMTAB VSOCK: get rid of vsock_version.h include/uapi/linux/vm_sockets.h | 8 -------- net/vmw_vsock/af_vsock.c | 7 ++----- net/vmw_vsock/vmci_transport.c | 2 --

Minor vSockets fixes, two of which were reported on LKML. Andy King (2): VSOCK: Remove hypervisor-only socket option VSOCK: Don't reject PF_VSOCK protocol Dmitry Torokhov (2): VSOCK: get rid of EXPORT_SYMTAB VSOCK: get rid of vsock_version.h include/uapi/linux/vm_sockets.h | 8 -------- net/vmw_vsock/af_vsock.c | 7 ++----- net/vmw_vsock/vmci_transport.c | 2 --

vsock_(un)register_transport calls available, so it is possible to write a virtio transport module without having to patch vsock code to hook it up. Having the vsock bits in staging would actually make it a bit easier to add virtio. In the end it is Greg's / Dave's call though as those have to ack & merge the bits. >>> + case IOCTL_VMCI_SOCKETS_GET_LOCAL_CID: >>> +