similar to: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > On Tue, Jul 4, 2023 at 12:38?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jul 3, 2023 at 4:52?PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > On Mon, Jul

On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio P?rez wrote: > With the current code it is accepted as long as userland send it. > > Although userland should not set a feature flag that has not been > offered to it with VHOST_GET_BACKEND_FEATURES, the current code will not > complain for it. > > Since there is no specific reason for any parent to reject that backend >

On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote: > On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio P?rez wrote: >> Offer this backend feature as mlx5 is compatible with it. It allows it >> to do live migration with CVQ, dynamically switching between passthrough >> and shadow virtqueue. >> >> Signed-off-by: Eugenio P?rez <eperezma at redhat.com> > Same

On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio P?rez wrote: > Offer this backend feature as mlx5 is compatible with it. It allows it > to do live migration with CVQ, dynamically switching between passthrough > and shadow virtqueue. > > Signed-off-by: Eugenio P?rez <eperezma at redhat.com> Same comment. > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +++++++ > 1

The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: Linux 6.5 (2023-08-27 14:49:51 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 1acfe2c1225899eab5ab724c91b7e1eb2881b9ab: virtio_ring: fix avail_wrap_counter in virtqueue_add_packed (2023-09-03 18:10:24

The following changes since commit 2dde18cd1d8fac735875f2e4987f11817cc0bc2c: Linux 6.5 (2023-08-27 14:49:51 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to 1acfe2c1225899eab5ab724c91b7e1eb2881b9ab: virtio_ring: fix avail_wrap_counter in virtqueue_add_packed (2023-09-03 18:10:24

Userspace knows if the device has dedicated descriptor group or not by checking this feature bit. It's only exposed if the vdpa driver backend implements the .get_vq_desc_group() operation callback. Userspace trying to negotiate this feature when it or the dependent _F_IOTLB_ASID feature hasn't been exposed will result in an error. Signed-off-by: Si-Wei Liu <si-wei.liu at

? 2023/2/22 22:25, Eugenio Perez Martin ??: > On Wed, Feb 22, 2023 at 5:05 AM Jason Wang <jasowang at redhat.com> wrote: >> >> ? 2023/2/8 17:42, Eugenio P?rez ??: >>> Next patches enable devices to be migrated even if vdpa netdev has not >>> been started with x-svq. However, not all devices are migratable, so we >>> need to block migration if we

Hi, > The function vhost.c:vhost_dev_stop fetches the vring base so the vq > state can be migrated to other devices. However, this is unreliable in > vdpa, since we didn't signal the device to suspend the queues, making > the value fetched useless. > > Suspend the device if possible before fetching first and subsequent > vring bases. > > Moreover, vdpa totally

Hi Zhu, url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vhost-new-vhost_vdpa-SET-GET_BACKEND_FEATURES-handlers/20200909-115726 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: parisc-randconfig-m031-20200909 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by:

----- Original Message ----- > This commit introduced vhost_vdpa_set/get_backend_features() to > resolve these issues: > (1)In vhost_vdpa ioctl SET_BACKEND_FEATURES path, currect code > would try to acquire vhost dev mutex twice > (first shown in vhost_vdpa_unlocked_ioctl), which can lead > to a dead lock issue. > (2)SET_BACKEND_FEATURES was blindly added to vring ioctl

On Tue, Sep 08, 2020 at 09:00:19PM +0800, Zhu, Lingshan wrote: > > On 9/8/2020 8:05 PM, Michael S. Tsirkin wrote: > > On Mon, Sep 07, 2020 at 06:52:19PM +0800, Zhu Lingshan wrote: > > In vhost_vdpa ioctl SET_BACKEND_FEATURES path, currect code > would try to acquire vhost dev mutex twice > (first shown in vhost_vdpa_unlocked_ioctl), which can

On 8/21/20 3:50 PM, Nathan Chancellor wrote: > Clang warns several times when building for 32-bit ARM along the lines > of: > > drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width > of type [-Wshift-count-overflow] > ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); >

On Wed, Mar 15, 2023 at 3:28?PM Eli Cohen <elic at nvidia.com> wrote: > > Extend the possible list for features that can be supported by firmware. > Note that different versions of firmware may or may not support these > features. The driver is made aware of them by querying the firmware. > > While doing this, improve the code so we use enum names instead of hard > coded

On 3/20/2023 4:49 AM, Eli Cohen wrote: > Extend the possible list for features that can be supported by firmware. > Note that different versions of firmware may or may not support these > features. The driver is made aware of them by querying the firmware. > > While doing this, improve the code so we use enum names instead of hard > coded numerical values. > > The new

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

The nvif_object_ioctl() method NVIF_VMM_V0_PFNMAP wasn't correctly setting the hardware specific GPU page table entries for 2MB sized pages. Fix this by adding functions to set and clear PD0 GPU page table entries. Signed-off-by: Ralph Campbell <rcampbell at nvidia.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 5 +- .../drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 82

disable virtio 1.0 in transports that don't support it yet. We will gradually re-enable as support is added. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/lguest/lguest_device.c | 3 ++- drivers/misc/mic/card/mic_virtio.c | 2 ++ drivers/s390/kvm/virtio_ccw.c | 3 ++- drivers/virtio/virtio_mmio.c | 2 ++ 4 files changed, 8 insertions(+), 2

disable virtio 1.0 in transports that don't support it yet. We will gradually re-enable as support is added. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/lguest/lguest_device.c | 3 ++- drivers/misc/mic/card/mic_virtio.c | 2 ++ drivers/s390/kvm/virtio_ccw.c | 3 ++- drivers/virtio/virtio_mmio.c | 2 ++ 4 files changed, 8 insertions(+), 2