similar to: [PATCH 1/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default

On 3/13/2023 8:47 PM, Parav Pandit wrote: >> From: Michael S. Tsirkin <mst at redhat.com> >> Sent: Monday, March 13, 2023 11:38 PM >> >> On Tue, Mar 14, 2023 at 02:05:50AM +0000, Parav Pandit wrote: >>>> From: Si-Wei Liu <si-wei.liu at oracle.com> >>>> Sent: Monday, March 13, 2023 6:19 PM >>>> Actually there's no such

On Mon, Mar 13, 2023 at 09:14:38PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Sunday, March 12, 2023 12:24 PM > > > > On Sun, Mar 12, 2023 at 01:28:06PM +0000, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin <mst at redhat.com> > > > > Sent: Sunday,

On 3/12/2023 6:28 AM, Parav Pandit wrote: > >> From: Michael S. Tsirkin <mst at redhat.com> >> Sent: Sunday, March 12, 2023 6:25 AM >> >> On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: >>> On 12/03/2023 10:58, Michael S. Tsirkin wrote: >>>> On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: >>>>> One can still

On Sun, Mar 12, 2023 at 01:28:06PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Sunday, March 12, 2023 6:25 AM > > > > On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: > > > > > > On 12/03/2023 10:58, Michael S. Tsirkin wrote: > > > > On Sun, Mar 12, 2023 at 10:39:19AM +0200,

On Sun, Mar 12, 2023 at 11:10:25AM +0200, Eli Cohen wrote: > > On 12/03/2023 10:58, Michael S. Tsirkin wrote: > > On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > > > One can still enable it when creating the vdpa device using vdpa tool by > > > providing features that include it. > > > > > > For example: > > > $ vdpa dev add

On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > Signed-off-by: Eli Cohen <elic at nvidia.com> What's the reason to turn it off by default?

On Tue, Mar 21, 2023 at 01:28:08PM +0200, Eli Cohen wrote: > Following patch adds driver support for VIRTIO_NET_F_MRG_RXBUF. > > Current firmware versions show degradation in packet rate when using > MRG_RXBUF. Users who favor memory saving over packet rate could enable > this feature but we want to keep it off by default. > > One can still enable it when creating the vdpa

On 2020/7/20 ??3:14, Eli Cohen wrote: > Add a front end VDPA driver that registers in the VDPA bus and provides > networking to a guest. The VDPA driver creates the necessary resources > on the VF it is driving such that data path will be offloaded. > > Notifications are being communicated through the driver. > > Currently, only VFs are supported. In subsequent patches we will

On 2020/8/5 ??12:20, Eli Cohen wrote: > Add a front end VDPA driver that registers in the VDPA bus and provides > networking to a guest. The VDPA driver creates the necessary resources > on the VF it is driving such that data path will be offloaded. > > Notifications are being communicated through the driver. > > Currently, only VFs are supported. In subsequent patches we will

On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com> wrote: > > > > > From: Eli Cohen <elic at nvidia.com> > > Sent: Wednesday, March 15, 2023 3:28 AM > > > > Extend the possible list for features that can be supported by firmware. > > Note that different versions of firmware may or may not support these > > features. The

On Mon, Apr 03, 2023 at 01:00:16PM -0400, Parav Pandit wrote: > > > On 4/3/2023 12:20 PM, Eli Cohen wrote: > > Hi, > > > > the single patch in this series adds support for posted interrupts in > > mlx5. > > > > It depends on the patch series already accpted can be seen here: > >

On 2020/7/16 ??3:23, Eli Cohen wrote: > Add a front end VDPA driver that registers in the VDPA bus and provides > networking to a guest. The VDPA driver creates the necessary resources > on the VF it is driving such that data path will be offloaded. > > Notifications are being communicated through the driver. > > Currently, only VFs are supported. In subsequent patches we will

On Mon, Nov 02, 2020 at 05:07:59AM +0000, Parav Pandit wrote: > > > > From: Leon Romanovsky <leon at kernel.org> > > Sent: Monday, November 2, 2020 1:46 AM > > > > From: Leon Romanovsky <leonro at nvidia.com> > > > > Remove exposed driver version as it was done in other drivers, so module > > version will work correctly by displaying the

On 3/20/2023 4:49 AM, Eli Cohen wrote: > Extend the possible list for features that can be supported by firmware. > Note that different versions of firmware may or may not support these > features. The driver is made aware of them by querying the firmware. > > While doing this, improve the code so we use enum names instead of hard > coded numerical values. > > The new

On Wed, Mar 15, 2023 at 3:28?PM Eli Cohen <elic at nvidia.com> wrote: > > Extend the possible list for features that can be supported by firmware. > Note that different versions of firmware may or may not support these > features. The driver is made aware of them by querying the firmware. > > While doing this, improve the code so we use enum names instead of hard > coded

On 8/21/20 3:50 PM, Nathan Chancellor wrote: > Clang warns several times when building for 32-bit ARM along the lines > of: > > drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width > of type [-Wshift-count-overflow] > ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); >

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

Clang warns several times when building for 32-bit ARM along the lines of: drivers/vdpa/mlx5/net/mlx5_vnet.c:1462:31: warning: shift count >= width of type [-Wshift-count-overflow] ndev->mvdev.mlx_features |= BIT(VIRTIO_F_VERSION_1); ^~~~~~~~~~~~~~~~~~~~~~~ This is related to the BIT macro, which uses an unsigned long literal,

On 4/3/2023 12:20 PM, Eli Cohen wrote: > Hi, > > the single patch in this series adds support for posted interrupts in > mlx5. > > It depends on the patch series already accpted can be seen here: > https://patchwork.kernel.org/project/netdevbpf/patch/20230324231341.29808-1-saeed at kernel.org/ > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git

OK, some patches in the series add buggy code which is then fixed by follow-up patches, but none of the bugs fixed are severe regressions on common configs (e.g. compiler warnings, lockdep/rt errors, or bugs in new drivers). So I thought it's more important to preserve the credit for the fixes. I had to pull 5 patches from git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux mlx5-next