similar to: [PATCH net-next 0/2] Small packet processing handling changes

virtnet_rq_free_unused_buf() helper function to free the buffer already exists. Avoid code duplication by reusing existing function. Signed-off-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d45e140b6852..c1faaf11fbcd 100644 ---

On Fri, Jan 13, 2023 at 3:37 PM Parav Pandit <parav at nvidia.com> wrote: > > > > From: Alexander H Duyck <alexander.duyck at gmail.com> > > Sent: Friday, January 13, 2023 6:24 PM > > > > On Sat, 2023-01-14 at 00:36 +0200, Parav Pandit wrote: > > > A smallest Ethernet frame defined by IEEE 802.3 is 60 bytes without > > > any preemble and

Hi, This two small patches improves ndo_close() callback to follow the mirror sequence of ndo_open() callback. This improves the code auditing and also ensure that xdp rxq info is not unregistered while NAPI on RXQ is ongoing. Please review. Patch summary: patch-1 ensures that xdp rq info is unregistered after rq napi is disabled patch-2 keeps the mirror sequence for close() be mirror of open()

is_power_of_2() already performs the zero check. Hence avoid duplicate check. While at it, move the query of size check also adjacent to where its used for the disabled vq. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Gavin Li <gavinl at nvidia.com> Reviewed-by:

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Mon, Mar 13, 2023 at 09:14:38PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Sunday, March 12, 2023 12:24 PM > > > > On Sun, Mar 12, 2023 at 01:28:06PM +0000, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin <mst at redhat.com> > > > > Sent: Sunday,

This patch series performs a clean up of the code in virtio_ring and virtio_pci, modifying it to conform with the Linux kernel coding style guidance [1]. The modifications ensure the code easy to read and understand. This small series does few short cleanups in the code. Patch-1 Remove unnecessary num zero check, which performs in power_of_2. Patch-2 Avoid using inline for small functions.

When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwinding of init code. Also extract a helper function of disable queue pairs, and use newly introduced

Cited commit in fixes tag frees rxq xdp info while RQ NAPI is still enabled and packet processing may be ongoing. Follow the mirror sequence of open() in the stop() callback. This ensures that when rxq info is unregistered, no rx packet processing is ongoing. Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Parav Pandit <parav at nvidia.com> ---

On Tue, 5 Nov 2019 17:32:37 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Tue, 5 Nov 2019 17:32:37 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

This patch series performs a clean up of the code in virtio_ring and virtio_pci, modifying it to conform with the Linux kernel coding style guidance [1]. The modifications ensure the code easy to read and understand. This small series does few short cleanups in the code. Patch-1 Allow non power of 2 sizes for virtqueues Patch-2 Avoid using inline for small functions. Patch-3 Use const to annotate

On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang <jasowang at redhat.com> wrote: > Add support to parse mdev class id table. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > drivers/vfio/mdev/vfio_mdev.c | 2 ++ > scripts/mod/devicetable-offsets.c | 3 +++ > scripts/mod/file2alias.c

On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang <jasowang at redhat.com> wrote: > Add support to parse mdev class id table. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > drivers/vfio/mdev/vfio_mdev.c | 2 ++ > scripts/mod/devicetable-offsets.c | 3 +++ > scripts/mod/file2alias.c

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > Add const to make the read-only pointer parameters clear, similar to > many existing functions. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Reviewed-by: Parav Pandit <parav at nvidia.com> > Reviewed-by: Gavin Li <gavinl

On 2023-03-10 a.m.8:36, Parav Pandit wrote: > > >> From: Feng Liu <feliu at nvidia.com> >> Sent: Friday, March 10, 2023 12:34 AM > >> >> - if (!is_power_of_2(num)) { >> - dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", >> num); >> - return ERR_PTR(-EINVAL); >> - } >> - > > The check is still

On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com> wrote: > > > > > From: Eli Cohen <elic at nvidia.com> > > Sent: Wednesday, March 15, 2023 3:28 AM > > > > Extend the possible list for features that can be supported by firmware. > > Note that different versions of firmware may or may not support these > > features. The

On 2023-05-01 a.m.8:44, Simon Horman wrote: > External email: Use caution opening links or attachments > > > On Fri, Apr 28, 2023 at 06:43:46PM -0400, Feng Liu wrote: >> Use newly introduced helper function that exactly does the same of >> closing the queue pairs. >> >> Signed-off-by: Feng Liu <feliu at nvidia.com> >> Reviewed-by: William Tu

Use newly introduced helper function that exactly does the same of closing the queue pairs. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c