similar to: getGraphicsEvent() questions, minor feature/tweak request, and patch(es).

Hey all. As in general it's a bad idea to allow an event handler to generate an event, and as comments in the code seem to suggest this isn't the intention either, I was wondering about recursion in getGraphicsEvent(). In main/gevents.c, both doMouseEvent() and doKeybd() have the following line; dd->gettingEvent = FALSE; /* avoid recursive calls */ And they reset it to TRUE

doKeybd() gets called in CHelpKeyIn() and NHelpKeyIn() in library/grDevices/src/devWindows.c, where the call is encapsulated in an 'if (dd->gettingEvent)' block. So the only times this code ever calls doKeybd() is when gettingEvent is in fact set. Further, it's called in two locations in X11_eventHelper(), in modules/X11/devX11.c, where the state of gettingEvent seems to be moot

Hi Is the correct patch to remove the setting of the gettingEvent flag or would it be better to flip the TRUE/FALSE setting (set to TRUE before handling then reset to FALSE after handling) ? Also, for this patch and for the other two you sent, one difficulty will be with testing the patches. I have no testing code for this, so would need at least a test or two from you (ideally someone

... I just realized that setGraphicsEventHandlers or getGraphicsEvent could have an 'onIdle' callback, to be called somewhere in the polling loop of gevents.c:163 - I think this would solve my problem #2 in a minimally disruptive way. On Mon, Jun 06, 2016 at 06:38:45PM -0700, frederik at ofb.net wrote: > Hi R-Devel, > > I've been working on an oscilloscope project using an

Hi R-Devel, I've been working on an oscilloscope project using an Arduino microcontroller board. I found that it's quite easy to get realtime updates, e.g. 30+ frames per second, if I read data from the board in a little Rcpp library. I have to use dev.hold() and dev.flush() to keep the plot from flickering, which restricts me to the "cairo" X11 device. I'd like to be able

Hi The current status is that I am keen for people to contribute some testing code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) There were also some getGraphicsEvent() changes/fixes suggested by Richard Bodewits (cc'ed), for which I am also seeking test code. Paul On 13/11/16 09:00, frederik at ofb.net wrote: > Hi Paul, > > Just checking in to see what the

Hi Frederik, >>>>> <frederik at ofb.net> >>>>> on Tue, 7 Jun 2016 15:20:05 -0700 writes: > ... I just realized that setGraphicsEventHandlers or > getGraphicsEvent could have an 'onIdle' callback, to be > called somewhere in the polling loop of gevents.c:163 - I > think this would solve my problem #2 in a minimally

Hi Just taking a bit more of a look at this today (currently fixated on making sure I can build some good regression tests). The best thing you can do is to keep reminding me like this :) Paul On 09/12/16 11:19, frederik at ofb.net wrote: > Hi Paul, > > Thanks for your efforts. Do you have an idea when my patch(es) might > be committed? Is there anything I can do to help move this

Thanks Frederick. Mark, if you have any examples to share, they would also be gratefully received. Paul On 14/11/16 14:53, frederik at ofb.net wrote: > Hi Paul, > > OK I tried not to make the examples too fancy. > > Please let me know what you think. They should probably be amended to > support the Windows platform, but I think that task would be much > easier for someone

Great. Thanks! Paul On 14/11/16 13:41, frederik at ofb.net wrote: > Hi Paul, > > Thank you, for some reason I didn't seem to get an email notification > for your bugzilla comment! > > I will try to send you something shortly. > > Frederick > > On Mon, Nov 14, 2016 at 08:55:20AM +1300, Paul Murrell wrote: >> Hi >> >> The current status is that

Hi Taking a look at those patches is now on my todo list, so I may be in touch with both of you at some point to request some testing. Paul On 26/07/16 07:17, frederik at ofb.net wrote: > Dear Daniel Greenidge, > > To enable getGraphicsEvent on Cairo, you have two patches to choose > from: > > https://bugs.r-project.org/bugzilla/show_bug.cgi?id=14364 >

Hey all. Setting a time limit with setTimeLimit(), and then using getGraphicsEvent(), will cause graphics event handling for the current device to break on timeout, until the device is destroyed and recreated. The problem lies in do_getGraphicsEvent() checking the value of dd->gettingEvent and concluding it's being called recursively (ironically this same test fails to detect actual

Hi Paul, Thank you, for some reason I didn't seem to get an email notification for your bugzilla comment! I will try to send you something shortly. Frederick On Mon, Nov 14, 2016 at 08:55:20AM +1300, Paul Murrell wrote: > Hi > > The current status is that I am keen for people to contribute some testing > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) >

Hi Paul, Thanks for your efforts. Do you have an idea when my patch(es) might be committed? Is there anything I can do to help move this along? Thanks, Frederick On Mon, Nov 14, 2016 at 08:55:20AM +1300, Paul Murrell wrote: > Hi > > The current status is that I am keen for people to contribute some testing > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) >

Hi Paul, OK I tried not to make the examples too fancy. Please let me know what you think. They should probably be amended to support the Windows platform, but I think that task would be much easier for someone with access to Windows... By the way I'm Cc'ing Mark O'Connell who shared with me some great getGraphicsEvent examples - well, I found them useful, perhaps if these are going

Hi Paul, No problem. Is it best if I post examples to the bug report 16951? Kind regards, Mark -- Mark O'Connell, PhD student Department of Mathematics & Statistics 231 Top Logic National University of Ireland, Maynooth ----- Paul Murrell <paul at stat.auckland.ac.nz> wrote: > > Thanks Frederick. > > Mark, if you have any examples to share, they would also be

Hi Paul, Thanks for keeping me posted and letting me know what I should do. Are there regression tests for other graphics functions in R? To me that sounds a bit unnecessary. I think you get more testing from people who use R; and having a good turnaround for applying patches (some have been waiting 5 years) would invite better participation. Thank you, Frederick On Fri, Dec 09, 2016 at

Hi, I have a package where I do things like this a lot: if(strncmp(CHAR(asChar(Scategory)), "chance", 6) == 0) category = h_category_chance; else if(strncmp(CHAR(asChar(Scategory)), "utility", 7) == 0) category = h_category_utility; else if(strncmp(CHAR(asChar(Scategory)), "decision", 8) == 0) category = h_category_decision; else

Any idea why CHAR(asChar(STRING_ELT( produces NA whereas CHAR(STRING_ELT( gets a pointer to a string? It's generally expected that STRING_ELT should already be a character, but why the coercion does not work? Here is a simple example (consistent over R2.5.1-R2.6 rev 42284, I didn't check earlier versions, but it used to be different in 2.4): install.packages("inline")

Dear Daniel Greenidge, To enable getGraphicsEvent on Cairo, you have two patches to choose from: https://bugs.r-project.org/bugzilla/show_bug.cgi?id=14364 https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951 The second one is by me, and the first one is from five years ago by Hugo Mildenberger. Both patches are very simple, they move some lines enabling getGrahpicsEvent outside of a