similar to: version 2.3.3, file log.c bug report

Hello there, I just ran the sourceforge tool cppcheck over the source code of the new Linux kernel 2.6.32.4 It said 1. [./btrfs/free-space-cache.c:600]: (style) Redundant condition. It is safe to deallocate a NULL pointer The source code is                 if (info->bitmap)                         kfree(info->bitmap); I agree with cppcheck. Suggest delete the if test. 2.

Hello there, Offending source code is ????? if(? ( BattVoltage> 129 ) || ( BattVoltage < 144 ) ) Maybe swap || for && would be better. This problem I found by using cppcheck. It said [rhino.c:190]: (warning) Logical disjunction always evaluates to true: BattVoltage> 129 || BattVoltage < 144. Regards David Binderman

Hello there, dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:130]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((ret = doveadm_print_istream(input) < 0)) Maybe better code if ((ret = doveadm_print_istream(input)) < 0) Some duplicates: [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:220]: (style) Suspicious

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

Hello there, dovecot-2.2.33/src/lib/str-find.c:86]: (warning) Calling 'sizeof' on 'sizeof' Source code is ctx = p_malloc(pool, MALLOC_ADD(sizeof(struct str_find_context), MALLOC_MULTIPLY(sizeof(ctx->goodtab[0]), key_len))); Regards David Binderman

Hi! Here are some patches to the CVS (ices) that I made to get my radio webinterface with songselection-support working. To make the log update (flush) each time something is written (before the patch it flushes only when you quit): ---- CUT ---- Index: log.c ============================================================ ======= RCS file: /usr/local/cvsroot/log/log.c,v retrieving revision

I have a problem getting attachments to work in a specific case... I have the following data model (this is a relevant subset of it): - a log can have many journals - a journal belongs to a log and can have many attachments - an attachment belongs to a journal When adding on a new journal to an existing log the new journal form and the corresponding controller handle the attachment as well and

A user reported a bug where we do sizeof(*ptr * count) instead of sizeof(*ptr) * count. Fix this. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/send.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index ff40f1c..7c8964b 100644 --- a/fs/btrfs/send.c +++

Hi, got a little problem with the current cvs version of ices. I'm invoking it with the following: ices -v -F /home/nick/icetest.pls -h localhost -P <my password> which seems to connect ok, get past password validation, and gives me the following: DEBUG: Sending following information to libshout: DEBUG: Stream: 0 DEBUG: Host: localhost Port: 8000 DEBUG: Password: hack Icy Compat: 0

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

On Sun, 2005-02-20 at 12:15, Fr?d?ric Bri?re wrote: > I've been running ices2 like this 24/7 for months now, only restarting > it once a week for log rotation. Never had a problem since. setting <logsize> will cause an automatic log rotation when a certain file size has been reached. It renames <logfile> to <logfile>.1 then opens a new file <logfile> karl.

So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we

Hi Chris, et. al, I''ve recently come across cppcheck (static analyser for C code) and ran it on the current btrfs directory from Linus''s repo and it''s reported the following potential issues: linux-2.6$ cppcheck -q fs/btrfs/ [fs/btrfs/compression.c:343]: (error) Data is allocated but not initialized: cb [fs/btrfs/compression.c:583]: (error) Data is allocated but not

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c | 2 +- src/share/utf8/charset.c | 1 + src/test_libFLAC++/encoders.cpp | 8 ++++---- src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ++++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/libFLAC/bitreader.c

On Sun, Feb 20, 2005 at 08:15:42PM +0000, Karl Heyes wrote: > setting <logsize> will cause an automatic log rotation when a certain > file size has been reached. It renames <logfile> to <logfile>.1 then > opens a new file <logfile> Since all my other logs are rotated on a daily/weekly basis, I want my ices logs to behave in the same way. Nevertheless, this thread

The if() statement always evaluated to true. Detected by "cppcheck", not tested on real hardware. Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- drivers/rhino.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rhino.c b/drivers/rhino.c index ca66169..e478bcb 100644 --- a/drivers/rhino.c +++ b/drivers/rhino.c @@ -187,7 +187,7

On 11/14, Mehdi Amini via llvm-dev wrote: > Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :) I'd like that! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: Digital signature URL:

Hi all, There's a typo in the conditional to check the exit condition in ascii_strcasecmp in share/utf8/charset.c. It checks for (!*s1 || !*s1) instead of (!*s1 || !*s2). Attached patch fixes this. Note that the typo did not affect the result of the function as the loop is exited before changing s1 or s2 anyway. The problem was found by cppcheck which is run automatically on the Debian