similar to: [PATCH] fix for metadata_iterators.c

lvqcl wrote: > When I compile flac project with MSYS/MinGW-w64, I can see two files: > libFLAC.a and libFLAC-static.a. The only difference between them > is that libFLAC.a contains functions from win_utf8_io. > But 'make install' adds libFLAC.a into /local/lib, not libFLAC-static.a. Thank you for checking this. I've always had trouble with Autotools on Windows, even when

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes

JonY wrote: > What is your link test checking and how does it fail? My m4 macro is really simple, TRY_LINK a simple program with the stack protect CFLAGS: AC_DEFUN([XIPH_GCC_STACK_PROTECTOR], [AC_LANG_ASSERT(C) AC_MSG_CHECKING([if $CC supports stack smash protection]) xiph_stack_check_old_cflags="$CFLAGS" SSP_FLAGS="-fstack-protector --param ssp-buffer-size=4"

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

On 03-03-13 00:22, Erik de Castro Lopo wrote: > I have personally tested this code on: > > x86-linux > x86_64-linux > powerpc-linux Have you tried static building too? I just tried a bunch of switches for ../configure and both "--enable-static" as well as "--disable-shared --enable-static" fails for me on Kubuntu 12.04 64-bit with the following

On 26.9.2014 15:21, Erik de Castro Lopo wrote: > Janne Hyv?rinen wrote: > >> Patch v2, now handles more malformed cases. Original patch was for a >> file for which I had a sample from a user but this allows handling some >> manually broken test cases. > > Err, I'm getting warning messages on that patch: > > CC metadata_iterators.lo >

Hi all, I finally managed to bite the bullet and roll a pre-release. Its here: http://downloads.xiph.org/releases/flac/beta/ I have personally tested this code on: x86-linux x86_64-linux powerpc-linux I have not yet done any work on making sure the changelog is up-to-date. That will be done between now and the release. What I'm after now is testing of this source tarball

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus

Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I currently have two configurations where my detection says that SSP is available

Some libcs like uClibc-ng can optionally disable deprecated functions. utime is one of them. When done so, both the header and the function go missing. This fixes flac_utime to work in such a situation. --- include/share/compat.h | 10 +++++++++- src/libFLAC/metadata_iterators.c | 9 +++++++-- src/share/grabbag/file.c | 9 +++++++-- 3 files changed, 23 insertions(+), 5

On 3/13/2013 03:50, Dave Yeo wrote: > On 03/12/13 12:39 pm, Erik de Castro Lopo wrote: >> For the Linux -> Windows cross compile for instance, this detects >> SSP as working, but when I compile it fails with: >> >> CC stream_encoder_framing.lo >> CC window.lo >> CCLD libFLAC.la >> Creating library file:

Sorry for spamming but in the haste I forgot the stream_decoder part out. On 26.9.2014 15:47, Janne Hyv?rinen wrote: > On 26.9.2014 15:21, Erik de Castro Lopo wrote: >> Janne Hyv?rinen wrote: >> >>> Patch v2, now handles more malformed cases. Original patch was for a >>> file for which I had a sample from a user but this allows handling some >>> manually

This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 +++++++++-------- src/flac/main.c | 2 +- src/libFLAC/metadata_iterators.c | 2 +-

Hi Josh et al, I'm compiling on an Ubuntu Edgy x86 machine. Edgy comes standard with gcc-4.1 and I'm getting a number of warnings: memory.c: In function 'FLAC__memory_alloc_aligned': memory.c:52: warning: cast from pointer to integer of different size memory.c:52: warning: cast to pointer from integer of different size metadata_iterators.c: In function

Patch v2, now handles more malformed cases. Original patch was for a file for which I had a sample from a user but this allows handling some manually broken test cases. On 25.9.2014 21:53, Janne Hyv?rinen wrote: > Here's a patch to allow flac and metaflac handle files with malformed > vorbiscomment metadata block. > > > _______________________________________________ >

Here are the warnings I get with 03a9e6064d406e3656afacdbe50e8e47ebfa0de3: LANG=C android-make | grep Warning bitreader.c: In function 'FLAC__bitreader_skip_bits_no_crc': bitreader.c:494:4: warning: implicit declaration of function 'MIN' [-Wimplicit-function-declaration] bitreader.c:494:4: warning: nested extern declaration of 'MIN' [-Wnested-externs] bitwriter.c: In

On 01-04-13 12:40, Erik de Castro Lopo wrote: > I've tested this on > > x86_64-linux > powerpc-linux > i386-openbsd5.2 > i386-freebsd9 I've tested this on x86_64-linux as well, but still no static building possible (see earlier post on this). Someone over at HydrogenAudio has successfully built statically linked, but gets all weird kinds of errors

2013/5/15 Ulrich Klauer <ulrich at chirlu.de> > Felix Homann wrote: > > > Yes, HAVE_SYS_PARAM_H is set in config.h: > > OK ... Yet still I don't see how a change in > src/libFLAC/include/private/macros.h could affect src/flac/utils.c in > any way. > > Anyone got an idea? I haven't spend too much attention to the errors when bisecting, sorry! The

--- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > Hi Josh et al, > > I'm compiling on an Ubuntu Edgy x86 machine. Edgy comes standard > with gcc-4.1 and I'm getting a number of warnings: > > memory.c: In function 'FLAC__memory_alloc_aligned': > memory.c:52: warning: cast from pointer to integer of different > size > memory.c:52: