similar to: [PATCH] MSVC: add ENABLE_64_BIT_WORDS macro

Janne Hyvärinen wrote: > Minor changes needed for Visual Studio as the version is defined in the > project files. > > Replace 'PACKAGE_VERSION=\"1.3.2\&quot' with > 'PACKAGE_VERSION=\"1.3.3rc1\&quot' in > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > replace 'PACKAGE_VERSION="1.3.2"' with

Hi all, I have a new pre-reelase (with a GPG signature) up here: http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz.asc This code is built from commit 10a28d482a8e48b806f61ab766992b2add98ec43 plus another commmit to change the version numbers which I will not be pushing to the public repo before the final release. Note that audio files encoded

For some reasons libFLAC_dynamic, libFLAC++_dynamic and libFLAC++_static projects depend on win_utf8_io_static project, but there's no such dependency for libFLAC_static project. The patch adds such dependency. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_dependency.patch Type: application/octet-stream Size: 1484 bytes Desc: not available Url :

A preprocessor macro FLAC__ALIGN_MALLOC_DATA is defined in Makefiles but absent in *.vcproj files. This patch adds it to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. -------------- next part -------------- A non-text attachment was scrubbed... Name: align_malloc.patch Type: application/octet-stream Size: 2862 bytes Desc: not available Url :

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Well first of all, none of them apply :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Solution file still contained the removed in_flac project causing unnecessary errors on load. -------------- next part -------------- --- FLAC.sln.orig Wed Mar 13 18:23:38 2013 +++ FLAC.sln Sat Mar 16 19:14:43 2013 @@ -57,14 +57,6 @@ Project("{4cefbc7c-c215-11db-8314-080020 {4cefbc89-c215-11db-8314-0800200c9a66} = {4cefbc89-c215-11db-8314-0800200c9a66} EndProjectSection EndProject

--- src/test_grabbag/cuesheet/Makefile.am | 2 +- src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am | 2 +- src/test_libFLAC/Makefile.am | 2 +- src/test_seeking/Makefile.am | 2 +- src/test_streams/Makefile.am | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test_grabbag/cuesheet/Makefile.am

Currently MSVS can build dynamic libraries (libFLAC_dynamic.dll, libFLAC++_dynamic.dll), static libraries (libFLAC_static.lib, libFLAC++_static.lib) and executables (flac.exe, metaflac.exe, etc). All executables are statically linked to libFLAC. It's possible to create a flac.exe that is linked to thr libFLAC DLL file, but it requires manual editing of various projects in the FLAC solution.

lvqcl wrote: > lvqcl wrote: > > > The patch does the following: > > Does the patch work for linux git? Windows git cannot apply a patch > that was created itself. It looks like that patch was created with the 'git diff' command and hence cannot be applied using the 'git am' command. It does however apply using the patch command. > (It writes LF in

The following patch changes export.h so that the dllimport/dllexport attributes work with mingw/mingw-w64 and others: - changes _declspec keyword to __declspec: the former may not be defined by some toolchains. - changes the _MSC_VER condition to universally _WIN32: MSVC, as well as GCC supports this. Attached patch: declspec.diff Regards. -- O.S. -------------- next part --------------

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes

Erik de Castro Lopo wrote: >> VS 2005/2008 use .vcproj files, and VS 2010/2012/2013 use .vcxproj >> and .vcxproj.filters files, so it's possible to have two sets of >> MSVS solution files: one for 2005/2008 and another for 2010/2012/2013. >> >> But there will be two .sln files: current FLAC.sln and new FLAC-vs2013.sln >> (or FLAC-vs201x.sln? or is it better

Hi! I have trouble compiling the flac library using Microsofts free (yes MS gives it away including the optimizing C++ compiler msvc8.0) Visual Studio Express 2005. I get the output shown below. Does anyone have a way to make flac compile in VS 2005? Thanks! Ulrik 1>------ Rebuild All started: Project: replaygain_analysis_static, Configuration: Debug Win32 ------ 1>Deleting

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c | 2 +- src/share/utf8/charset.c | 1 + src/test_libFLAC++/encoders.cpp | 8 ++++---- src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ++++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/libFLAC/bitreader.c

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

lvqcl wrote: > 1) > Current MSVC solution (FLAC.sln and numerous .vcproj files) was made with > VC2005 Express and doesn't allow to build 64-bit files/libraries. > > IMHO it's time to add 64-bit support for MSVC builds, but AFAIK only Visual Studio > 2012/2013 Express are free and allow to build 64-bit files. > > VS 2005/2008 use .vcproj files, and VS

The test script doesn't seem to stop on error. I noticed this in the logs: ++++++ testing level 1 interface simple iterator on read-only file generating FLAC file for test testing 'metadata.flac'... 0... 1... content... PASSED is writable = 1 ERROR: iterator claims file is writable when it should not be ERROR during test_libFLAC FAIL: ./test_libFLAC.sh Platform is a mobile

Hi. I'm trying to get a project linking to libFLAC_static.lib but I get linker errors such as the following. 6>AudioDecoder.lib(CFlacDecoder.obj) : error LNK2019: unresolved external symbol __imp__FLAC__stream_decoder_process_until_end_of_metadata referenced in function "protected: int __thiscall CFlacDecoder::CreateDecoder(void)" (?CreateDecoder at CFlacDecoder@@IAEHXZ)

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.