similar to: MSVC, win_utf8_io, static and dynamic libs

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Well first of all, none of them apply :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and

That's how I understand how flac.exe works with unicode under Windows: There's a flag win_utf8_io_codepage that is equal either to CP_ACP or to CP_UTF8. Initially it's equal to CP_ACP. Then flac.exe/metaflac.exe call get_utf8_argv() that do some things and sets win_utf8_io_codepage to CP_UTF8 on success. This is the only way to set this flag to CP_UTF8. The programs continue to work

For some reasons libFLAC_dynamic, libFLAC++_dynamic and libFLAC++_static projects depend on win_utf8_io_static project, but there's no such dependency for libFLAC_static project. The patch adds such dependency. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_dependency.patch Type: application/octet-stream Size: 1484 bytes Desc: not available Url :

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes

All MSVC projects that generate .lib files have '_static' suffix in their names; all but win_utf8_io. This patch renames it so that it follows this naming convention. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_static.patch Type: application/octet-stream Size: 9097 bytes Desc: not available Url :

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Janne Hyvärinen wrote: > Minor changes needed for Visual Studio as the version is defined in the > project files. > > Replace 'PACKAGE_VERSION=\&quot;1.3.2\&quot' with > 'PACKAGE_VERSION=\&quot;1.3.3rc1\&quot' in > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > replace 'PACKAGE_VERSION="1.3.2"' with

So far I can see three ideal solutions of this issue: 1) Make Unicode support a part of the libFLAC API. In this case there will be no need in separate -lFLAC -lwin_utf8_io options, just -lFLAC will be needed. 2) Remove the dependency between libFLAC and win_utf8_io. In this case win_utf8_io will be linked statically to 1st-party apps, like other libraries from src/share:

Solution file still contained the removed in_flac project causing unnecessary errors on load. -------------- next part -------------- --- FLAC.sln.orig Wed Mar 13 18:23:38 2013 +++ FLAC.sln Sat Mar 16 19:14:43 2013 @@ -57,14 +57,6 @@ Project("{4cefbc7c-c215-11db-8314-080020 {4cefbc89-c215-11db-8314-0800200c9a66} = {4cefbc89-c215-11db-8314-0800200c9a66} EndProjectSection EndProject

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.

A preprocessor macro FLAC__ALIGN_MALLOC_DATA is defined in Makefiles but absent in *.vcproj files. This patch adds it to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. -------------- next part -------------- A non-text attachment was scrubbed... Name: align_malloc.patch Type: application/octet-stream Size: 2862 bytes Desc: not available Url :

This patch adds ENABLE_64_BIT_WORDS preprocessor variable to libFLAC_dynamic, libFLAC_static and test_libFLAC projects, x64 platform. -------------- next part -------------- A non-text attachment was scrubbed... Name: vcxproj.patch Type: application/octet-stream Size: 5797 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20160426/0ba518a4/attachment.obj>

First, this dependency exists only on Windows. For obvious reasons such dependency cannot exist on Linux/FreeBSD/OSX/etc. Previous versions (up to 1.2.1) didn't support Unicode filenames on Windows. And then it was decided to add such support. Windows uses UTF-16, where characters have 16-bit wchar_t type. LibFLAC receives strings only via char*. So one way to add Unicode support is to add

On 5/24/14, lvqcl <lvqcl.mail at gmail.com> wrote: > Ozkan Sezer <sezeroz at gmail.com> ?????(?) ? ????? ?????? Sat, 24 May 2014 > 10:16:15 +0400: > >> - changes the _MSC_VER condition to universally _WIN32: MSVC, as well >> as GCC supports this. > > MSYS/MinGW 4.8.3, 4.9.0 can't compile code from git after this patch: > > format.c:47:22: error:

Hi everyone, I'm trying to get started with libFLAC++. I've built the static libs libFLAC, libFLAC++ and libogg using VS2010 on windows 7. However when I try build the example project "example_cpp_encode_file" I get a lot of linker errors. I checked linker/input/additional dependencies and added the paths for libFLAC, libFLAC++ and corrected the path for libogg. Now I'm just

Op 1 sep. 2011 14:12 schreef "NAKAMURA Takumi" <geek4civic at gmail.com> het volgende: > > Guys, welcome to the too weird i18n world! > We, Japanese, has got suffered for multibyte charset for 20 years. > > I have added a comment in http://llvm.org/bugs/show_bug.cgi?id=10348 . > Of course I know, I don't think it would be a practical resolution. > > FYI,

Guys, welcome to the too weird i18n world! We, Japanese, has got suffered for multibyte charset for 20 years. I have added a comment in http://llvm.org/bugs/show_bug.cgi?id=10348 . Of course I know, I don't think it would be a practical resolution. FYI, it seems clang can retrieve mbcs path with s/CP_UTF8/CP_ACP/g. E>bin\clang.exe -S なかむら\たくみ.c なかむら\たくみ.c:4:2: error: #error #error ^ 1

We would like to use the static libraries in our commercial software. This software is an MFC application which is statically linked to the MFC libraries. We added LibFLAC_static.lib and LibFLAC++_static.lib but this causes an error when trying to run our application ('A required file was missing MSVCRTXX.DLL'). After looking in the Project Settings of the FLAC source, I found that the

Hi all, I have a new pre-reelase (with a GPG signature) up here: http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz.asc This code is built from commit 10a28d482a8e48b806f61ab766992b2add98ec43 plus another commmit to change the version numbers which I will not be pushing to the public repo before the final release. Note that audio files encoded