similar to: [PATCH] assign NULL after free

Here's a patch to allow flac and metaflac handle files with malformed vorbiscomment metadata block. -------------- next part -------------- diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c index d50df39..39cb276 100644 --- a/src/libFLAC/metadata_iterators.c +++ b/src/libFLAC/metadata_iterators.c @@ -78,7 +78,7 @@ static FLAC__Metadata_SimpleIteratorStatus

libFLAC has several places like this: if(0 == (ptr = realloc(ptr, size))) return false; which results in memory leaks if realloc fails (the old value of ptr is lost). The patch should fix this. -------------- next part -------------- A non-text attachment was scrubbed... Name: realloc_memleak_fix.patch Type: application/octet-stream Size: 6272 bytes Desc: not available Url :

Hi Josh et al, I'm compiling on an Ubuntu Edgy x86 machine. Edgy comes standard with gcc-4.1 and I'm getting a number of warnings: memory.c: In function 'FLAC__memory_alloc_aligned': memory.c:52: warning: cast from pointer to integer of different size memory.c:52: warning: cast to pointer from integer of different size metadata_iterators.c: In function

On Tue, Dec 17, 2002 at 01:01:08PM -0800, Josh Coalson wrote: > --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > Ok, what about enabling the 3dnow function in libFLAC by default? > > I think time has shown the function is bugfree... :) > > Yeah, I just haven't done it because I don't remember hearing > feedback from others about using it (or

Patch v2, now handles more malformed cases. Original patch was for a file for which I had a sample from a user but this allows handling some manually broken test cases. On 25.9.2014 21:53, Janne Hyv?rinen wrote: > Here's a patch to allow flac and metaflac handle files with malformed > vorbiscomment metadata block. > > > _______________________________________________ >

On 26.9.2014 15:21, Erik de Castro Lopo wrote: > Janne Hyv?rinen wrote: > >> Patch v2, now handles more malformed cases. Original patch was for a >> file for which I had a sample from a user but this allows handling some >> manually broken test cases. > > Err, I'm getting warning messages on that patch: > > CC metadata_iterators.lo >

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

Erik de Castro Lopo wrote: > Working on a fix for this and re-visiting some of this realloc() > stuff. I noticed that your patch removes the call to vorbiscomment_entry_array_delete_() in FLAC__metadata_object_vorbiscomment_resize_comments() function, and I think that it reintroduces one place of a potential memory leak: 'object->data.vorbis_comment.comments' is a pointer to an

I passed a valid FILE* (from fopen() with "rb") and the address of an OggVorbis_File struct, but an access violation occured when ov_open is called. I have enabled the Multithreaded, but it still doesn't fix the problem. I look at the vorbis_comment.exe source and I see vcedit_open() function and other vcedit_*() functions everywhere. I am assuming that there is known issue with VC

I am using the standard Xiph.org FLAC encoder, but I couldn't find any option to update the meta-data mid-stream. Also the FLAC spec says, that it defines VORBIS_COMMENT as the only way to transmit meta-data information. This is the only officially supported tagging mechanism in FLAC. There may be only one VORBIS_COMMENT block in a stream. As such, when you state, that meta data is the domain

This patch offers interface to get the library name which software uses. Function: char *vorbis_version_string(void); PATCH (for libvorbis-1.2.1RC2): diff -crN libvorbis-1.2.1RC2/include/vorbis/codec.h libvorbis-1.2.1RC2_NI/include/vorbis/codec.h *** libvorbis-1.2.1RC2/include/vorbis/codec.h Mon Aug 25 05:57:44 2008 --- libvorbis-1.2.1RC2_NI/include/vorbis/codec.h Sat Sep 13 05:00:22 2008

On 01-04-13 12:40, Erik de Castro Lopo wrote: > I've tested this on > > x86_64-linux > powerpc-linux > i386-openbsd5.2 > i386-freebsd9 I've tested this on x86_64-linux as well, but still no static building possible (see earlier post on this). Someone over at HydrogenAudio has successfully built statically linked, but gets all weird kinds of errors

--- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > Hi Josh et al, > > I'm compiling on an Ubuntu Edgy x86 machine. Edgy comes standard > with gcc-4.1 and I'm getting a number of warnings: > > memory.c: In function 'FLAC__memory_alloc_aligned': > memory.c:52: warning: cast from pointer to integer of different > size > memory.c:52:

Ok, what about enabling the 3dnow function in libFLAC by default? I think time has shown the function is bugfree... :) -- Miroslav Lichvar

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's

Well, I'm quite frankly stumped. I'm writing a program that recurses into directories and reads (among others) FLAC files and should be able to read the vorbis comments ARTIST and TITLE from the file. A while back, I was popen()ing to metaflac, because I didn't want to mess with libFLAC. But now, it's the weekend, so I can mess around with this. Here's the code in question:

This is *nothing* major, just a minor tweak that makes FreeStream's rebroadcast system work smoother. It is a patch for icecast CVS( checked out at 20040505 20:00UTC), That simply adds to format_vorbis.c the ability to read more vorbis_comment information (namely; comment, info and length) Hopefully this can be useful. -- Justin Zeigler, a.k.a. Barbicane (jzeigler@freestream.net)

--- examples/c/decode/file/main.c | 3 +++ examples/c/encode/file/main.c | 3 +++ src/metaflac/operations.c | 3 +++ src/metaflac/operations_shorthand_cuesheet.c | 3 +++ src/metaflac/operations_shorthand_streaminfo.c | 3 +++ src/share/grabbag/cuesheet.c | 3 +++ src/test_libFLAC/encoders.c

Hi all, I tend to compile my code with all GCC warnings turned on. However, when I do this : vorbis_comment_add_tag(&vdata->vc,"ENCODER","libsndfile"); I get the following warning messages: warning: passing argument 2 of 'vorbis_comment_add_tag' discards qualifiers from pointer target type warning: passing argument 3 of

This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I think this is exceptable. --- include/FLAC/ordinals.h | 17 +++++++++-------- src/flac/main.c | 2 +- src/libFLAC/metadata_iterators.c | 2 +-