similar to: [PATCH] two fixes

Erik de Castro Lopo wrote: > Hadn't decided yet. Please give me 12 hours. Gotta go to > work now :-) All right. BTW, test_libFLAC is still broken for MSVS: CPU_IS_LITTLE_ENDIAN is undefined. It's possible to add the definition for this preprocessor macro to test_libFLAC.vcproj, but maybe there exists more elegant way?

The gcc version #ifdef fix for bswap16 doesn't work for Apple's clang. Here's a better fix, which has configure check for it directly. Fixes build failures on MacOS X. -r -------------- next part --------------

Erik de Castro Lopo wrote: > Do you want to create a patch for this or should I? I'll do it, it is MSVS-specific and I can test it on Visual Studio. But it will change src/libFLAC/stream_decoder.c, so it interferes with this patch: http://lists.xiph.org/pipermail/flac-dev/2014-July/004878.html Did you decide that those patches ain't worth applying? (I admit that they don't really

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c | 2 +- src/share/utf8/charset.c | 1 + src/test_libFLAC++/encoders.cpp | 8 ++++---- src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ++++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/libFLAC/bitreader.c

The test script doesn't seem to stop on error. I noticed this in the logs: ++++++ testing level 1 interface simple iterator on read-only file generating FLAC file for test testing 'metadata.flac'... 0... 1... content... PASSED is writable = 1 ERROR: iterator claims file is writable when it should not be ERROR during test_libFLAC FAIL: ./test_libFLAC.sh Platform is a mobile

That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh | 2 ++ test/test_flac.sh | 2 ++ test/test_grabbag.sh | 2 ++ test/test_libFLAC++.sh | 2 ++ test/test_libFLAC.sh | 3 +++ test/test_metaflac.sh | 2 ++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files

The 1st patch fixes compiling of test_libFLAC with MSVC. The 2nd patch fixes Makefile.lite build system (I don't use it, but this patch is really simple...) -------------- next part -------------- A non-text attachment was scrubbed... Name: 1_msvc.patch Type: application/octet-stream Size: 911 bytes Desc: not available Url :

--- David Willmore <davidwillmore@iamanidiot.com> wrote: > > The test script doesn't seem to stop on error. I noticed this > in the logs: > > ++++++ testing level 1 interface > simple iterator on read-only file > generating FLAC file for test > testing 'metadata.flac'... 0... 1... content... PASSED > is writable = 1 > ERROR: iterator claims file

Here is the patch that allows to set FLAC__BYTES_PER_WORD to 8. This is disabled by default though. To test FLAC__BYTES_PER_WORD==8: open src/libFLAC/bitreader.c, src/libFLAC/bitwriter.c, src/test_libFLAC/bitwriter.c and change '#if 1' to '#if 0'. The value of FLAC__BYTES_PER_WORD must be the same in src/libFLAC/bitwriter.c and src/test_libFLAC/bitwriter.c. OTOH, their value in

the those logs look fine, maybe some other test failed like the unit tests which are unfortunately not logged. could you try running them individually and see if there's a problem (they're relatively quick) $ cd test $ ./test_libFLAC.sh release && ./test_libFLAC++.sh release && ./test_flac.sh release && ./test_metaflac.sh release &&

I had trouble building because configure.in did not include the test_grabbag/picture/Makefile entry for Makefile generation. This patch rectifies that situation. This is with flac cvs as of this morning. E Signed-off-by: Erik Hovland <erik@hovland.org> -- Erik Hovland mail: erik AT hovland DOT org web: http://hovland.org/ PGP/GPG public key available on request -------------- next part

This patch adds ENABLE_64_BIT_WORDS preprocessor variable to libFLAC_dynamic, libFLAC_static and test_libFLAC projects, x64 platform. -------------- next part -------------- A non-text attachment was scrubbed... Name: vcxproj.patch Type: application/octet-stream Size: 5797 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20160426/0ba518a4/attachment.obj>

Hi all, For testing a few mingw-builds I tried to use ./configure --disable-thorough-testing (because testing in a virtual machine through mingw isn't really fast) but it turned out this setting doesn't do anything. It turns out these configuration options aren't passed to the test scripts at all. I do not fully understand how Makefiles or environment variables work, but my

--- examples/c/decode/file/main.c | 3 +++ examples/c/encode/file/main.c | 3 +++ src/metaflac/operations.c | 3 +++ src/metaflac/operations_shorthand_cuesheet.c | 3 +++ src/metaflac/operations_shorthand_streaminfo.c | 3 +++ src/share/grabbag/cuesheet.c | 3 +++ src/test_libFLAC/encoders.c

On Nov 25 00:43:22, mle+la at mega-nerd.com wrote: > http://downloads.xiph.org/releases/flac/beta/ > Please test. Running 'make fullcheck' fails for me like this: $ pwd /home/hans/src/flac-1.3.1pre1/test $ make fullcheck FLAC__TEST_LEVEL=1 FLAC__TEST_WITH_VALGRIND=no ./test_libFLAC.sh /bin/sh: ./test_libFLAC.sh: No such file or directory *** Error 1 in

--- src/test_grabbag/cuesheet/Makefile.am | 2 +- src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am | 2 +- src/test_libFLAC/Makefile.am | 2 +- src/test_seeking/Makefile.am | 2 +- src/test_streams/Makefile.am | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test_grabbag/cuesheet/Makefile.am

With gcc >= 4 and ELF, set default visibility to hidden and make visible only the symbols with FLAC_API or FLACPP_API. A convenience libFLAC-static.la is created for test_libFLAC as it depends on the hidden symbols. --- configure.ac | 8 +++++++- include/FLAC++/export.h | 13 +++++++++---- include/FLAC/export.h | 13 +++++++++---- src/libFLAC/Makefile.am | 10

Hi all, As people may have seen there's a pre-release here: http://downloads.xiph.org/releases/flac/beta/ Specifically: flac-1.3.1pre1.tar.xz : The source code flac-1.3.1pre1-win.zip : Windows 32 and 64 bit binaries Please test. I'm particularly interested in hearing about the windows binaries which were cross compiled from Linux to Windows. Unfortunately there is a bug

My Valgrind doesn't run, saying it doesn't support showing more than 50 entries of a stack trace --- test/test_bins.sh | 4 ++-- test/test_flac.sh | 8 ++++---- test/test_grabbag.sh | 8 ++++---- test/test_libFLAC++.sh | 2 +- test/test_libFLAC.sh | 2 +- test/test_metaflac.sh | 12 ++++++------ test/test_seeking.sh | 12 ++++++------

--- COPYING.GPL | 43 +++++++++++----------- doc/Makefile.am | 6 +-- doc/Makefile.lite | 6 +-- examples/c/decode/file/Makefile.am | 6 +-- examples/c/decode/file/Makefile.lite | 6 +-- examples/c/decode/file/main.c | 6 +--