flac dev - Apr 2013 - Check level not passed to tests

Hi all,

For testing a few mingw-builds I tried to use ./configure 
--disable-thorough-testing (because testing in a virtual machine through 
mingw isn't really fast) but it turned out this setting doesn't do 
anything.

It turns out these configuration options aren't passed to the test 
scripts at all. I do not fully understand how Makefiles or environment 
variables work, but my test/Makefile has the following lines

FLAC__TEST_LEVEL = 0
FLAC__TEST_WITH_VALGRIND = no
[...]
TESTS_ENVIRONMENT = FLAC__TEST_LEVEL=0 FLAC__TEST_WITH_VALRGIND=no

However, when I added the following line at the bottom of 
test/test_streams.sh

echo "Test level was $FLAC__TEST_LEVEL"

the output I got was "Test level was 1". I traced it back to

if [ x"$FLAC__TEST_LEVEL" = x ] ; then
     FLAC__TEST_LEVEL=1
fi

It turns out $FLAC__TEST_LEVEL is unset in the test scripts. As I said 
before, I'm not sure how to fix this. This is probably also the case for 
$FLAC__TEST_WITH_VALGRIND

While going trough test/Makefile, I found this

# This is the full test suite, but only works correctly in-tree.
# In particular test_grabbag.sh, test_flac.sh and test_metaflac.sh will not
# run correctly out-of-tree.
fullcheck: $(check_SCRIPTS)
     ./test_libFLAC.sh
     ./test_libFLAC++.sh
     ./test_grabbag.sh
[...]

On 09-04-13 21:18, Martijn van Beurden wrote:
> While going trough test/Makefile, I found this
>
> # This is the full test suite, but only works correctly in-tree.
> # In particular test_grabbag.sh, test_flac.sh and test_metaflac.sh 
> will not
> # run correctly out-of-tree.
> fullcheck: $(check_SCRIPTS)
>     ./test_libFLAC.sh
>     ./test_libFLAC++.sh
>     ./test_grabbag.sh
> [...]
Please ignore this part. I thought it was some long-forgotten check, but 
I found it was quite a recent patch. I forgot to remove it from the e-mail.

This patch fixes the issue mentioned below.

On 09-04-13 21:18, Martijn van Beurden wrote:
> Hi all,
>
> For testing a few mingw-builds I tried to use ./configure 
> --disable-thorough-testing (because testing in a virtual machine 
> through mingw isn't really fast) but it turned out this setting 
> doesn't do anything.
>
> It turns out these configuration options aren't passed to the test 
> scripts at all. I do not fully understand how Makefiles or environment 
> variables work, but my test/Makefile has the following lines
>
> FLAC__TEST_LEVEL = 0
> FLAC__TEST_WITH_VALGRIND = no
> [...]
> TESTS_ENVIRONMENT = FLAC__TEST_LEVEL=0 FLAC__TEST_WITH_VALRGIND=no
>
> However, when I added the following line at the bottom of 
> test/test_streams.sh
>
> echo "Test level was $FLAC__TEST_LEVEL"
>
> the output I got was "Test level was 1". I traced it back to
>
> if [ x"$FLAC__TEST_LEVEL" = x ] ; then
>     FLAC__TEST_LEVEL=1
> fi
>
> It turns out $FLAC__TEST_LEVEL is unset in the test scripts. As I said 
> before, I'm not sure how to fix this. This is probably also the case 
> for $FLAC__TEST_WITH_VALGRIND
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixes-setting-test-level-and-valgrind-testing.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20130421/443f0823/attachment.bin

Martijn van Beurden wrote:
> This patch fixes the issue mentioned below.
Applied. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/