similar to: Fixed first cast-align warning

Martijn van Beurden wrote: > op 27-06-14 14:11, Erik de Castro Lopo schreef: > > There has been at least one person on this list who is able to do > > perfromance tests on FLAC. I would appreciate it if someone could > > run such a performance test before and after the above commit. > > Are you specifically referring to the ARM platform or to any > platform? The

Hi all, In commit 3eb4094b859 I think I have fixed all the cast-align warnings. I have tested this in amd64/Linux (little endian) and powerpc64/Linux (big endian) and it passed all tests (including the new MD5 tests). I also did a little performance testing on amd64/Linux with a one hour long stereo WAV file and could not find any mesasurable difference between the old and the new code. I

Hi all, I just pushed a commit which fixes a nasty regression in FLAC. https://git.xiph.org/?p=flac.git;a=commit;h=fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6 > author Erik de Castro Lopo <erikd at mega-nerd.com> > committer Erik de Castro Lopo <erikd at mega-nerd.com> > commit fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6 > > Fix a regression that severely impacted

lvqcl wrote: > Erik de Castro Lopo wrote: > > >> FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS * sizeof(FLAC__int32)/sizeof(FLAC__int16)]; > >> > >> instead of > >> > >> FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS * sizeof(FLAC__int16)]; > > > > Really? Would you also write this? : > > >

Brian Willoughby wrote: > It makes sense to have the option to return non-zero when the > "compression" fails to "compress." As Erik pointed out, a script > could use the return code to decide to delete the larger FLAC output > file and keep the original input file since it is smaller (and > equally lossless). > > However, I agree that it is

Hi all, People watching the git commits might have noticed that I have been fixing a number of issues around undefined behaviour. Why you ask? * Some forms of undefined behaviour have potential for security exploits. * Compiler writers are free to replace anything which invokes UB with a NOP or even, nothing at all. * Having large numbers of UB warnings makes it difficult (or rather time

--- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > Josh Coalson wrote: > > > --- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > > > > > Hi all, > > > > > > Is seeking working for OggFlac files? I keep on getting a > > > FLAC__STREAM_DECODER_SEEK_ERROR. > > > > yes, it should work fine. in

On Thu, Jul 31, 2008 at 12:32, Erik de Castro Lopo <mle+cl at mega-nerd.com> wrote: > Hi all, > > I'm interested in the LLVM Ocaml bindings so I pulled the current > sources from SVN and built them. When I ran the test suite I got the > following stats: > > # of expected passes 2631 > # of unexpected failures 7 > # of expected

Earl Chew wrote: > Erik, > > My working view has this as the last commit: > > commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 > Author: David Schleef <ds at schleef.org> > Date:?? Thu Aug 25 18:40:29 2011 -0700 > > ??? Fix md5 structure clearing in previous commit > > > > Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.

lvqcl wrote: > No, FLAC__AVX_SUPPORTED is 0 (initially it's undefined, then inside cpu.h > it's defined as 0). > > MSVC cannot discard unused references in debug builds and when LTCG is on, > for example: <http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-April/193437.html> > > And currently LTCG is enabled for release builds. Ok, I think I've fixed it

On Sun, 30 Jan 2005 14:39:18 -0800 (PST) Josh Coalson <xflac@yahoo.com> wrote: > --- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > > On Sun, 30 Jan 2005 10:45:05 -0800 (PST) > > Josh Coalson <xflac@yahoo.com> wrote: > > > > > OK, thanks, checked in. once linux-ppc is ironed out the > > > release should be ready to go. > >

Josh et al, I've been tracking down a problem with generating OggFlac files. While investigatint this issue I hacked one of the test files from the test_libFLAC directory of the flac-1.1.3-beta2. The result of this hacking is this standalone C file: http://www.mega-nerd.com/tmp/erikd_test.c Directions for compiling this is in the comments at the top of the file. When the program is

Josh Coalson wrote: > --- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > > > Hi all, > > > > Is seeking working for OggFlac files? I keep on getting a > > FLAC__STREAM_DECODER_SEEK_ERROR. > > yes, it should work fine. in flac/src/test_seeking/main.c there > is an example usage of FLAC__stream_decoder_seek_absolute(). you > could try

lvqcl wrote: > 1) if FLAC__SSE_OS==1 then MSVC cannot compile current cpu.c: > "#include <windows.h>" line is inactive and MSVC complains: > cpu.c(278): error C2065: 'EXCEPTION_EXECUTE_HANDLER': undeclared identifier > cpu.c(279): error C2065: 'STATUS_ILLEGAL_INSTRUCTION': undeclared identifier > > 2) the current code (simplified): > >

--- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > Erik de Castro Lopo wrote: > > > Josh et al, > > > > I've been tracking down a problem with generating OggFlac files. > > <snip> > > > I have looked into this and suspect that the > FLAC__stream_encoder_finish() > > function needs to finish off the stream using a call to

Ben Allison wrote: > This is the delta that should fix everything up. > I hope that #include "share/compat.h" is acceptable from the test_streams > binary. Yes, the share/* header files are shared between the library internals, the test suite programs and flac and metaflac binary executables. > If not, you can probably change it to FLAC/ordinals.h instead Are the changes

On 14 March 2016 at 09:02, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > commit a9f84425cfd5d1dbfb564730ca80d0b588cb4f24 > Author: Erik de Castro Lopo <erikd at mega-nerd.com> > Date: Mon Mar 14 18:14:31 2016 +1100 > > libFLAC/cpu.c: Use `sigemptyset` instead of `__sigemptyset` > > The former is POSIX while the later is a GNU

Erik de Castro Lopo wrote: > I think I have an alternative fix for the CVE which should not break > seeking. I'm working on getting an copy of the file with which to test. Patch applied and pushed. commit b4b2910bdca010808ccf2799f55562fa91f4347b Author: Erik de Castro Lopo <erikd at mega-nerd.com> Date: Wed Dec 10 18:54:16 2014 +1100

On 3/9/2013 06:20, Erik de Castro Lopo wrote: > bat guano wrote: > >> >> Hi >> I have a problem now cross-compiling FLAC from latest git. >> With Ubuntu 12.04 and g++-mingw-w64-i686 (4.6.3-1ubuntu5+5ubuntu1). >> >> I think that the problem might have been introduced on 5 Mar 2013 >> with commit 05609d5 (configure.ac : Add hardening compile options.)

On Thu, 11 Nov 2004 13:33:42 -0800 (PST) Josh Coalson <xflac@yahoo.com> wrote: > --- Erik de Castro Lopo <erikd-flac@mega-nerd.com> wrote: > > On Wed, 10 Nov 2004 16:08:21 -0800 (PST) > > Josh Coalson <xflac@yahoo.com> wrote: > > > > > > Is there someway of figuring out if a sample rate is valid? > > > > > > that's the