similar to: PATCH: FLAC__ALIGN_MALLOC_DATA definition for MSVS projects

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Well first of all, none of them apply :-). I'll try to redo the necessary patches with git. > * Remove restrict definition from include/share/compat.h. Applied. BTW, I tried to use 'restrict' keyword with MSVS 2010 and 2012 and in fact they don't support it. Only --restrict is supported. > * libFLAC and

Janne Hyvärinen wrote: > Minor changes needed for Visual Studio as the version is defined in the > project files. > > Replace 'PACKAGE_VERSION=\&quot;1.3.2\&quot' with > 'PACKAGE_VERSION=\&quot;1.3.3rc1\&quot' in > src/libFLAC/libFLAC_dynamic.vcproj and libFLAC_static.vcproj. And > replace 'PACKAGE_VERSION="1.3.2"' with

Hi all, I have a new pre-reelase (with a GPG signature) up here: http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz http://mega-nerd.com/tmp/flac-1.3.3rc1.tar.xz.asc This code is built from commit 10a28d482a8e48b806f61ab766992b2add98ec43 plus another commmit to change the version numbers which I will not be pushing to the public repo before the final release. Note that audio files encoded

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Patch applied, tested, commited and pushed. Great. But, what about my other patches? I admit that many of them aren't necessary, but (imho) a couple of them are important. I can explain in detail why I think this.

lvqcl wrote: > lvqcl wrote: > > > The patch does the following: > > Does the patch work for linux git? Windows git cannot apply a patch > that was created itself. It looks like that patch was created with the 'git diff' command and hence cannot be applied using the 'git am' command. It does however apply using the patch command. > (It writes LF in

Solution file still contained the removed in_flac project causing unnecessary errors on load. -------------- next part -------------- --- FLAC.sln.orig Wed Mar 13 18:23:38 2013 +++ FLAC.sln Sat Mar 16 19:14:43 2013 @@ -57,14 +57,6 @@ Project("{4cefbc7c-c215-11db-8314-080020 {4cefbc89-c215-11db-8314-0800200c9a66} = {4cefbc89-c215-11db-8314-0800200c9a66} EndProjectSection EndProject

For some reasons libFLAC_dynamic, libFLAC++_dynamic and libFLAC++_static projects depend on win_utf8_io_static project, but there's no such dependency for libFLAC_static project. The patch adds such dependency. -------------- next part -------------- A non-text attachment was scrubbed... Name: win_utf8_dependency.patch Type: application/octet-stream Size: 1484 bytes Desc: not available Url :

This patch adds ENABLE_64_BIT_WORDS preprocessor variable to libFLAC_dynamic, libFLAC_static and test_libFLAC projects, x64 platform. -------------- next part -------------- A non-text attachment was scrubbed... Name: vcxproj.patch Type: application/octet-stream Size: 5797 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20160426/0ba518a4/attachment.obj>

lvqcl wrote: >>> Win_utf8 stuff should not be included in libflac since it's only to be >>> used by the flac.exe frontend. It is not needed by other programs nor >>> would they benefit from it without doing the extra work of converting >>> their ansi filenames and functions to utf-8. >>> >>>> Version 2 of my patch attached, which fixes

Janne Hyv?rinen wrote: > Win_utf8 stuff should not be included in libflac since it's only to be > used by the flac.exe frontend. It is not needed by other programs nor > would they benefit from it without doing the extra work of converting > their ansi filenames and functions to utf-8. > >> Version 2 of my patch attached, which fixes the problem for the >>

Janne Hyv?rinen wrote: > With the sources as they are compiling produces these errors (this on > MSVC 2012 SP1 Express): > > Error 1 error LNK2001: unresolved external symbol > _FLAC__bitreader_bits_left_for_byte_alignment > G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) Ben Alison is working on tthis. Lets allow that work to come to a

lvqcl wrote: > 1) > Current MSVC solution (FLAC.sln and numerous .vcproj files) was made with > VC2005 Express and doesn't allow to build 64-bit files/libraries. > > IMHO it's time to add 64-bit support for MSVC builds, but AFAIK only Visual Studio > 2012/2013 Express are free and allow to build 64-bit files. > > VS 2005/2008 use .vcproj files, and VS

With current settings, MSVS links debug version of flac.exe (and other .exe and .dll files) with the release version of libogg_static.lib. MSVS issues a "warning LNK4098: defaultlib 'libcmt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library" What's the reason in this setting? What is better: * to change the settings so that MSVS will link debug .exe files with

Janne Hyv?rinen wrote: > Here's a patch that fixes the creation of larger than 2 GB FLAC files. > Without this patch both GCC and MSVC compiles of FLAC will fail on > Windows when they have written 2 GB file while encoding from stdin. And > after 4GB when encoding from WAV file. Ok. > It includes Ben Allison's MSVC changes and JonY's MinGW changes with > some

lvqcl wrote: > Audacity still uses VS2008 and slowly tries to migrate to VS2012. > But as stated at <http://wiki.audacityteam.org/wiki/Developing_On_Windows>, > "Audacity is currently a 32-bit only application". So it doesn't need > 64-bit builds. > Currently its trunk contains 'audacity.sln' made with Visual C++ Express 2008 > and

Currently MSVS can build dynamic libraries (libFLAC_dynamic.dll, libFLAC++_dynamic.dll), static libraries (libFLAC_static.lib, libFLAC++_static.lib) and executables (flac.exe, metaflac.exe, etc). All executables are statically linked to libFLAC. It's possible to create a flac.exe that is linked to thr libFLAC DLL file, but it requires manual editing of various projects in the FLAC solution.

This patch allows MSVS to use M_LN2 const defined in math.h -------------- next part -------------- A non-text attachment was scrubbed... Name: mathln2.patch Type: application/octet-stream Size: 963 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130904/14cd34db/attachment.obj

The following patch changes export.h so that the dllimport/dllexport attributes work with mingw/mingw-w64 and others: - changes _declspec keyword to __declspec: the former may not be defined by some toolchains. - changes the _MSC_VER condition to universally _WIN32: MSVC, as well as GCC supports this. Attached patch: declspec.diff Regards. -- O.S. -------------- next part --------------

This patch fixes output directory for plugin_common_static.vcproj and test_libs_common_static.vcproj -------------- next part -------------- A non-text attachment was scrubbed... Name: static_lib.patch Type: application/octet-stream Size: 980 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130904/c99848a4/attachment.obj