similar to: Wave64 format fix

Here's a patch that makes MSVC compiled flac.exe able to use wildcards and encode/decode files with Unicode characters in names. It may not be the prettiest code but it fulfills its primary purpose. I tried to alter FLAC code as little as possible. It replaces argv with utf-8 encoded version and only converts to usable Unicode for file functions. That means printed texts and tags that

Janne Hyv?rinen wrote: > I re-did the patch with these limitations. I also noticed I had left > stat() and fstat() functions unfixed previously. And encoder was limited > to 4G in many places when printing status info. Unfortunately, this patch did not apply cleanly. There were two problems; one in src/flac/main.c that was easy and obvious to fix, the other in include/share/compat.h.

On 10.4.2013 10:39, Martijn van Beurden wrote: > On 08-04-13 22:00, Janne Hyv?rinen wrote: >> On 8.4.2013 21:38, Janne Hyv?rinen wrote: >>> Friendly people on Hydrogenaudio found some bugs with the Unicode >>> printing code, so I was forced to make adjustments. >>> [...] >> The long line patch is broken and requires much more work, please >> ignore

On 25.11.2014 12:14, Miroslav Lichvar wrote: > I think the case with non-zero partition order may need to be fixed > too. For example, with partition order of 1, predictor order of 16 and > blocksize of 4, the function would return true and blocksize-order in > the caller would still underflow. > > --- a/src/libFLAC/stream_decoder.c > +++ b/src/libFLAC/stream_decoder.c > @@

On 8.4.2013 21:38, Janne Hyv?rinen wrote: > Friendly people on Hydrogenaudio found some bugs with the Unicode > printing code, so I was forced to make adjustments. > > While doing testing I noticed that long filenames cause printing bugs > on Linux too. If line length on status printing exceeded console > length it kept printing the same line over and over. > The patch I

Janne Hyv?rinen wrote: > The patch was made from the published pre2 version. It missed the MinGW > changes that were applied to git version. Patch applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

On 19.3.2013 15:49, JonY wrote: > On 3/19/2013 19:59, Janne Hyv?rinen wrote: >> On 18.3.2013 12:25, Erik de Castro Lopo wrote: >>> JonY wrote: >>> >>>> Before anyone does anything, see __wgetmainargs >>>> <http://msdn.microsoft.com/en-us/library/ff770599.aspx>. >>>> >>>> It can expand wildcards. Since it already

lvqcl wrote: > I have a couple of questions: > > 1) Do you plan to release 1.3.1 pre1, pre2 etc or just 1.3.1 w/o any pre-releases? I had not planned to do a pre-release. > 2) Do you plan to release any official binaries (flac, metaflac, maybe something else)? Nor had I planned to release binaries. The source code tarball ends up here: https://svn.xiph.org/releases/flac/ I

On Sat, Jun 01, 2013 at 02:33:55PM +0300, Janne Hyv?rinen wrote: > On 1.6.2013 14:24, Janne Hyv?rinen wrote: > > I can confirm. I see 10% speed improvement with that change on Core i7. > > Decoding a 1h18min38.133s long test FLAC -8 encoded file takes with > > normal asm optimizations 7.656s (speed: 616,266x realtime) and with that > > tiny change 6.937s (speed: 680,140x

On 31.5.2013 13:04, Miroslav Lichvar wrote: > On Wed, May 29, 2013 at 04:08:57PM +0200, Martijn van Beurden wrote: >> I was surprised to see that the Windows compile on wine actually >> outperformed the native Linux one. Probably GCC 4.6 optimized a little >> better or something very weird is going on in wine, I don't know. The >> assembly optimizations work very

Janne Hyv?rinen wrote: > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > Janne Hyv?rinen wrote: > > > >> The patch was made from the published pre2 version. It missed the MinGW > >> changes that were applied to git version. > > Patch applied. Thanks. > > > > Erik > > Unfortunately with this commit the LRN's patch from commit

Janne Hyv?rinen wrote: > Sorry for spamming but I noticed one more display glitch while doing > further testing. It could leave old status messages at the end of the > line while printing status messages if initial status fit on one line > and new status text required new line. Patches applied. Thanks! Erik --

Janne Hyv?rinen wrote: >> Can you share samples? > > It's a 470 MB copyrighted music album. I could but I don't think it's legal. How about sharing the album name (if it's popular enough)? (but then it would be good to post its CUETools verification log if the album has multiple pressings with different offsets...)

On 9.3.2015 20:43, lvqcl wrote: > Janne Hyv?rinen wrote: > >> VLC 2.2.0 crashed with exception 0xc0000005 on the first file I tried. >> But libflac itself does not, for example flac.exe and foobar2000 have no >> issues. > *Very* interesting. > > I suspect that flac.exe and foobar2000 don't use > FLAC__lpc_restore_signal_16_intrin_sse2() function at all. This

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's

Janne Hyv?rinen wrote: > Patch v2, now handles more malformed cases. Original patch was for a > file for which I had a sample from a user but this allows handling some > manually broken test cases. Err, I'm getting warning messages on that patch: CC metadata_iterators.lo metadata_iterators.c: In function ?read_metadata_block_data_vorbis_comment_cb_?:

I'd definately recommend binaries for download as suggested by lvqcl and Janne Hyv?rinen. All the fabolous work on the code base is of little use to me if I can not find binaries at the official site. Olav Sunde At 12:01 23.11.2014, Janne Hyv?rinen wrote: >On 23.11.2014 12:44, Erik de Castro Lopo wrote: >> lvqcl wrote: >>> 2) Do you plan to release any official binaries

Decoding flac files is also prone to producing fragmented files. NTFS has the ability to completely avoid fragmentation if it is told the file size before hand, but that would require using special Windows-only functions. Increasing the write buffer from the default 512 bytes to 10 MB already reduces the problem tremendously. -------------- next part -------------- diff --git

On 22.5.2013 17:03, Felix Homann wrote: > Sorry that it took so long to reply. As mentioned in an earlier mail > my first bisect session wasn't accurate. I've done a new one: > > Here's my patch suggestion but I'm no Android guy. -------------- next part -------------- diff --git a/src/flac/utils.c b/src/flac/utils.c index e908706..6f6382e 100644 ---

On 25.5.2013 10:54, Erik de Castro Lopo wrote: > Robert Kausch wrote: > >> Hi all, >> >> I tried 1.3.0pre4 with ICL on Windows and found some issues. Not sure if >> this is the right place to submit patches, but someone suggested this on >> the apparently dead SourceForge patch tracker. >> >> The first two are quite straight forward: >>