similar to: [flac 1.3.0pre2 pre-release] Updates to test suite

Seems time is going to be a constraint for me in the coming week, but I'll try and get more of these out to you as fast as I can get them written and tested. Keeping the patches in a separate branch for now seems like a good idea to me. Attached is a patch for 'test_streams.sh' On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Jaren

Jaren Stangret wrote: > Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as > the other patches, this patch consists of minor reworks of > functions/commands as well as heavily commenting what's going on. > > More than halfway there! Jaren, Any sign of the patches for the rest of these tests? I have some other changes to the tests that I'd

Jaren Stangret wrote: > Interestingly, I noticed compression level '0' is omitted, so I've added it > in. Thanks. > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between > compression level 0 and compression level 1 -- the file size was greater > with a compression level of 1, rather than 0. The test works on > 'noisy-sine.wav'. It

Janne Hyv?rinen wrote: > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > Janne Hyv?rinen wrote: > > > >> The patch was made from the published pre2 version. It missed the MinGW > >> changes that were applied to git version. > > Patch applied. Thanks. > > > > Erik > > Unfortunately with this commit the LRN's patch from commit

Attached is a patch for 'test_compression.sh'. Interestingly, I noticed compression level '0' is omitted, so I've added it in. Also, I tested this on a 24bit/96kHz FLAC file and the test failed between compression level 0 and compression level 1 -- the file size was greater with a compression level of 1, rather than 0. The test works on 'noisy-sine.wav'. It may be

Jaren Stangret wrote: > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 Last night I did a git bisect on this issue and this error arose when I changed the version from "1.2.1" to "1.3.0pre1".

Gentoo bundles flac 1.2.1 with numerous patches applied. Some of these patches are already included in upstream flac-dev (for example the gcc 4.3 cstring issue). Below are the patches supplied by Gentoo (merged against MASTER) and with the Changelog explanations of them as well as the discussion link surrounding the patch: *flac-9999-asm.patch:* *28 Sep 2007; Samuli Suominen <drac at

Erik, I was thinking of doing this: export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % 255 + 1) }') Or would you prefer using 'date'? On Tue, Mar 19, 2013 at 10:22 PM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Jesse Weinstein wrote: > > > The subject line mostly says it all, but for reference, having #!/bin/sh > causes

I'd also like to note that this is happening for me with current HEAD (619b43df36b725e11e12db768d558b1930a583b6). On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret <sirjaren at gmail.com> wrote: > I've been trying to get the test suite cleaned up and even with the > original "untouched" test suite via flac 1.3.0pre2, I'm getting a test > suite failure. >

Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as the other patches, this patch consists of minor reworks of functions/commands as well as heavily commenting what's going on. More than halfway there! Thanks, Jaren On Tue, Mar 12, 2013 at 9:40 PM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > > Jaren Stangret wrote: > > >

Erik, There are changes coming, but I can't give an ETA. I finally have a uniform "feel" to the changes I want to incorporate. The biggest hurdle right now is 'test_flac.sh'. It is a BIG script with a lot of hard to read expressions. Most of my time is spent trying to break it up and make it more legible, while still maintaining the correct behavior/execution. Sorry for

On Mar 11, 2013, at 21:37, Erik de Castro Lopo wrote: > Jaren Stangret wrote: > >> Hi all, >> >> I'm currently going through the massive test suite, updating all the >> scripts making sure they conform to the POSIX standard. >> >> I've added a bunch of comments to them and have slightly changed/ >> reworked >> some of the functions to

Hi Erik, I've noticed a couple small things missing in the metaflac man pages. Namely, the new sample rates provided by Earl Chew as well as the PICTURE block being a valid block type. Attached is a patch for metaflac.sgml and metaflac.1 that details the new sample rates metaflac's replaygain supports. Also, there is now the PICTURE block added as a valid block type. Thanks!

I agree on everything you said. I did not intend or expect to have pre-release flac bundled with software, but can understand the dismay at my earlier request. If people think there should be a snapshot version for testing, I'm all for it, especially now that the build system has undergone some changes. I found that for some source distros, the removal of autogen.sh's prior features and

I know Erik is busy with maintenance and wants to get a release out soon. In the meantime, is it appropriate to tag HEAD as 1.2.1_git and include this in the CLI tools (flac, metaflac, etc)? This would make it easier to allow programs in development to test against git flac and older flac versions. For example, sample rates above 48kHz (for ReplayGain) is available in git flac but not 1.2.1.

That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh | 2 ++ test/test_flac.sh | 2 ++ test/test_grabbag.sh | 2 ++ test/test_libFLAC++.sh | 2 ++ test/test_libFLAC.sh | 3 +++ test/test_metaflac.sh | 2 ++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files

Hi Eric. On Tue, Feb 28, 2012 at 7:57 AM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Hi Klaus, > > I'm not really sure where to start with this one. > > Klaus Schulz wrote: > > > My first post over here. > > > > While working on a music server optimzation (which ususally goes hand in > > hand with running pretty low buffers on

Janne Hyv?rinen wrote: > I thought Ben Allison would have made a patch. Here's a patch for this. > I suppose we were all blind at first for the cause. Applied thanks. I'd now like to look at the 2/4Gig off_t issue in your original support_2gb_output patch. Unlike your original patch, you will have to avoid touchng anything in the directories: include/FLAC include/FLAC++

The subject line mostly says it all, but for reference, having #!/bin/sh causes the following error: arithmetic expression: expecting primary: " % 255 + 1" --- test/test_flac.sh | 2 +- test/test_grabbag.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_flac.sh b/test/test_flac.sh index 10981c0..257c5ea 100755 --- a/test/test_flac.sh +++

test_streams currently depends on grabbag and (on Windows) on win_utf8_io libs. It depends on win_utf8_io only because it uses flac_fopen() function. It will become to depend on libFLAC when all file functions will be moved from win_utf8_io to libFLAC. Not a big problem, but it is possible to avoid this dependency by replacing flac_fopen() with fopen(). test_streams doesn't open/create